WIP: Draft: Resolve "Instructions can be linked to a document as remarks by the group" #605
Draft
hansegucker wants to merge 24 commits from
174-instructions-can-be-linked-to-a-document-as-remarks-by-the-group into master
pull from: 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-group
merge into: aleksis:master
aleksis:master
aleksis:370-nfc-based-centralized-attendance-tracking-in-open-education
aleksis:weblate-frontend
aleksis:weblate
aleksis:377-adapt-fullscreen-statistics-for-person-page-follow-up-from-draft-port-to-vue3
aleksis:376-re-add-coursebookloader-follow-up-from-draft-port-to-vue3
aleksis:docs
aleksis:check/update-merge-request-template
aleksis:check/update-builddeps-package-json
aleksis:check/update-eslint-rc-js
aleksis:check/update-tox-ini
aleksis:369-adapt-to-object-url-schema
aleksis:363-date-range-displayed-in-coursebook-is-wrong
aleksis:360-add-some-kind-of-text-to-long-term-absence-fab-in-absence-overview
aleksis:adapt-to-caldav
aleksis:350-make-permission-checks-for-absences-and-personal-notes-list-on-statistics-page-efficient
aleksis:335-allow-access-to-other-groups-for-special-roles-like-school-management
aleksis:269-include-class-register-in-calendar-dialog
aleksis:330-make-days-more-distinguishable-in-coursebook
aleksis:release/4.0.0.dev9
aleksis:342-ordering-of-affected-lessons-in-register-absence-dialog-is-wrong
aleksis:324-graphqlerror-can-t-compare-offset-naive-and-offset-aware-datetimes
aleksis:340-disable-list-of-participations-button-during-documentation-save
aleksis:333-kolego-absences-are-not-properly-taken-into-regard-when-creating-participation-statuses
aleksis:308-follow-up-from-resolve-add-absence-overview-page
aleksis:release/4.0.0.dev7
aleksis:release/4.0.0.dev6
aleksis:311-creating-absence-fails-absence-reasons-do-not-load
aleksis:reformat
aleksis:migration-to-fix-unique-constraints
aleksis:295-respect-permissions-in-coursebook-frontend
aleksis:280-reduce-top-app-bar-in-coursebook-make-collapsible
aleksis:289-fix-coursebook-permissions-for-participation-statuses-and-personal-notes-from-student
aleksis:engs-4.0
aleksis:261-add-absence-management-to-course-book-student-dialog-2
aleksis:279-follow-up-from-draft-resolve-migrate-to-new-data-model
aleksis:256-add-simple-course-book-list
aleksis:rebased2-michael-scrollt
aleksis:rebased-michael-scrollt
aleksis:michael-scrollt
aleksis:259-add-dialog-with-each-lesson-s-students
aleksis:246-roadmap-migrate-to-new-data-model
aleksis:tmp/demo
aleksis:stable-3.0
aleksis:engs-coursebook-print
aleksis:249-migrations-broken-on-empty-db
aleksis:251-lessons-doesn-t-get-cancelled-by-events-in-my-timetable
aleksis:engs
aleksis:prepare-release-3.0b0
aleksis:243-personalnote-gets-deleted-without-warning-when-a-person-is-marked-as-excused-but-not-absent
aleksis:244-fix-wrong-redirect-url-after-editing-seating-plan-from-class-register
aleksis:239-linter
aleksis:233-adjust-for-operation-with-new-spa
aleksis:feature/core-3.0
aleksis:feature/vuejs
aleksis:211-prevent-double-counting-of-absences
aleksis:replace-ugettext-with-gettext
aleksis:230-attributeerror-nonetype-object-has-no-attribute-period
aleksis:216-the-content-of-lessons-should-be-able-to-be-entered-by-each-teacher-involved-in-the-event
aleksis:menu-register-absence-rule-error
aleksis:174-instructions-can-be-linked-to-a-document-as-remarks-by-the-group-2
aleksis:hhg
aleksis:backup-vuejs
aleksis:test/lessondoculist
aleksis:test/vuejs
aleksis:213-use-iconify-for-material-icons-instead-of-icon-font
aleksis:i10n-ru-ua
aleksis:183-allow-group-roles-to-be-specific-to-one-group-type
aleksis:124-provide-relevant-personal-notes-with-selected-filter-as-dashboard-widget
aleksis:tmp/aleksis-engs
aleksis:212-absences-are-carried-over-to-lessons-student-is-no-member-of
aleksis:release-2.0
aleksis:add-docs
aleksis:revert-0d064fd6
aleksis:199-date-select-for-registering-absences-unusable-ticket-75918
aleksis:core-284-unify-permission-names
aleksis:185-show-only-personal-notes-from-current-term-2
aleksis:70-add-link-in-chronos-views
aleksis:152-group-hierarchies-handled-incompletely
aleksis:188-add-useful-information-to-current-lesson-404
aleksis:197-fix-readme
aleksis:prepare-release-2.0rc7-2
aleksis:prepare-release-2.0rc7
aleksis:update/tox-makemessages
aleksis:release/2.0
aleksis:181-bulk_update-missing-1-required-positional-argument-fields-2
aleksis:159-add-link-to-next-missing-lesson-documentation-for-teachers
aleksis:trigger_dist_build
aleksis:trigger-dist-pipeline
aleksis:fix-ci-config
aleksis:fix/typo
aleksis:138-do-not-show-my-overview-for-teachers
aleksis:136-date-overflows-box-in-print-view-when-only-a-few-lessons-are-displayed
aleksis:update/poetry-2
aleksis:130-group-members-are-counted-multiple-times-in-my_students
aleksis:test-foo
aleksis:update-lockfile
aleksis:126-aleksis-admin-yarn-install-needs-a-database
aleksis:gettext-lazy
aleksis:update-tox2
aleksis:update-tox
aleksis:122-make-previous-next-lesson-buttons-independent-of-validity-range
aleksis:117-create-revisions-in-django-reversion-for-all-changes-that-need-auditing
aleksis:feature/use-entrypoints
aleksis:fix/update-or-create
aleksis:mix/perms
aleksis:comb/rules-week
aleksis:77-rename-core-template-references
aleksis:file-refs
aleksis:49-printout-lesson-periods-missing-in-week-summary
aleksis:38-week-view-personal-notes-only-work-when-filtering-by-group
aleksis:48-printout-pages-can-overflow
aleksis:46-printout-add-one-page-per-student-in-group
aleksis:2-register-absences-and-excuses-centrally
aleksis:29-lesson-view-show-summary-homework-etc-of-previous-lessons
aleksis:fix-buttons
No reviewers
Labels
Clear labels
Security
TeX
Needs LaTeX template
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
Backend (view code, models, logic, etc.)
part
ci
part
docs
Issue or addition to the documentation
part
frontend
Frontend (templates, etc.)
part
i18n
Translation or internationalisation issue
part
non-technical
Non-technical (policy, maintenance, etc.) issue or discussion
part
packaging
Issue concerning the packaging of AlekSIS and components
prio
1
Priority High
prio
2
Priority Medium
prio
3
Priority Low
release-mr-5.x
size
large
size
medium
size
small
source
customer
Requested by a customer or affiliated user
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
Issue or merge request from other projects using AlekSIS or parts of it
type
breaking
type
bug
Bug
type
feature
New feature
type
refactoring
workflow
blocked
Issue is blocked by another issue
workflow
confirmed
The bug is reproducible and will be fixed
workflow
current-todo
workflow
discussing
Needs to be discussed before implementation
workflow
new-app
Requires new AlekSIS app, which has to be created
workflow
wontfix
The bug is not reproducible or the feature was decided against
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-App-Alsijil!605
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "174-instructions-can-be-linked-to-a-document-as-remarks-by-the-group"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #174
assigned to @hansegucker
added 1 commit
b4f8fb24- Add instruction modelCompare with previous version
added 1 commit
6846cec1- Add views for listing instructionsCompare with previous version
added 7 commits
master721c03d3- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 2 commits
Compare with previous version
added 36 commits
masterca376d51- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 150 commits
mastera55279d4- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 1 commit
72775aa9- Add views for managing instructionsCompare with previous version
added 3 commits
master282a206f- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 4 commits
e2a9ac59- Adjust permissions for instructionsb0dd660b- Make school term a required field for instructions8666add0- Add option to mark instructions as done in lesson documentationf32dba55- Show done instructions also in read-only modeCompare with previous version
added 1 commit
c0a45082- Add filter for instructions and redesign instructons list viewCompare with previous version
added 1 commit
82fb5a14- Add view for evaluating done instructionsCompare with previous version
added 1 commit
ea972e84- Update changelogCompare with previous version
marked this merge request as ready
assigned to @nik and unassigned @hansegucker
requested review from @fph
added 36 commits
master6a53d555- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 1 commit
6f993e86- Update translationsCompare with previous version
added 1 commit
3266de21- Use Iconify icons for instructionsCompare with previous version
added 1 commit
9ebacf89- Update changelogCompare with previous version
I think this MR is missing some important parts of this feature:
Two options:
Mising doc string
Misisng doc string
Missing doc string
The word "done" does not seem correct here. "given", maybe?
Missing doc string
Is it necessary to limit this to PDFs?
Something to consider:
We have a long-standing feature request in Core to introduce agreements: AlekSIS/official/AlekSIS-Core#157
I think that we should maybe combine this, and therefore move the "instruction" model to the core as "agreement".
Rationale: An agreement is an agreement, independent of the formal procedure of agreement. An agreement can be displayed on registration, or before being allowed to perform a specific action, or it can be given as an instruction. In the end, it is still an agreement that is tracked.
Example of where this overlaps:
@hansegucker open for discussion
@hansegucker open for discussion
added 23 commits
masterbc8fcb2e- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
marked this merge request as draft
added 7 commits
master002fa18c- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
The main difference seems to be a formal one: Instructions are something students and/or parents are not free to agree or disagree with, they are just instructed about a certain formal procedure or law.
But this hasn't to be a larger technical difference.
Of course they are. If they don't, they cannot use the features guarded by the instruction, e.g. take part in a chemistry class. There will probably be consequences, like expulsion from school, but ultimately, that is no different from disagreeing with a privacy statement and thus being exempt from using a website.
added 11 commits
master16842af6- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
What is the current state of this MR? Is there a reason that the unresolved threads were not resolved so far?
Yes, there is one. We agreed to (re)structure the whole system of agreements and instructions from bottom up and in AlekSIS-Core.
added 63 commits
master46670c45- Merge branch 'master' into 174-instructions-can-be-linked-to-a-document-as-remarks-by-the-groupCompare with previous version
added 1 commit
40d9344c- Make instruction frontend compatible with new Vue frontendCompare with previous version
added 1 commit
b0cf65fa- Update translation filesCompare with previous version
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.