aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Overview of all register objects #542

Merged
hansegucker merged 19 commits from feature/lesson-documentation-overview into master 2021-03-18 14:15:20 +01:00
Conversation 46 Commits 19 Files changed 14 +891 -242
hansegucker commented 2021-03-03 11:03:06 +01:00 (Migrated from edugit.org)
Copy link

Close #137

Close #137
hansegucker commented 2021-03-04 16:59:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f122b128 - Add overview of all register objects for coordinators ("All lessons")

Compare with previous version

added 1 commit <ul><li>f122b128 - Add overview of all register objects for coordinators (&quot;All lessons&quot;)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5165&start_sha=da7996a85ee923769a0192e72956abb31d0cce13)
hansegucker commented 2021-03-10 11:39:14 +01:00 (Migrated from edugit.org)
Copy link

added 11 commits

  • f122b128...d142255a - 8 commits from branch master
  • 7936ea14 - Add support for sending notifications in "All lessons" via actions
  • dd0e3b8c - Add link to register object in all columns of RegisterObjectTable
  • 4ca13541 - Merge branch 'master' into feature/lesson-documentation-overview

Compare with previous version

added 11 commits <ul><li>f122b128...d142255a - 8 commits from branch <code>master</code></li><li>7936ea14 - Add support for sending notifications in &quot;All lessons&quot; via actions</li><li>dd0e3b8c - Add link to register object in all columns of RegisterObjectTable</li><li>4ca13541 - Merge branch &#39;master&#39; into feature/lesson-documentation-overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5375&start_sha=f122b128b75ca46cc04c85a229fd7e6bde1d5929)
hansegucker commented 2021-03-11 12:26:11 +01:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 4ca13541...dfaca385 - 7 commits from branch master
  • a0fe79e8 - Merge branch 'master' into feature/lesson-documentation-overview

Compare with previous version

added 8 commits <ul><li>4ca13541...dfaca385 - 7 commits from branch <code>master</code></li><li>a0fe79e8 - Merge branch &#39;master&#39; into feature/lesson-documentation-overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5481&start_sha=4ca135418b5100fa21c390d88a21ec2904a232c1)
hansegucker commented 2021-03-12 17:11:33 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 9a34ef22 - Make pks generated in generate_list_of_all_register_objects unique
  • e6ab6837 - Fix notification generation

Compare with previous version

added 2 commits <ul><li>9a34ef22 - Make pks generated in generate_list_of_all_register_objects unique</li><li>e6ab6837 - Fix notification generation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5570&start_sha=a0fe79e8b4c6cbdfe0842b0daa396b40b919be33)
hansegucker commented 2021-03-13 17:28:26 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-03-13 17:28:36 +01:00 (Migrated from edugit.org)
Copy link

@nik Please review.

@nik Please review.
hansegucker commented 2021-03-13 17:28:46 +01:00 (Migrated from edugit.org)
Copy link

For coordinators

image

For teachers

image

## For coordinators ![image](/uploads/40a0c32da0765260d17235ccf5c232cc/image.png) ## For teachers ![image](/uploads/7a9dc5d3431848a24294f55c7da10311/image.png)
nik commented 2021-03-14 15:36:34 +01:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

`\ No newline at end of file`
nik commented 2021-03-14 15:36:35 +01:00 (Migrated from edugit.org)
Copy link

Unrelated change (only amend the new tag library in this MR; do not refactor)

Unrelated change (only amend the new tag library in this MR; do not refactor)
nik commented 2021-03-14 15:36:35 +01:00 (Migrated from edugit.org)
Copy link
  • Missing docstring
  • Please refactor this into split functions (probably marked as private with _ at the beginning). As a rule of thumb, to reduce cyclic complexity, a single funciton should not be longer than ~50 lines and have less than ~3 indentation levels)
* Missing docstring * Please refactor this into split functions (probably marked as private with `_` at the beginning). As a rule of thumb, to reduce cyclic complexity, a single funciton should not be longer than ~50 lines and have less than ~3 indentation levels)
nik commented 2021-03-14 15:36:36 +01:00 (Migrated from edugit.org)
Copy link
    # Always force a selected school term so that queries won't get too big
```suggestion:-0+0 # Always force a selected school term so that queries won't get too big ```
nik commented 2021-03-14 15:36:36 +01:00 (Migrated from edugit.org)
Copy link

This string is not translatable (use %s notation or .format instead)

This string is not translatable (use `%s` notation or `.format` instead)
nik commented 2021-03-14 15:36:37 +01:00 (Migrated from edugit.org)
Copy link
        msg = _("Please check if the following class register entries are complete and correct:") + "\n"

(Or, thinking about it, better use a template to generate this notification text…)

```suggestion:-0+0 msg = _("Please check if the following class register entries are complete and correct:") + "\n" ``` (Or, thinking about it, better use a template to generate this notification text…)
nik commented 2021-03-14 15:36:37 +01:00 (Migrated from edugit.org)
Copy link

Not translatable, see above.

Not translatable, see above.
nik commented 2021-03-14 15:36:37 +01:00 (Migrated from edugit.org)
Copy link

If that is the API, it probably should be a class (needs coordination with AlekSIS-Core!892).

If actions require a simple callable, we should probably write…

class FooAction:
    short_description = "bar"

    def __call__(self):
        pass

Please check.

If that is the API, it probably should be a `class` (needs coordination with AlekSIS-Core!892). If actions require a simple callable, we should probably write… ```python class FooAction: short_description = "bar" def __call__(self): pass ``` Please check.
nik commented 2021-03-14 15:36:38 +01:00 (Migrated from edugit.org)
Copy link

If this is public API, please move it to .util (and add a docstring). If it is not, please mark as private.

If this is public API, please move it to `.util` (and add a docstring). If it is not, please mark as private.
nik commented 2021-03-14 15:36:38 +01:00 (Migrated from edugit.org)
Copy link
        RequestConfig(request).configure(table)  # paginate={"per_page": 100}

Also, what is this trailing comment?

```suggestion:-0+0 RequestConfig(request).configure(table) # paginate={"per_page": 100} ``` Also, what is this trailing comment?
nik commented 2021-03-14 15:36:38 +01:00 (Migrated from edugit.org)
Copy link

Missing docstring

Missing docstring
hansegucker commented 2021-03-14 15:53:52 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • e6ab6837...976b2ef4 - 2 commits from branch master
  • 41541a8e - Merge branch 'master' into feature/lesson-documentation-overview

Compare with previous version

added 3 commits <ul><li>e6ab6837...976b2ef4 - 2 commits from branch <code>master</code></li><li>41541a8e - Merge branch &#39;master&#39; into feature/lesson-documentation-overview</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5776&start_sha=e6ab6837602230c6b041f466c7b6ab0b450fe5ee)
hansegucker commented 2021-03-14 16:46:47 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • af3c8567 - Move custom columns to util namespace

Compare with previous version

added 1 commit <ul><li>af3c8567 - Move custom columns to util namespace</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5780&start_sha=41541a8e72dcbe9b58027ef2422748dbe1a58caa)
hansegucker commented 2021-03-14 17:09:15 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5782&start_sha=af3c8567ffb2777a732cc6c1579cbb1e5501174c#b6a94af0e73891f3f73678833a0a07d23f3ade75_59_19)
hansegucker commented 2021-03-14 17:09:16 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5782&start_sha=af3c8567ffb2777a732cc6c1579cbb1e5501174c#dd6fc5bcb0154e37059551f576db2a46f76da8ee_29_33)
hansegucker commented 2021-03-14 17:09:17 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • dabdf514 - Move register objects table stuff to own template file
  • e120eca7 - [Lesson overview] Use template engine for notification body

Compare with previous version

added 2 commits <ul><li>dabdf514 - Move register objects table stuff to own template file</li><li>e120eca7 - [Lesson overview] Use template engine for notification body</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5782&start_sha=af3c8567ffb2777a732cc6c1579cbb1e5501174c)
hansegucker commented 2021-03-14 17:13:51 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5783&start_sha=e120eca78ccbd7b829707f6a1691d2cb6625c8c6#dd6fc5bcb0154e37059551f576db2a46f76da8ee_31_30)
hansegucker commented 2021-03-14 17:13:52 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 89afc4be - Remove f-strings in translation

Compare with previous version

added 1 commit <ul><li>89afc4be - Remove f-strings in translation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5783&start_sha=e120eca78ccbd7b829707f6a1691d2cb6625c8c6)
hansegucker commented 2021-03-14 17:16:36 +01:00 (Migrated from edugit.org)
Copy link

I would keep it as close as possible to the original Django admin actions: https://docs.djangoproject.com/en/3.1/ref/contrib/admin/actions/#writing-action-functions

I would keep it as close as possible to the original Django admin actions: https://docs.djangoproject.com/en/3.1/ref/contrib/admin/actions/#writing-action-functions
hansegucker commented 2021-03-14 17:31:23 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5784&start_sha=89afc4bedb77b2be5ea77a544a3f132610b0bb50#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_922_922)
hansegucker commented 2021-03-14 17:31:24 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c4dd462f - Get items per page from preferences

Compare with previous version

added 1 commit <ul><li>c4dd462f - Get items per page from preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5784&start_sha=89afc4bedb77b2be5ea77a544a3f132610b0bb50)
hansegucker commented 2021-03-14 17:32:36 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5785&start_sha=c4dd462f21eec9c706141eb16ba6a4986595ea51#520399a9947a55581328ec82db32231913e11c2a_85_85)
hansegucker commented 2021-03-14 17:32:37 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8db232ff - Make get_link for tables private

Compare with previous version

added 1 commit <ul><li>8db232ff - Make get_link for tables private</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5785&start_sha=c4dd462f21eec9c706141eb16ba6a4986595ea51)
hansegucker commented 2021-03-15 11:51:25 +01:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS-App-Chronos!528

mentioned in merge request AlekSIS-App-Chronos!528
hansegucker commented 2021-03-15 11:52:08 +01:00 (Migrated from edugit.org)
Copy link

Blocked by AlekSIS/official/AlekSIS-App-Chronos!528 and AlekSIS/official/AlekSIS-Core!892

Blocked by AlekSIS/official/AlekSIS-App-Chronos!528 and AlekSIS/official/AlekSIS-Core!892
hansegucker commented 2021-03-15 11:55:03 +01:00 (Migrated from edugit.org)
Copy link

@nik Please review again.

@nik Please review again.
hansegucker commented 2021-03-15 11:55:04 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5818&start_sha=8db232ff420f559c34dcb30c3aeb734ab79537e8#61d7f3143d022dfa8c0d301a9ded744243043aba_115_109)
hansegucker commented 2021-03-15 11:55:05 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5818&start_sha=8db232ff420f559c34dcb30c3aeb734ab79537e8#61d7f3143d022dfa8c0d301a9ded744243043aba_118_339)
hansegucker commented 2021-03-15 11:55:05 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-03-15 11:55:08 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 5a9e7d73 - Refactor generate_list_of_all_register_objects to multiple smaller functions
  • f3f4744b - Add missing docstring for AllRegisterObjectsView

Compare with previous version

added 2 commits <ul><li>5a9e7d73 - Refactor generate_list_of_all_register_objects to multiple smaller functions</li><li>f3f4744b - Add missing docstring for AllRegisterObjectsView</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5818&start_sha=8db232ff420f559c34dcb30c3aeb734ab79537e8)
hansegucker commented 2021-03-15 11:57:52 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f2e9c34f - Add missing docstring for AllRegisterObjectsView

Compare with previous version

added 1 commit <ul><li>f2e9c34f - Add missing docstring for AllRegisterObjectsView</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5819&start_sha=f3f4744b39c20325d7a5388c9ca6a335454fa670)
nik commented 2021-03-17 22:07:19 +01:00 (Migrated from edugit.org)
Copy link

Please comment this function.

(Nobody ever said, by the way, that docstrings in private functions are forbidden ;)!)

Please comment this function. (Nobody ever said, by the way, that docstrings in private functions are forbidden ;)!)
nik commented 2021-03-17 22:07:20 +01:00 (Migrated from edugit.org)
Copy link

Missing docstring

Missing docstring
nik commented 2021-03-17 22:07:20 +01:00 (Migrated from edugit.org)
Copy link

Missing docstring

Missing docstring
nik commented 2021-03-17 22:07:20 +01:00 (Migrated from edugit.org)
Copy link

Missing docstring

Missing docstring
hansegucker commented 2021-03-18 10:18:47 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-03-18 10:18:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6f73dfb2 - Add missing doc strings for forms and helpers

Compare with previous version

added 1 commit <ul><li>6f73dfb2 - Add missing doc strings for forms and helpers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/152/diffs?diff_id=5922&start_sha=f2e9c34fc7f03f3231fb6947d97904c4be27d04f)
hansegucker commented 2021-03-18 10:18:58 +01:00 (Migrated from edugit.org)
Copy link

@nik Please review again.

@nik Please review again.
nik (Migrated from edugit.org) merged commit 75d5c187e3 into master 2021-03-18 14:15:20 +01:00
nik commented 2021-03-18 14:15:24 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 75d5c187e3

mentioned in commit 75d5c187e31cea0dd669c537b018911242f48b73
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!542
No description provided.