Resolve "Add support for assinging group roles" #521
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aleksis/AlekSIS-App-Alsijil!521
Loading…
Reference in a new issue
No description provided.
Delete branch "69-add-support-for-assinging-class-roles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #69
Button in "My groups"
Group roles page for groups
Tab 1:
Tab 2:
Dropdown:
Assign form for a single group
View in week view
Personal notes tab
Lesson view
Personal notes tab
Menu item for global form
Global form
added 2 commits
93ef18e3- Add models for class roles6450ff00- Add views for managing class rolesCompare with previous version
assigned to @nik
Please mind that we call this "group", not "class".
added 3 commits
48df9a98- Replace class role icons by a better fitting one13d91129- Rename class role to group roleb06a6501- Add group role assignments overview and managing viewsCompare with previous version
added 17 commits
master3a87c2f8- Merge branch 'master' into 69-add-support-for-assinging-class-rolesCompare with previous version
added 5 commits
master4ccf137e- Merge branch 'master' into 69-add-support-for-assinging-class-rolesCompare with previous version
changed title from Draft: Resolve "Add support for assinging {-class-} roles" to Draft: Resolve "Add support for assinging {+group+} roles"
added 3 commits
1fa84476- Add managers and querysets for group role models to simplify queries3a337afd- [Group roles] Restructure templates by adding a partials foldere67cff0a- Show group roles in week view of groupsCompare with previous version
added 3 commits
0b147eea- Fix assigned_roles.html and AssignGroupRoleView for independent usage6b054c9c- [Group roles] Check permissions in week viewccd49962- Show group roles in lesson viewCompare with previous version
added 1 commit
1b2a4793- Add global form to assign group rolesCompare with previous version
added 1 commit
fd73737a- Remove legacy field dependency in AssignGroupRoleFormCompare with previous version
marked this merge request as ready
changed the description
requested review from @ZugBahnHof
Ready to review, @nik
What is an "Innenliste"?
Where did you find this?
Oh, I see, do you mean "Schüler*innenliste"? Anyway, this wasn't added or changed in this MR.
resolved all threads
Have we previously been shipping such broken translations?
Oh wow.
Please use a callable to generate these choices, so migrations do not take over the constant.
(This probably requires changes elsewhere.)
Wh ydo we limit colours to materia lcolours, instead of using a regular
ColourField?Do we really need such a preference? We never did that AFAIR, allowing an entire feature to be disabled.
Apart from the minor discussion items, it looks really awesome and far more thought through than I would have drafted it!
@ZugBahnHof Please review asap.
approved this merge request
unapproved this merge request
I am unsure how to do this because the
choicesattribute doesn't accept any callables.I don't need this preference. Maybe we should ask the rest. @ZugBahnHof @debdolph @fph @yuha: What are your opinions?
changed this line in version 9 of the diff
added 6 commits
master8ce1b930- Merge branch 'master' into 69-add-support-for-assinging-class-rolesd3143a65- [Group roles] Use ColorField instead of fixed Materialize colorsCompare with previous version
Well, we should either have feature flags for all features, or for none. Discussing that is not part of this merge request.
What do you mean by "the choices argument doesn't accept any callables"?
But, now I looked at the docs again, enumeration choices seem a better fit: https://docs.djangoproject.com/en/3.1/ref/models/fields/#field-choices-enum-types
Then I will remove this for the time being.
added 1 commit
6f37e7ef- Use improved SuccessNextMixin everywhereCompare with previous version
Sad story: Enumeration choices are only syntactic sugar. They also result in a list of tuples being generated and pulled into the migration.
changed this line in version 11 of the diff
added 1 commit
d69b2fdb- Replace choices list with callableCompare with previous version
Resolved this with a lambda function for now. Let's focus on the real stuff and maybe migrate to a real icon field later as a globa ltopic.
changed this line in version 12 of the diff
added 1 commit
Compare with previous version
Done.
resolved all threads
added 1 commit
51bbefe6- Remove feature flag for group rolesCompare with previous version
mentioned in commit
b438cbca3d