aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Resolve "[Person overview] Implement multiple selection for marking absences as excused or for deleting" #501

Merged
ZugBahnHof merged 51 commits from 115-person-overview-implement-multiple-selection-for-marking-absences-as-excused-or-for-deleting into master 2021-05-16 17:20:45 +02:00
Conversation 58 Commits 51 Files changed 10 +479 -333
ZugBahnHof commented 2020-11-28 15:36:04 +01:00 (Migrated from edugit.org)
Copy link

Closes #121
Closes #115

Closes #121 Closes #115
ZugBahnHof commented 2020-11-29 17:29:09 +01:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • 5939c898 - Implement multiple selection in person overview
  • 14515d3e - Reposition the select
  • 6af863fc - Beautify css
  • b4d06ea1 - Minify python code
  • d5e926c2 - Change visual appearance (=css)
  • c4896803 - Move form
  • a1ffb79f - Write JS code for beautiful multiple select

Compare with previous version

added 7 commits <ul><li>5939c898 - Implement multiple selection in person overview</li><li>14515d3e - Reposition the select</li><li>6af863fc - Beautify css</li><li>b4d06ea1 - Minify python code</li><li>d5e926c2 - Change visual appearance (=css)</li><li>c4896803 - Move form</li><li>a1ffb79f - Write JS code for beautiful multiple select</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=3980&start_sha=5fb87b07c99b45394cbd745cc398f5e08b735e17)
ZugBahnHof commented 2020-11-29 17:47:24 +01:00 (Migrated from edugit.org)
Copy link

Alsijil-Select-Multiple-2020-11-29_17.18.38

![Alsijil-Select-Multiple-2020-11-29_17.18.38](/uploads/a1526431d233e26d7e260e0175f84b86/Alsijil-Select-Multiple-2020-11-29_17.18.38.mp4)
ZugBahnHof commented 2020-12-11 16:44:23 +01:00 (Migrated from edugit.org)
Copy link

Update: merge both views of absences to one, use filters n stuff, maybe keep the left side as optional. Use default filters for quickly displaying the needed information. Multiple select and actions anywhere. If I forgot anything, @hansegucker and @nik pls replay to this message

Update: merge both views of absences to one, use filters n stuff, maybe keep the left side as optional. Use default filters for quickly displaying the needed information. Multiple select and actions anywhere. If I forgot anything, @hansegucker and @nik pls replay to this message
nik commented 2020-12-19 20:42:42 +01:00 (Migrated from edugit.org)
Copy link

Is this still a draft now, or not?

Is this still a draft now, or not?
ZugBahnHof commented 2020-12-20 11:23:55 +01:00 (Migrated from edugit.org)
Copy link

Yes it is, because the person overview is going to be restructured. There is a meeting on monday, where this page is getting simplified.

Yes it is, because the person overview is going to be restructured. There is a meeting on monday, where this page is getting simplified.
debdolph commented 2021-01-17 19:01:45 +01:00 (Migrated from edugit.org)
Copy link

added 63 commits

  • a1ffb79f...0ff75da0 - 62 commits from branch master
  • 3c98c9bc - Merge branch 'master' into...

Compare with previous version

added 63 commits <ul><li>a1ffb79f...0ff75da0 - 62 commits from branch <code>master</code></li><li>3c98c9bc - Merge branch &#39;master&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=4379&start_sha=a1ffb79f8058a9afc454a1d41b49ead7cc3b60bf)
debdolph commented 2021-01-17 23:26:45 +01:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • f34c73e3 - Add filled in checkboxes
  • 6dad45b8 - Fix model mixins
  • 48d65874 - Create a basic table for all PersonalNotes of an user
  • 082ca266 - Include said table in the view
  • 661d2b7d - Include said table in the template and move statistics to another tab
  • 31144fe8 - Create a link to personal notes to display in the table
  • b527e321 - Fix icon bug
  • 1859b578 - Merge branch...

Compare with previous version

added 8 commits <ul><li>f34c73e3 - Add filled in checkboxes</li><li>6dad45b8 - Fix model mixins</li><li>48d65874 - Create a basic table for all PersonalNotes of an user</li><li>082ca266 - Include said table in the view</li><li>661d2b7d - Include said table in the template and move statistics to another tab</li><li>31144fe8 - Create a link to personal notes to display in the table</li><li>b527e321 - Fix icon bug</li><li>1859b578 - Merge branch...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=4395&start_sha=3c98c9bcd1806fa4705957d28bc5924a5ca0c9df)
hansegucker commented 2021-02-19 16:37:46 +01:00 (Migrated from edugit.org)
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2021-02-19 16:37:49 +01:00 (Migrated from edugit.org)
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker commented 2021-02-19 16:37:50 +01:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker and removed review request for @ZugBahnHof

requested review from @hansegucker and removed review request for @ZugBahnHof
ZugBahnHof commented 2021-03-08 18:46:59 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 029dd950 - doofer commit 3
  • 7ae06097 - doofer commit 4

Compare with previous version

added 2 commits <ul><li>029dd950 - doofer commit 3</li><li>7ae06097 - doofer commit 4</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=5280&start_sha=1859b578bb234d3d6237e4782e357c97f45be2a2)
hansegucker commented 2021-03-09 09:54:44 +01:00 (Migrated from edugit.org)
Copy link

added 118 commits

  • 7ae06097...944b3661 - 102 commits from branch master
  • 55d1b882 - Implement multiple selection in person overview
  • e93d1aff - Reposition the select
  • 94ed3b83 - Beautify css
  • ba27da8f - Minify python code
  • 41b592cc - Change visual appearance (=css)
  • 4cfb5f5d - Move form
  • a6b9380e - Write JS code for beautiful multiple select
  • 44e7e2e9 - Add filled in checkboxes
  • 9c8d30a5 - Create a basic table for all PersonalNotes of an user
  • 68ad7d31 - Include said table in the view
  • 27284019 - Include said table in the template and move statistics to another tab
  • 1a85fb01 - Create a link to personal notes to display in the table
  • b13ae6fb - Fix icon bug
  • 19cbe8f5 - Implement action form with multiple-select in table for person overview
  • 6465643d - Fix table generation for use with events and extra lessons
  • 4c809b44 - Fix action form usage

Compare with previous version

added 118 commits <ul><li>7ae06097...944b3661 - 102 commits from branch <code>master</code></li><li>55d1b882 - Implement multiple selection in person overview</li><li>e93d1aff - Reposition the select</li><li>94ed3b83 - Beautify css</li><li>ba27da8f - Minify python code</li><li>41b592cc - Change visual appearance (=css)</li><li>4cfb5f5d - Move form</li><li>a6b9380e - Write JS code for beautiful multiple select</li><li>44e7e2e9 - Add filled in checkboxes</li><li>9c8d30a5 - Create a basic table for all PersonalNotes of an user</li><li>68ad7d31 - Include said table in the view</li><li>27284019 - Include said table in the template and move statistics to another tab</li><li>1a85fb01 - Create a link to personal notes to display in the table</li><li>b13ae6fb - Fix icon bug</li><li>19cbe8f5 - Implement action form with multiple-select in table for person overview</li><li>6465643d - Fix table generation for use with events and extra lessons</li><li>4c809b44 - Fix action form usage</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=5298&start_sha=7ae06097d79014f41911ab104eef1593bd0ea27a)
hansegucker commented 2021-03-09 09:58:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fa9c85ce - Reformat and fix linter</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=5300&start_sha=4c809b44fbeae1bb33a8d230067081da840a6716)
ZugBahnHof commented 2021-04-15 14:52:57 +02:00 (Migrated from edugit.org)
Copy link

added 60 commits

  • fa9c85ce...14cfe3f2 - 59 commits from branch master
  • c8771f09 - Merge branch master into branch...

Compare with previous version

added 60 commits <ul><li>fa9c85ce...14cfe3f2 - 59 commits from branch <code>master</code></li><li>c8771f09 - Merge branch master into branch...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=7238&start_sha=fa9c85ce81d90e2aa6c9a9e4a8a634a96d63b88b)
ZugBahnHof commented 2021-04-16 01:14:13 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 593d3d1e - Move statistics to a real extra tab
  • c3761ce4 - Reformat person.html
  • f81e6ed3 - Remove old markup
  • f94b0c3d - Clean up code and add comments
  • c63fdd2c - Remove old JS file and use the core version instead
  • 5e992e27 - Redesign action selection form

Compare with previous version

added 6 commits <ul><li>593d3d1e - Move statistics to a real extra tab</li><li>c3761ce4 - Reformat person.html</li><li>f81e6ed3 - Remove old markup</li><li>f94b0c3d - Clean up code and add comments</li><li>c63fdd2c - Remove old JS file and use the core version instead</li><li>5e992e27 - Redesign action selection form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=7274&start_sha=c8771f091d15f8e2398a20f7be322471b5355995)
ZugBahnHof commented 2021-04-16 01:19:37 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 692a0692 - Create an action to mark personal notes as unexcused

Compare with previous version

added 1 commit <ul><li>692a0692 - Create an action to mark personal notes as unexcused</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=7275&start_sha=5e992e2763bde4880cbceb1334fba01ea2f46ff5)
ZugBahnHof commented 2021-05-15 23:01:58 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 1c87afd0 - Create a filter for some basic personal note attributes
  • 5559ac94 - Annotate subject and date in the personal note queryset
  • 26a4d506 - Filter date and subject of personal notes
  • c542ac80 - Put filter form in a model and display the number of applied filters
  • de1ea314 - Clear the filter form correctly

Compare with previous version

added 5 commits <ul><li>1c87afd0 - Create a filter for some basic personal note attributes</li><li>5559ac94 - Annotate subject and date in the personal note queryset</li><li>26a4d506 - Filter date and subject of personal notes</li><li>c542ac80 - Put filter form in a model and display the number of applied filters</li><li>de1ea314 - Clear the filter form correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8351&start_sha=692a0692cdf354f3e009d1d39f1ee50a354196b5)
ZugBahnHof commented 2021-05-16 00:19:02 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 80868b77 - Check for permissions
  • a94bc45f - Move register absence and filter buttons

Compare with previous version

added 2 commits <ul><li>80868b77 - Check for permissions</li><li>a94bc45f - Move register absence and filter buttons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8354&start_sha=de1ea314092dca3cdcd8c59af43158ce2b806205)
ZugBahnHof commented 2021-05-16 12:39:03 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>77522dc5 - Improve mobile UI</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8396&start_sha=a94bc45f1567fe102d6a88806abd37793ca74e6c)
ZugBahnHof commented 2021-05-16 13:04:35 +02:00 (Migrated from edugit.org)
Copy link

added 30 commits

  • 77522dc5...98a35501 - 29 commits from branch master
  • cb21daa1 - Merge branch 'master' into...

Compare with previous version

added 30 commits <ul><li>77522dc5...98a35501 - 29 commits from branch <code>master</code></li><li>cb21daa1 - Merge branch &#39;master&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8408&start_sha=77522dc5f1a40a464af969fffb613347bf7796cc)
ZugBahnHof commented 2021-05-16 13:25:03 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>b55e6d6e - Run reformat</li><li>889d8ea0 - Remove debug print</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8415&start_sha=cb21daa179e5e881c9eec1bf564c9fdf202b00af)
ZugBahnHof commented 2021-05-16 13:58:04 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 889d8ea0...b1dfae9e - 3 commits from branch master
  • 05fef509 - Merge branch 'master' into...
  • d514aa13 - Reformat and shorten docstring
  • 500c98d6 - Optimize imports

Compare with previous version

added 6 commits <ul><li>889d8ea0...b1dfae9e - 3 commits from branch <code>master</code></li><li>05fef509 - Merge branch &#39;master&#39; into...</li><li>d514aa13 - Reformat and shorten docstring</li><li>500c98d6 - Optimize imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8428&start_sha=889d8ea04b0e021cd9207725a00448f6d0864b54)
ZugBahnHof commented 2021-05-16 14:11:46 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ZugBahnHof commented 2021-05-16 14:12:04 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
ZugBahnHof commented 2021-05-16 14:14:36 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
ZugBahnHof commented 2021-05-16 14:51:09 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>135b72f8 - Fix sorting of tables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8450&start_sha=500c98d67a9614f1275676173e5dc896705f57e8)
ZugBahnHof commented 2021-05-16 14:54:20 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ZugBahnHof commented 2021-05-16 14:54:32 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
ZugBahnHof commented 2021-05-16 14:54:59 +02:00 (Migrated from edugit.org)
Copy link

Screenshot_2021-05-16_at_14-13-49_Class_register_person___AlekSIS

Screenshot_2021-05-16_at_14-13-41_Class_register_person___AlekSIS

Screenshot_2021-05-16_at_14-13-30_Class_register_person___AlekSIS

Screenshot_2021-05-16_at_14-13-14_Class_register_person___AlekSIS

![Screenshot_2021-05-16_at_14-13-49_Class_register_person___AlekSIS](/uploads/4d0447dae6a90010adb2dce8dbc0875e/Screenshot_2021-05-16_at_14-13-49_Class_register_person___AlekSIS.png) ![Screenshot_2021-05-16_at_14-13-41_Class_register_person___AlekSIS](/uploads/179d00498c7c65d9b38381f665843436/Screenshot_2021-05-16_at_14-13-41_Class_register_person___AlekSIS.png) ![Screenshot_2021-05-16_at_14-13-30_Class_register_person___AlekSIS](/uploads/9dfde0c3c9448d9eb8322002b7e3a800/Screenshot_2021-05-16_at_14-13-30_Class_register_person___AlekSIS.png) ![Screenshot_2021-05-16_at_14-13-14_Class_register_person___AlekSIS](/uploads/b17a16bda2b1c54fa3c67c635179d2d8/Screenshot_2021-05-16_at_14-13-14_Class_register_person___AlekSIS.png)
ZugBahnHof commented 2021-05-16 14:55:33 +02:00 (Migrated from edugit.org)
Copy link

@hansegucker

@hansegucker
hansegucker commented 2021-05-16 15:07:33 +02:00 (Migrated from edugit.org)
Copy link

Unrelated change.

Unrelated change.
hansegucker commented 2021-05-16 15:07:33 +02:00 (Migrated from edugit.org)
Copy link

Please reformat.

Please reformat.
hansegucker commented 2021-05-16 15:07:34 +02:00 (Migrated from edugit.org)
Copy link

Please don't put HTML in translation tags.

Please don't put HTML in translation tags.
hansegucker commented 2021-05-16 15:07:34 +02:00 (Migrated from edugit.org)
Copy link
            <i class="material-icons left">filter_alt</i> {% trans "Filter" %}
```suggestion:-0+0 <i class="material-icons left">filter_alt</i> {% trans "Filter" %} ```
hansegucker commented 2021-05-16 15:07:35 +02:00 (Migrated from edugit.org)
Copy link

Please fix indention.

Please fix indention.
hansegucker commented 2021-05-16 15:07:35 +02:00 (Migrated from edugit.org)
Copy link

Please check if this is still used.

Please check if this is still used.
hansegucker commented 2021-05-16 15:07:36 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2021-05-16 15:07:36 +02:00 (Migrated from edugit.org)
Copy link
        if record.absent and value:
```suggestion:-1+0 if record.absent and value: ```
hansegucker commented 2021-05-16 15:07:36 +02:00 (Migrated from edugit.org)
Copy link

This line is superfluous.

This line is superfluous.
hansegucker commented 2021-05-16 15:07:37 +02:00 (Migrated from edugit.org)
Copy link
    )

    personal_note_filter_object = PersonalNoteFilter(request.GET, queryset=personal_notes)
    filtered_personal_notes = personal_note_filter_object.qs
    context["personal_note_filter_form"] = personal_note_filter_object.form

    used_filters = list(personal_note_filter_object.data.values())
    context["num_filters"] = (
        len(used_filters) - used_filters.count("") - used_filters.count("unknown")
    )
```suggestion:-7+0 ) personal_note_filter_object = PersonalNoteFilter(request.GET, queryset=personal_notes) filtered_personal_notes = personal_note_filter_object.qs context["personal_note_filter_form"] = personal_note_filter_object.form used_filters = list(personal_note_filter_object.data.values()) context["num_filters"] = ( len(used_filters) - used_filters.count("") - used_filters.count("unknown") ) ```
hansegucker commented 2021-05-16 15:07:37 +02:00 (Migrated from edugit.org)
Copy link

Please check or remove line.

Please check or remove line.
hansegucker commented 2021-05-16 15:07:37 +02:00 (Migrated from edugit.org)
Copy link
    context["action_form"] = form

    table = PersonalNoteTable(filtered_personal_notes)
```suggestion:-1+0 context["action_form"] = form table = PersonalNoteTable(filtered_personal_notes) ```
ZugBahnHof commented 2021-05-16 15:20:43 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#776e8d15b2e07ac2a12333b266616359a116291c_23_23)
ZugBahnHof commented 2021-05-16 15:20:43 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#46d54586594d96fc0cafea12a75d2e529b699637_22_21)
ZugBahnHof commented 2021-05-16 15:20:43 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#46d54586594d96fc0cafea12a75d2e529b699637_77_79)
ZugBahnHof commented 2021-05-16 15:20:43 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#46d54586594d96fc0cafea12a75d2e529b699637_167_169)
ZugBahnHof commented 2021-05-16 15:20:44 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#2d74ef59e3033f9c03fa0931e2cdd333e3b51932_5_0)
ZugBahnHof commented 2021-05-16 15:20:44 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#520399a9947a55581328ec82db32231913e11c2a_137_136)
ZugBahnHof commented 2021-05-16 15:20:44 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8455&start_sha=135b72f882591f517ae3a4553175837ca60cc61c#520399a9947a55581328ec82db32231913e11c2a_169_168)
ZugBahnHof commented 2021-05-16 15:21:23 +02:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 6209f62b - Remove unrelated change in migrations
  • 4e26f1ac - Format CSS with spaces instead of tabs
  • b38b9204 - Reformat person.html
  • 19d70e8b - Remove unused html snippet
  • 02064911 - Remove unused html snippet (personal_note_link.html)
  • f2077810 - Simplify if-condition in tables.py
  • 58f84a04 - Remove superfluous table template declaration
  • ef427a95 - Beautify views.py

Compare with previous version

added 8 commits <ul><li>6209f62b - Remove unrelated change in migrations</li><li>4e26f1ac - Format CSS with spaces instead of tabs</li><li>b38b9204 - Reformat person.html</li><li>19d70e8b - Remove unused html snippet</li><li>02064911 - Remove unused html snippet (personal_note_link.html)</li><li>f2077810 - Simplify if-condition in tables.py</li><li>58f84a04 - Remove superfluous table template declaration</li><li>ef427a95 - Beautify views.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8456&start_sha=135b72f882591f517ae3a4553175837ca60cc61c)
ZugBahnHof commented 2021-05-16 16:18:27 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>b2ec85fb - Check for permissions</li><li>c3cea378 - Fix excuse type assigning bug</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8477&start_sha=ef427a9574077b33d9f3ecc5edb75b1b0066bbcb)
ZugBahnHof commented 2021-05-16 16:18:49 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-05-16 16:25:04 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
ZugBahnHof commented 2021-05-16 16:45:23 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
ZugBahnHof commented 2021-05-16 17:08:00 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 93c4fb1d - Reorder personal note actions

Compare with previous version

added 1 commit <ul><li>93c4fb1d - Reorder personal note actions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/111/diffs?diff_id=8512&start_sha=c3cea378f8a63f62430612cafd8b51fcb3fce759)
nik commented 2021-05-16 17:11:06 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
hansegucker (Migrated from edugit.org) scheduled this pull request to auto merge when all checks succeed 2021-05-16 17:11:22 +02:00
hansegucker (Migrated from edugit.org) merged commit 35c5bfc79f into master 2021-05-16 17:20:45 +02:00
hansegucker commented 2021-05-16 17:20:48 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 35c5bfc79f

mentioned in commit 35c5bfc79fb3b7ef9aac32790dff626c85a4808a
hansegucker (Migrated from edugit.org) approved these changes 2026-07-19 21:42:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!501
No description provided.