Resolve "Carry over the data of the first lesson for double (or triple, ...) lessons" #469
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aleksis/AlekSIS-App-Alsijil!469
Loading…
Reference in a new issue
No description provided.
Delete branch "64-make-it-possible-to-take-over-the-data-of-the-first-lesson-for-double-lessons"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #64
changed milestone to %2
added 1 commit
10c43d74- Automatically take over data from first lesson to second lesson in double lessonsCompare with previous version
unmarked as a Work In Progress
assigned to @nik
This
try/exceptblock is too big.trymust only guard a minimal amount of code, exactly that code that is expected to raise a specific exception.Please change the term
lessontoperiod(and check if other terms match the terminology we use globally).What about triple periods? Are you relying on causing a chain reaction when saving
second_lesson?This does not seem to take over data, but rather
carry overto the next lesseon (taking is an action done by the receiver, not the sender). Please rename (and verify the terminology in other places).If possible, do not use exceptions for regular code flow. You should use
filterand check forNoneinstead (which you get for free if you decide to check for more than only one following period above).This check should be made in
savebefore branching into this method (someone might want to intentionally call it without caring about the setting, and it is generally a good rule to not branch into methods unnecessarily because, you know, in the 80s, branching was very expensive ;)).changed this line in version 2 of the diff
changed this line in version 2 of the diff
changed this line in version 2 of the diff
added 1 commit
5914e36b- Fix terminologyCompare with previous version
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
added 2 commits
ea2cc407- Move settings check for carry_data_over to save method4b1e0a9c- Support triple, quadruple, ... periods in carry_over_data, tooCompare with previous version
resolved all threads
Please check again, @nik.
changed title from Resolve "{-Take over the data of the first lesson for double-} lessons" to Resolve "{+Carry over the data of the first lesson for double (or triple, ...)+} lessons"
added 5 commits
masteree18faf2- Merge branch 'master' into...Compare with previous version
Please use the terminology of
periodandlessoncorrectly.changed this line in version 5 of the diff
added 1 commit
03b8056b- Fix usage of terminologyCompare with previous version
resolved all threads
changed this line in version 6 of the diff
resolved all threads
added 1 commit
ab9818de- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
mentioned in commit
f29159e172merged