aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Resolve "Carry over the data of the first lesson for double (or triple, ...) lessons" #469

Merged
hansegucker merged 7 commits from 64-make-it-possible-to-take-over-the-data-of-the-first-lesson-for-double-lessons into master 2020-08-12 17:16:14 +02:00
Conversation 32 Commits 7 Files changed 2 +58
hansegucker commented 2020-08-11 17:35:20 +02:00 (Migrated from edugit.org)
Copy link

Closes #64

Closes #64
hansegucker commented 2020-08-11 17:35:21 +02:00 (Migrated from edugit.org)
Copy link

changed milestone to %2

changed milestone to %2
hansegucker commented 2020-08-11 18:07:03 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 10c43d74 - Automatically take over data from first lesson to second lesson in double lessons

Compare with previous version

added 1 commit <ul><li>10c43d74 - Automatically take over data from first lesson to second lesson in double lessons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3054&start_sha=c692554f5621b36e4b8b3e20825e024cd81849a0)
hansegucker commented 2020-08-11 18:07:17 +02:00 (Migrated from edugit.org)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
hansegucker commented 2020-08-11 18:07:17 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik

assigned to @nik
nik commented 2020-08-12 13:32:04 +02:00 (Migrated from edugit.org)
Copy link

This try/except block is too big. try must only guard a minimal amount of code, exactly that code that is expected to raise a specific exception.

This `try`/`except` block is too big. `try` must only guard a minimal amount of code, exactly that code that is expected to raise a specific exception.
nik commented 2020-08-12 13:32:04 +02:00 (Migrated from edugit.org)
Copy link

Please change the term lesson to period (and check if other terms match the terminology we use globally).

Please change the term `lesson` to `period` (and check if other terms match the terminology we use globally).
nik commented 2020-08-12 13:32:04 +02:00 (Migrated from edugit.org)
Copy link

What about triple periods? Are you relying on causing a chain reaction when saving second_lesson?

What about triple periods? Are you relying on causing a chain reaction when saving `second_lesson`?
nik commented 2020-08-12 13:32:05 +02:00 (Migrated from edugit.org)
Copy link

This does not seem to take over data, but rather carry over to the next lesseon (taking is an action done by the receiver, not the sender). Please rename (and verify the terminology in other places).

This does not seem to *take over* data, but rather `carry over` to the next lesseon (taking is an action done by the receiver, not the sender). Please rename (and verify the terminology in other places).
nik commented 2020-08-12 13:32:05 +02:00 (Migrated from edugit.org)
Copy link

If possible, do not use exceptions for regular code flow. You should use filter and check for None instead (which you get for free if you decide to check for more than only one following period above).

If possible, do not use exceptions for regular code flow. You should use `filter` and check for `None` instead (which you get for free if you decide to check for more than only one following period above).
nik commented 2020-08-12 13:32:05 +02:00 (Migrated from edugit.org)
Copy link

This check should be made in save before branching into this method (someone might want to intentionally call it without caring about the setting, and it is generally a good rule to not branch into methods unnecessarily because, you know, in the 80s, branching was very expensive ;)).

This check should be made in `save` before branching into this method (someone might want to intentionally call it without caring about the setting, and it is generally a good rule to not branch into methods unnecessarily because, you know, in the 80s, branching was very expensive ;)).
hansegucker commented 2020-08-12 16:49:46 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3064&start_sha=10c43d74e243436d63f7db4dd0973d6322be9940#780f294f550e4cd96aa99e7069b309c8b842f1d2_110_109)
hansegucker commented 2020-08-12 16:49:47 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3064&start_sha=10c43d74e243436d63f7db4dd0973d6322be9940#780f294f550e4cd96aa99e7069b309c8b842f1d2_109_109)
hansegucker commented 2020-08-12 16:49:47 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3064&start_sha=10c43d74e243436d63f7db4dd0973d6322be9940#780f294f550e4cd96aa99e7069b309c8b842f1d2_114_114)
hansegucker commented 2020-08-12 16:49:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>5914e36b - Fix terminology</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3064&start_sha=10c43d74e243436d63f7db4dd0973d6322be9940)
hansegucker commented 2020-08-12 16:55:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3065&start_sha=5914e36b1534ad1d8d14662ef74dfcc84f5d685a#780f294f550e4cd96aa99e7069b309c8b842f1d2_117_114)
hansegucker commented 2020-08-12 16:55:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3065&start_sha=5914e36b1534ad1d8d14662ef74dfcc84f5d685a#780f294f550e4cd96aa99e7069b309c8b842f1d2_121_114)
hansegucker commented 2020-08-12 16:55:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3065&start_sha=5914e36b1534ad1d8d14662ef74dfcc84f5d685a#780f294f550e4cd96aa99e7069b309c8b842f1d2_146_140)
hansegucker commented 2020-08-12 16:55:53 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • ea2cc407 - Move settings check for carry_data_over to save method
  • 4b1e0a9c - Support triple, quadruple, ... periods in carry_over_data, too

Compare with previous version

added 2 commits <ul><li>ea2cc407 - Move settings check for carry_data_over to save method</li><li>4b1e0a9c - Support triple, quadruple, ... periods in carry_over_data, too</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3065&start_sha=5914e36b1534ad1d8d14662ef74dfcc84f5d685a)
hansegucker commented 2020-08-12 16:56:08 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-08-12 16:56:27 +02:00 (Migrated from edugit.org)
Copy link

Please check again, @nik.

Please check again, @nik.
hansegucker commented 2020-08-12 16:56:47 +02:00 (Migrated from edugit.org)
Copy link

changed title from Resolve "{-Take over the data of the first lesson for double-} lessons" to Resolve "{+Carry over the data of the first lesson for double (or triple, ...)+} lessons"

changed title from **Resolve "{-Take over the data of the first lesson for double-} lessons"** to **Resolve "{+Carry over the data of the first lesson for double (or triple, ...)+} lessons"**
hansegucker commented 2020-08-12 17:01:27 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 4b1e0a9c...e08075f9 - 4 commits from branch master
  • ee18faf2 - Merge branch 'master' into...

Compare with previous version

added 5 commits <ul><li>4b1e0a9c...e08075f9 - 4 commits from branch <code>master</code></li><li>ee18faf2 - Merge branch &#39;master&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3067&start_sha=4b1e0a9cfe6fbde4e2d2c6b7c05980babaa6a76d)
nik commented 2020-08-12 17:08:07 +02:00 (Migrated from edugit.org)
Copy link

Please use the terminology of period and lesson correctly.

Please use the terminology of `period` and `lesson` correctly.
hansegucker commented 2020-08-12 17:10:06 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3068&start_sha=ee18faf29a83067d89cfde4f65575ea06136fbc7#780f294f550e4cd96aa99e7069b309c8b842f1d2_110_110)
hansegucker commented 2020-08-12 17:10:06 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>03b8056b - Fix usage of terminology</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3068&start_sha=ee18faf29a83067d89cfde4f65575ea06136fbc7)
hansegucker commented 2020-08-12 17:10:14 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
nik commented 2020-08-12 17:15:05 +02:00 (Migrated from edugit.org)
Copy link
        """Carry over data to directly adjacent periods in this lesson if data is not already set.
```suggestion:-0+0 """Carry over data to directly adjacent periods in this lesson if data is not already set. ```
nik commented 2020-08-12 17:15:09 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3069&start_sha=03b8056bb15951e0f98481ca002783082d7c6d5d#780f294f550e4cd96aa99e7069b309c8b842f1d2_110_110)
nik commented 2020-08-12 17:15:09 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
nik commented 2020-08-12 17:15:10 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ab9818de - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>ab9818de - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/79/diffs?diff_id=3069&start_sha=03b8056bb15951e0f98481ca002783082d7c6d5d)
nik commented 2020-08-12 17:16:14 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit f29159e172

mentioned in commit f29159e172dee3a299abeb0a159d2494a3026ad8
nik commented 2020-08-12 17:16:14 +02:00 (Migrated from edugit.org)
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!469
No description provided.