aleksis/AlekSIS-App-Alsijil
Watch
10
0
Fork
You've already forked AlekSIS-App-Alsijil
 0
Code Issues 48 Pull requests 7 Projects Releases 3 Packages 1 Activity Actions

Resolve "Add week select to week view" #463

Merged
hansegucker merged 10 commits from 65-add-week-select-to-week-view into master 2020-08-05 16:31:10 +02:00
Conversation 31 Commits 10 Files changed 3 +36 -15
leuckeju commented 2020-07-24 13:24:15 +02:00
Member
Copy link

Closes #65

Closes #65
leuckeju commented 2020-07-24 13:24:15 +02:00
Author
Member
Copy link

changed milestone to %2

changed milestone to %2
leuckeju commented 2020-07-24 13:52:55 +02:00
Author
Member
Copy link

added 3 commits

  • c15e6c4c - Include week_select into week_view.html
  • 731f3091 - Change URL of week_view to match the week_select url requirements
  • 6358e708 - Add missing context in the week_view view

Compare with previous version

added 3 commits <ul><li>c15e6c4c - Include week_select into week_view.html</li><li>731f3091 - Change URL of week_view to match the week_select url requirements</li><li>6358e708 - Add missing context in the week_view view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2880&start_sha=579f7532e332321d5d306ee7052d62af077793eb)
leuckeju commented 2020-07-24 16:01:46 +02:00
Author
Member
Copy link

mentioned in issue AlekSIS-App-Chronos#90

mentioned in issue AlekSIS-App-Chronos#90
leuckeju commented 2020-07-24 16:02:20 +02:00
Author
Member
Copy link

mentioned in merge request AlekSIS-App-Chronos!462

mentioned in merge request AlekSIS-App-Chronos!462
leuckeju commented 2020-07-24 16:03:46 +02:00
Author
Member
Copy link

Blocked by https://edugit.org/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/72

Blocked by https://edugit.org/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/72
leuckeju commented 2020-07-24 17:10:52 +02:00
Author
Member
Copy link

added 2 commits

  • 2388fedb - Update view context argument to use format strings
  • 93504aea - Beautify url

Compare with previous version

added 2 commits <ul><li>2388fedb - Update view context argument to use format strings</li><li>93504aea - Beautify url</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2884&start_sha=6358e708b4d34e1911d222159e324cc2c43e6aa5)
leuckeju commented 2020-07-24 17:26:29 +02:00
Author
Member
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
leuckeju commented 2020-07-24 17:26:29 +02:00
Author
Member
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2020-07-26 15:55:00 +02:00
Owner
Copy link

Please add a screenshot showing the week select in the context of the page. Thanks!

Please add a screenshot showing the week select in the context of the page. Thanks!
hansegucker commented 2020-07-26 15:55:47 +02:00
Owner
Copy link

What does this line?

What does this line?
hansegucker commented 2020-07-26 15:58:51 +02:00
Owner
Copy link

Please document this helper function and move it to the util namespace.

Please document this helper function and move it to the util namespace.
hansegucker commented 2020-07-26 15:58:51 +02:00
Owner
Copy link

Please remove this debug print.

Please remove this debug print.
leuckeju commented 2020-07-26 16:23:31 +02:00
Author
Member
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2899&start_sha=93504aeacc71ab7d331de41ff8655c8e98d36bd4#5462fbda1c5072ebd898ac7347ff9122c9e8e9ac_16_16)
leuckeju commented 2020-07-26 16:23:32 +02:00
Author
Member
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2899&start_sha=93504aeacc71ab7d331de41ff8655c8e98d36bd4#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_302_302)
leuckeju commented 2020-07-26 16:23:32 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3593daf5 - Remove debug prints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2899&start_sha=93504aeacc71ab7d331de41ff8655c8e98d36bd4)
leuckeju commented 2020-07-26 16:24:27 +02:00
Author
Member
Copy link

Debug print

Debug print
leuckeju commented 2020-07-26 16:24:37 +02:00
Author
Member
Copy link

done

done
hansegucker commented 2020-08-05 12:20:48 +02:00
Owner
Copy link

added 48 commits

  • 3593daf5...49392296 - 46 commits from branch master
  • 05dc8cd7 - Merge branch 'master' into 65-add-week-select-to-week-view
  • 7ec9ca07 - Clean up imports and reformat

Compare with previous version

added 48 commits <ul><li>3593daf5...49392296 - 46 commits from branch <code>master</code></li><li>05dc8cd7 - Merge branch &#39;master&#39; into 65-add-week-select-to-week-view</li><li>7ec9ca07 - Clean up imports and reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2978&start_sha=3593daf5f2aa66ad416f8cf1e992278a3f08ee19)
hansegucker commented 2020-08-05 12:26:09 +02:00
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2979&start_sha=7ec9ca074fa54a61c353fdd962c065f68f0c020b#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_297_298)
hansegucker commented 2020-08-05 12:26:10 +02:00
Owner
Copy link

added 1 commit

  • 003f17ef - Move append_if_all to util and add typing/docstring

Compare with previous version

added 1 commit <ul><li>003f17ef - Move append_if_all to util and add typing/docstring</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2979&start_sha=7ec9ca074fa54a61c353fdd962c065f68f0c020b)
hansegucker commented 2020-08-05 12:26:17 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-08-05 13:05:54 +02:00
Owner
Copy link

added 1 commit

  • 5b502d0d - Simplify URL template generation for week select and make it more resilient

Compare with previous version

added 1 commit <ul><li>5b502d0d - Simplify URL template generation for week select and make it more resilient</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2980&start_sha=003f17ef23f5ed9fb87ef3ad14aaeeaa9173a703)
hansegucker commented 2020-08-05 13:06:03 +02:00
Owner
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
nik commented 2020-08-05 14:45:14 +02:00
Owner
Copy link

Please namespace staticfiles.

Please namespace staticfiles.
nik commented 2020-08-05 14:45:53 +02:00
Owner
Copy link

Still missing a screenshot.

Still missing a screenshot.
hansegucker commented 2020-08-05 14:45:58 +02:00
Owner
Copy link

If you want to solve this, please create an issue in core, because this file is from core.

If you want to solve this, please create an issue in core, because this file is from core.
hansegucker commented 2020-08-05 14:46:46 +02:00
Owner
Copy link

image

![image](/uploads/335737e091425a9d7702c573a74c8e44/image.png)
hansegucker commented 2020-08-05 14:47:04 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-08-05 16:19:51 +02:00
Owner
Copy link

added 1 commit

  • 82f5c040 - Simplify URL template generation for week select and make it more resilient

Compare with previous version

added 1 commit <ul><li>82f5c040 - Simplify URL template generation for week select and make it more resilient</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/73/diffs?diff_id=2983&start_sha=5b502d0deb8052f6d4af4ae4406d26ff3dd8d91f)
nik commented 2020-08-05 16:31:10 +02:00
Owner
Copy link

merged

merged
nik commented 2020-08-05 16:31:10 +02:00
Owner
Copy link

mentioned in commit b4e21b8d83

mentioned in commit b4e21b8d8359c2527a3fcbe0da2b4a9da225f66a
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil!463
No description provided.