aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Resolve "Add rules and permissions" #439

Merged
hansegucker merged 106 commits from 73-add-rules-and-permissions into master 2020-10-24 23:39:01 +02:00
Conversation 192 Commits 106 Files changed 16 +1148 -306
hansegucker commented 2020-06-15 12:14:39 +02:00 (Migrated from edugit.org)
Copy link

Closes #73

Closes #79

Closes #73 Closes #79
hansegucker commented 2020-06-16 21:43:50 +02:00 (Migrated from edugit.org)
Copy link

@yuha Please give feedback when your task will be finished.

@yuha Please give feedback when your task will be finished.
yuha commented 2020-06-17 19:51:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e65b4cb2 - Add some more rules&permissions

Compare with previous version

added 1 commit <ul><li>e65b4cb2 - Add some more rules&amp;permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2581&start_sha=6e33863546708df8c756396cfbd00bdbf3fb6ea4)
hansegucker commented 2020-06-17 21:14:19 +02:00 (Migrated from edugit.org)
Copy link

Please use gettext (without an u)

Please use `gettext` (without an u)
hansegucker commented 2020-06-17 21:15:25 +02:00 (Migrated from edugit.org)
Copy link

Please add a docstring.

Please add a docstring.
hansegucker commented 2020-06-17 21:15:29 +02:00 (Migrated from edugit.org)
Copy link

Please add a docstring.

Please add a docstring.
hansegucker commented 2020-06-17 21:18:01 +02:00 (Migrated from edugit.org)
Copy link

I think the persons someone can select to register an absence should be filtered according to one's permissions. @yuha

I think the persons someone can select to register an absence should be filtered according to one's permissions. @yuha
hansegucker commented 2020-06-17 21:20:30 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2020-06-17 21:21:16 +02:00 (Migrated from edugit.org)
Copy link

@nik Please review as soon as it's possible for you – that would be very nice. (Despite it's still WIP.)

@nik Please review as soon as it's possible for you – that would be very nice. (Despite it's still WIP.)
nik commented 2020-06-17 21:35:04 +02:00 (Migrated from edugit.org)
Copy link

How is this related to permissions and rules?

How is this related to permissions and rules?
hansegucker commented 2020-06-17 21:36:02 +02:00 (Migrated from edugit.org)
Copy link

It keeps the option open to filter the persons related to someone's permissions in the view.

It keeps the option open to filter the persons related to someone's permissions in the view.
nik commented 2020-06-17 21:36:06 +02:00 (Migrated from edugit.org)
Copy link

"an absence"

"an absence"
nik commented 2020-06-17 21:36:12 +02:00 (Migrated from edugit.org)
Copy link

"an absence"

"an absence"
nik commented 2020-06-17 21:40:49 +02:00 (Migrated from edugit.org)
Copy link

Looks good on first glance.

However, I tend to not merge this without at least basic black/white test cases for the most important permissions.

Looks good on first glance. However, I tend to not merge this without at least basic black/white test cases for the most important permissions.
hansegucker commented 2020-06-17 22:43:13 +02:00 (Migrated from edugit.org)
Copy link

added 34 commits

  • e65b4cb2...a8b1b29c - 33 commits from branch master
  • a85bcae6 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 34 commits <ul><li>e65b4cb2...a8b1b29c - 33 commits from branch <code>master</code></li><li>a85bcae6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2583&start_sha=e65b4cb2610df19d648d796ef886f19ca2b104f6)
hansegucker commented 2020-06-17 22:47:17 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c0e47390 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 1 commit <ul><li>c0e47390 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2584&start_sha=a85bcae6ce7d50bd05a0890bf51e868e88ff2964)
hansegucker commented 2020-06-17 22:50:59 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • a85bcae6 - Merge branch 'master' into 73-add-rules-and-permissions
  • 451cdb33 - Merge branch '73-add-rules-and-permissions' of...

Compare with previous version

added 2 commits <ul><li>a85bcae6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>451cdb33 - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2585&start_sha=c0e47390634ebb2c05811cf349486df126f71ea2)
hansegucker commented 2020-06-17 22:52:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2a84050c - Fix order of has_perm and perm check in lesson template

Compare with previous version

added 1 commit <ul><li>2a84050c - Fix order of has_perm and perm check in lesson template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2586&start_sha=451cdb33a7987522913055d98256e71388b19946)
yuha commented 2020-06-17 22:56:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 45de9a0c - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 1 commit <ul><li>45de9a0c - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2588&start_sha=2a84050c0136dc836355bacc96ba87b0f4564d10)
yuha commented 2020-06-17 22:59:45 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2589&start_sha=45de9a0c1d876205842f45b130b1afa163fbc23b#70ecb348d7a796878a62bf6188416dcc55b207e6_4_4)
yuha commented 2020-06-17 22:59:46 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 420f07a0 - Add rules&permissions in class register template
  • a95d775a - Replace ugettext with gettext

Compare with previous version

added 2 commits <ul><li>420f07a0 - Add rules&amp;permissions in class register template</li><li>a95d775a - Replace ugettext with gettext</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2589&start_sha=45de9a0c1d876205842f45b130b1afa163fbc23b)
yuha commented 2020-06-17 23:03:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2011793a - Add tooltips in alsijil_helpers.py

Compare with previous version

added 1 commit <ul><li>2011793a - Add tooltips in alsijil_helpers.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2590&start_sha=a95d775a228300d9544b6f72f5d00e013b2cef38)
yuha commented 2020-06-17 23:05:31 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2591&start_sha=2011793a5b3c0e130e97e349b5b474b7466d29e4#70ecb348d7a796878a62bf6188416dcc55b207e6_106_106)
yuha commented 2020-06-17 23:05:31 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2591&start_sha=2011793a5b3c0e130e97e349b5b474b7466d29e4#70ecb348d7a796878a62bf6188416dcc55b207e6_107_106)
yuha commented 2020-06-17 23:05:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>53bfe409 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2591&start_sha=2011793a5b3c0e130e97e349b5b474b7466d29e4)
yuha commented 2020-06-17 23:06:08 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-06-18 09:50:01 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • a85bcae6 - Merge branch 'master' into 73-add-rules-and-permissions
  • c0e47390 - Merge branch 'master' into 73-add-rules-and-permissions
  • 451cdb33 - Merge branch '73-add-rules-and-permissions' of...
  • 2a84050c - Fix order of has_perm and perm check in lesson template
  • 287cac5e - Merge branch '73-add-rules-and-permissions' of...

Compare with previous version

added 5 commits <ul><li>a85bcae6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>c0e47390 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>451cdb33 - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li><li>2a84050c - Fix order of has_perm and perm check in lesson template</li><li>287cac5e - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2592&start_sha=53bfe409c463319a7c14d98fb042bae8e70e949b)
hansegucker commented 2020-06-18 09:51:09 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • c940fbce - 1 commit from branch master
  • 442e28eb - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 2 commits <ul><li>c940fbce - 1 commit from branch <code>master</code></li><li>442e28eb - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2593&start_sha=287cac5eb698a8a838c581503e08bbd7c3ff5588)
hansegucker commented 2020-06-18 16:38:28 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c8791096 - Fix order of queries in week view

Compare with previous version

added 1 commit <ul><li>c8791096 - Fix order of queries in week view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2597&start_sha=442e28eb5b5b67705c23a1b5488c3694652cfde1)
hansegucker commented 2020-06-18 22:05:40 +02:00 (Migrated from edugit.org)
Copy link

added 9 commits

  • c8791096...43e6be1f - 7 commits from branch master
  • 95f16ef8 - Merge branch 'master' into 73-add-rules-and-permissions
  • 6b0eedfd - Fix lint issues and reformat files

Compare with previous version

added 9 commits <ul><li>c8791096...43e6be1f - 7 commits from branch <code>master</code></li><li>95f16ef8 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>6b0eedfd - Fix lint issues and reformat files</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2599&start_sha=c8791096f950cc118dbeec65b2888cb1c114f3d3)
hansegucker commented 2020-06-18 22:09:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 93203b44 - Move annotate before union because annotating works only before union

Compare with previous version

added 1 commit <ul><li>93203b44 - Move annotate before union because annotating works only before union</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2600&start_sha=6b0eedfd760da15faf0ad5156816f301eccab5d2)
hansegucker commented 2020-06-19 11:10:12 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fbbb6020 - Fix permission names and core/alsijil relation

Compare with previous version

added 1 commit <ul><li>fbbb6020 - Fix permission names and core/alsijil relation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2602&start_sha=93203b4489ceb4cfdc034864b2a78ed6dec17112)
hansegucker commented 2020-06-20 18:22:43 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f3cc545c - Convert pks of lesson periods to list to simplify query

Compare with previous version

added 1 commit <ul><li>f3cc545c - Convert pks of lesson periods to list to simplify query</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2609&start_sha=fbbb60202f35dbc772dae33d32012c2b8d0f11e5)
yuha commented 2020-06-21 11:32:58 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b1978f7a - Fixed permission for absence register

Compare with previous version

added 1 commit <ul><li>b1978f7a - Fixed permission for absence register</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2614&start_sha=f3cc545ca40c20855c97069d5e2d08b1d1fa4215)
hansegucker commented 2020-06-27 11:55:20 +02:00 (Migrated from edugit.org)
Copy link

added 10 commits

  • b1978f7a...607ae327 - 8 commits from branch master
  • 4cf0c8e6 - Merge branch 'master' into 73-add-rules-and-permissions
  • b3df531e - Merge branch '73-add-rules-and-permissions' of...

Compare with previous version

added 10 commits <ul><li>b1978f7a...607ae327 - 8 commits from branch <code>master</code></li><li>4cf0c8e6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>b3df531e - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2652&start_sha=b1978f7a04b1aa651820d9d052ffa09444215428)
hansegucker commented 2020-06-27 12:01:15 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 52c06bb4 - Merge branch '73-add-rules-and-permissions' of...
  • 262cf49e - Merge branch '73-add-rules-and-permissions' of...

Compare with previous version

added 2 commits <ul><li>52c06bb4 - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li><li>262cf49e - Merge branch &#39;73-add-rules-and-permissions&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2653&start_sha=b3df531e3d976c8001714f0583ab965e23595b6e)
hansegucker commented 2020-06-27 12:15:00 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b7fa224e - Annotate week in get_lesson_by_period_pk

Compare with previous version

added 1 commit <ul><li>b7fa224e - Annotate week in get_lesson_by_period_pk</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2655&start_sha=262cf49e59687592e23997300e896e27b6d607d2)
hansegucker commented 2020-06-27 12:16:56 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 26b63e39 - Fix usage of RelatedQuerySet in predicate

Compare with previous version

added 1 commit <ul><li>26b63e39 - Fix usage of RelatedQuerySet in predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2656&start_sha=b7fa224ebee245bf922541817148381ee76410e3)
hansegucker commented 2020-07-02 12:34:39 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 26b63e39...303df022 - 2 commits from branch master
  • 07ca4f09 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 3 commits <ul><li>26b63e39...303df022 - 2 commits from branch <code>master</code></li><li>07ca4f09 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2743&start_sha=26b63e39dbed58bbfdb2df7fdadf409b27aa3640)
hansegucker commented 2020-07-10 12:39:02 +02:00 (Migrated from edugit.org)
Copy link

@yuha Can you please add such tests?

@yuha Can you please add such tests?
hansegucker commented 2020-07-12 13:02:12 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #81

mentioned in issue #81
yuha commented 2020-07-18 01:19:11 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

Compare with previous version

added 5 commits <ul><li>6e9a0f60 - Add menu validators using rules</li><li>d524ad07 - Rename personalnotefilter rules</li><li>5eb56aae - Refactor predicates</li><li>7365b60b - Fix is_person_group_owner predicate</li><li>0292d973 - Reformat predicates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2851&start_sha=07ca4f09d3717e8abb45197602d40381f746abf1)
yuha commented 2020-07-18 01:26:53 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 46e73bc3 - Remove unnecessary global permissions
  • 3d8f9797 - Remove unnecessary global permission from rules

Compare with previous version

added 2 commits <ul><li>46e73bc3 - Remove unnecessary global permissions</li><li>3d8f9797 - Remove unnecessary global permission from rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2853&start_sha=0292d973f897dd9f0f7c5f3151befcaa3c7dceec)
hansegucker commented 2020-07-18 15:45:30 +02:00 (Migrated from edugit.org)
Copy link

@yuha ?

@yuha ?
hansegucker commented 2020-07-18 15:46:14 +02:00 (Migrated from edugit.org)
Copy link

Why this should be unnecessary?

Why this should be unnecessary?
hansegucker commented 2020-07-18 17:21:41 +02:00 (Migrated from edugit.org)
Copy link

TODO for @yuha 😉

  • Add permissions for management of excuse types
  • Remove personal note permissions (if !458 is merged)
  • Add permissions for management of extra marks (if !458 is merged)
TODO for @yuha :wink: - [x] Add permissions for management of excuse types - [x] Remove personal note permissions (if !458 is merged) - [x] Add permissions for management of extra marks (if !458 is merged)
yuha commented 2020-07-19 01:36:17 +02:00 (Migrated from edugit.org)
Copy link

As far as I know it should be possible to simply assign an object-specific permission for all objects to a user, so there must not be an extra global permission for it.

As far as I know it should be possible to simply assign an object-specific permission for all objects to a user, so there must not be an extra global permission for it.
hansegucker commented 2020-07-22 19:43:36 +02:00 (Migrated from edugit.org)
Copy link

@yuha I don't know if I already had written or said it, but please also pay attention to substitutions (substitution teachers can access a lesson as well as regular teachers etc.)

@yuha I don't know if I already had written or said it, but please also pay attention to substitutions (substitution teachers can access a lesson as well as regular teachers etc.)
yuha commented 2020-07-22 22:56:20 +02:00 (Migrated from edugit.org)
Copy link

added 34 commits

  • 0292d973...579f7532 - 32 commits from branch master
  • 9cff3804 - Merge branch 'master' into 73-add-rules-and-permissions
  • 62c3ea5d - Add rules&permissions for excuse types

Compare with previous version

added 34 commits <ul><li>0292d973...579f7532 - 32 commits from branch <code>master</code></li><li>9cff3804 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>62c3ea5d - Add rules&amp;permissions for excuse types</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2868&start_sha=0292d973f897dd9f0f7c5f3151befcaa3c7dceec)
yuha commented 2020-07-22 23:00:36 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 63c96016 - Also check whether a person is a teacher in a LessonSubstitution in is_lesson_teacher

Compare with previous version

added 1 commit <ul><li>63c96016 - Also check whether a person is a teacher in a LessonSubstitution in is_lesson_teacher</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2869&start_sha=62c3ea5da2419ed165b25808a3c84a2d0484bc9e)
yuha commented 2020-07-22 23:01:14 +02:00 (Migrated from edugit.org)
Copy link

how do i do so?

how do i do so?
yuha commented 2020-07-24 14:09:32 +02:00 (Migrated from edugit.org)
Copy link

"Add permissions for management of excuse types" done

"Add permissions for management of excuse types" done
hansegucker commented 2020-07-31 16:54:57 +02:00 (Migrated from edugit.org)
Copy link

As !458 is merged, it would be great if you could do the tasks in the comment above.

As !458 is merged, it would be great if you could do the tasks in the comment above.
hansegucker commented 2020-08-03 20:19:52 +02:00 (Migrated from edugit.org)
Copy link

added 48 commits

  • 63c96016...0b8aa003 - 45 commits from branch master
  • 5143e011 - Merge branch 'master' into 73-add-rules-and-permissions
  • 7652c383 - Remove rests of personal note filters
  • 780fd921 - Reformat

Compare with previous version

added 48 commits <ul><li>63c96016...0b8aa003 - 45 commits from branch <code>master</code></li><li>5143e011 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>7652c383 - Remove rests of personal note filters</li><li>780fd921 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2959&start_sha=63c960166d9172be2d92477aefefaab0fb319f7f)
hansegucker commented 2020-08-03 20:36:18 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f1a5702d - Fix permissions in lesson.html after merge

Compare with previous version

added 1 commit <ul><li>f1a5702d - Fix permissions in lesson.html after merge</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2961&start_sha=780fd92120b58b4f007ee27defed16933827a516)
hansegucker commented 2020-08-03 20:36:29 +02:00 (Migrated from edugit.org)
Copy link

TODO:

  • Filter personal notes in overview of previous lessons (currently there are shown all personal notes of the previous lesson)
TODO: - [x] Filter personal notes in overview of previous lessons (currently there are shown all personal notes of the previous lesson)
hansegucker commented 2020-08-03 20:41:43 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 49392296 - 1 commit from branch master
  • 4daa50e1 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 2 commits <ul><li>49392296 - 1 commit from branch <code>master</code></li><li>4daa50e1 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2962&start_sha=f1a5702d8e776e04b17df2e5217bfcda537be252)
hansegucker commented 2020-08-03 20:53:29 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6da0a1a0 - Fix rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2963&start_sha=4daa50e1082c26e8b458229dc3efa1dcab3b73cb)
hansegucker commented 2020-08-04 19:12:50 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>87e90a54 - Fix wrong used pk</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2971&start_sha=6da0a1a03d15e2e73a81c8277dd4f75ddc13eebd)
hansegucker commented 2020-08-04 20:09:28 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 910e001c - Fix is_lesson_teacher: Wrong qs

Compare with previous version

added 1 commit <ul><li>910e001c - Fix is_lesson_teacher: Wrong qs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2972&start_sha=87e90a54870dd7b633ba34f0ebfb7fcdf03d7815)
yuha commented 2020-08-05 08:57:17 +02:00 (Migrated from edugit.org)
Copy link

Why did you change this? There are other use cases where a person should be able to view the register absence page - for example if this person has the permission to register absences for an entire group

Why did you change this? There are other use cases where a person should be able to view the register absence page - for example if this person has the permission to register absences for an entire group
hansegucker commented 2020-08-05 11:58:31 +02:00 (Migrated from edugit.org)
Copy link

Because this didn't work – the reason may be that I didn't checkout AlekSIS/official/AlekSIS!708. 😁

Because this didn't work – the reason may be that I didn't checkout AlekSIS/official/AlekSIS!708. :grin:
hansegucker commented 2020-08-05 16:35:27 +02:00 (Migrated from edugit.org)
Copy link

added 12 commits

  • 910e001c...b4e21b8d - 11 commits from branch master
  • e8144bc6 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 12 commits <ul><li>910e001c...b4e21b8d - 11 commits from branch <code>master</code></li><li>e8144bc6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=2984&start_sha=910e001c01b543443f8943f937a24b166af17661)
yuha commented 2020-08-06 20:31:31 +02:00 (Migrated from edugit.org)
Copy link

So can this be reverted?

So can this be reverted?
hansegucker commented 2020-08-06 20:50:09 +02:00 (Migrated from edugit.org)
Copy link

Yes, of course.

Yes, of course.
yuha commented 2020-08-06 21:43:38 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 37 of the diff

changed this line in [version 37 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3013&start_sha=e8144bc63150fe36f7bc220fb2fd5a9ae092d419#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_94_94)
yuha commented 2020-08-06 21:43:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4ce2f988 - Revert &quot;Fix rules&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3013&start_sha=e8144bc63150fe36f7bc220fb2fd5a9ae092d419)
yuha commented 2020-08-07 00:27:17 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 8f136405 - Add permissions for management of extra marks
  • 867088d7 - Fixed mixin sequency in class-based views

Compare with previous version

added 2 commits <ul><li>8f136405 - Add permissions for management of extra marks</li><li>867088d7 - Fixed mixin sequency in class-based views</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3014&start_sha=4ce2f988daae3e30864c73bb44f105f829e1d460)
yuha commented 2020-08-07 00:42:35 +02:00 (Migrated from edugit.org)
Copy link

You mean in the week overview? As far as I understand, they are actually filtered.Screenshot_from_2020-08-07_00-41-35

You mean in the week overview? As far as I understand, they are actually filtered.![Screenshot_from_2020-08-07_00-41-35](/uploads/b9fda7be3d94ebcf7b3ef34d0ea0dcca/Screenshot_from_2020-08-07_00-41-35.png)
yuha commented 2020-08-10 08:04:55 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9a6d823e - Fixed typo in extramark rule</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3025&start_sha=867088d7142fe8d041b74493071df091dbe53d16)
yuha commented 2020-08-10 08:56:56 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4964c534 - Allow filtering of personal notes displayed in overview of last lesson and...

Compare with previous version

added 1 commit <ul><li>4964c534 - Allow filtering of personal notes displayed in overview of last lesson and...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3026&start_sha=9a6d823e6ce82d303d1f1b0cb2641f7cca1106c6)
yuha commented 2020-08-10 10:56:32 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3daf91e8 - Change rule name</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3027&start_sha=4964c534683657a6f77b2309cf5d3b25ba3e65c3)
yuha commented 2020-08-10 10:59:56 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • fe5d0416 - add menu validator for extra marks
  • bd4c962a - Change edit personal note rule

Compare with previous version

added 2 commits <ul><li>fe5d0416 - add menu validator for extra marks</li><li>bd4c962a - Change edit personal note rule</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3028&start_sha=3daf91e8cb55b7d11a639409dc226cb5731a2ec4)
yuha commented 2020-08-14 15:36:46 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f2151ca2 - Remove usage of has_any_object and change to custom queries

Compare with previous version

added 1 commit <ul><li>f2151ca2 - Remove usage of has_any_object and change to custom queries</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3110&start_sha=bd4c962a9e4690235a6e11fb74f839d2add836ea)
hansegucker commented 2020-08-16 11:49:55 +02:00 (Migrated from edugit.org)
Copy link

added 20 commits

  • f2151ca2...19ac25fc - 19 commits from branch master
  • fc2f0f6c - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 20 commits <ul><li>f2151ca2...19ac25fc - 19 commits from branch <code>master</code></li><li>fc2f0f6c - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3132&start_sha=f2151ca24547d09a48645882f9648b77cffec7f0)
hansegucker commented 2020-08-16 12:35:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b422dae3 - Fix query</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3133&start_sha=fc2f0f6cd484d6af2728261b8ddc38039c4dab44)
hansegucker commented 2020-08-16 12:41:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 25dc771a - Use correct permission in views

Compare with previous version

added 1 commit <ul><li>25dc771a - Use correct permission in views</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3134&start_sha=b422dae3841272943ec6f500dc4b1b7f0bea6d1a)
hansegucker commented 2020-08-16 12:47:09 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 39496545 - Do not all queries in has_any_object_absence, only necessary ones

Compare with previous version

added 1 commit <ul><li>39496545 - Do not all queries in has_any_object_absence, only necessary ones</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3135&start_sha=25dc771ad6994c8098ab344909ac2f57aeffd4e6)
yuha commented 2020-08-16 19:03:03 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 46259cb0 - Fix is_lesson_teacher predicate

Compare with previous version

added 1 commit <ul><li>46259cb0 - Fix is_lesson_teacher predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3138&start_sha=394965458d535ce9ae87c922875fbdb81d5cc573)
yuha commented 2020-08-16 23:53:50 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 46259cb0 - Fix is_lesson_teacher predicate

Compare with previous version

added 1 commit <ul><li>46259cb0 - Fix is_lesson_teacher predicate</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3140&start_sha=394965458d535ce9ae87c922875fbdb81d5cc573)
hansegucker commented 2020-08-18 18:19:51 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 46259cb0...151dd117 - 2 commits from branch master
  • f6b135b2 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 3 commits <ul><li>46259cb0...151dd117 - 2 commits from branch <code>master</code></li><li>f6b135b2 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3149&start_sha=46259cb0902074c2ab6c1cbabad700ca542aada3)
hansegucker commented 2020-08-18 18:20:15 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f9ba7388 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3150&start_sha=f6b135b25072fbdcb7d7e3f345e485c1bb183a2d)
hansegucker commented 2020-08-18 18:30:24 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cbd4e140 - Add several small bug fixes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3151&start_sha=f9ba73883f1292f373eb481b0f74433ed9f27039)
yuha commented 2020-08-19 22:31:48 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 0d6400b4 - Filter possible selection in absence form
  • 16b2fb03 - Merge branch '73-add-rules-and-permissions' into...
  • 5b18cc4e - Filter person dropdown list of absence registration form with custom queryset...
  • 017602dd - Add filtered dropdowns for week overview
  • f3864ef9 - Merge branch '73-add-rules-and-permissions' into...
  • 0c1b499e - Merge branch '79-filter-selects-on-week-overview-and-register-absence' into...

Compare with previous version

added 6 commits <ul><li>0d6400b4 - Filter possible selection in absence form</li><li>16b2fb03 - Merge branch &#39;73-add-rules-and-permissions&#39; into...</li><li>5b18cc4e - Filter person dropdown list of absence registration form with custom queryset...</li><li>017602dd - Add filtered dropdowns for week overview</li><li>f3864ef9 - Merge branch &#39;73-add-rules-and-permissions&#39; into...</li><li>0c1b499e - Merge branch &#39;79-filter-selects-on-week-overview-and-register-absence&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3161&start_sha=cbd4e140b8e793bf30056c767952e77f42f5608a)
hansegucker commented 2020-08-20 15:52:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>66dd2f9c - Fix querysets in select form</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3162&start_sha=0c1b499e90a2529412bfabcc48d450171a2657d2)
hansegucker commented 2020-08-20 15:56:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e1aee095 - Fix querysets</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3163&start_sha=66dd2f9cc56ba6372e418b23d9a82aff15f49cd2)
hansegucker commented 2020-08-20 15:59:14 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ff67a50a - Fix queryset</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3164&start_sha=e1aee095b4df56a4d8f0d7fea257d0beb1eb0a9d)
hansegucker commented 2020-08-20 16:09:08 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fce909de - Fix form query method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3165&start_sha=ff67a50a16578dd89b73e26586f1ed99c6f40326)
hansegucker commented 2020-08-20 16:12:19 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0cab5ee3 - Fix request getter in SelectForm

Compare with previous version

added 1 commit <ul><li>0cab5ee3 - Fix request getter in SelectForm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3166&start_sha=fce909deba74d75ba2ffc1ef698f07240f293ed6)
hansegucker commented 2020-08-20 16:36:20 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • d2331821 - Simplify queryset in SelectForm
  • 0a2acd87 - Check permission of lesson documentations in week view

Compare with previous version

added 2 commits <ul><li>d2331821 - Simplify queryset in SelectForm</li><li>0a2acd87 - Check permission of lesson documentations in week view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3167&start_sha=0cab5ee303fe3e8585fe3485c96e512ceb828c35)
hansegucker commented 2020-08-20 16:38:13 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5a900697 - Add missing load for template tags

Compare with previous version

added 1 commit <ul><li>5a900697 - Add missing load for template tags</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3168&start_sha=0a2acd8751ff783c8550a24364c87f78088150de)
hansegucker commented 2020-08-20 16:50:52 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 378acd61 - Fix view_week_personalnote

Compare with previous version

added 1 commit <ul><li>378acd61 - Fix view_week_personalnote</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3169&start_sha=5a90069764fef02d830c011cffa67fc8e8cfa793)
hansegucker commented 2020-08-20 16:51:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>32ad8b40 - Fix view_week_personalnote</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3170&start_sha=378acd6159efecd3d5c804ce294e993117623df5)
hansegucker commented 2020-08-20 16:52:59 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ef75d02b - Fix is_personal_note_lesson_teacher

Compare with previous version

added 1 commit <ul><li>ef75d02b - Fix is_personal_note_lesson_teacher</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3171&start_sha=32ad8b40c910fd6877c1681e1894a6dd4ecee62f)
hansegucker commented 2020-08-20 16:55:14 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>df357a62 - Fix call of property</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3172&start_sha=ef75d02b70bcae19c2c3b098271d314012c0356c)
hansegucker commented 2020-08-20 19:02:56 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #98

mentioned in issue #98
hansegucker commented 2020-08-20 19:18:19 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2020-08-20 19:20:05 +02:00 (Migrated from edugit.org)
Copy link

added 13 commits

  • df357a62...7d35d6c0 - 12 commits from branch master
  • f3206ef4 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 13 commits <ul><li>df357a62...7d35d6c0 - 12 commits from branch <code>master</code></li><li>f3206ef4 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3174&start_sha=df357a6208a850c9c32d79f3931fce52f43d9981)
hansegucker commented 2020-08-20 20:07:25 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e3d26b7d - Add permissions for students view and list

Compare with previous version

added 1 commit <ul><li>e3d26b7d - Add permissions for students view and list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3175&start_sha=f3206ef466d57d5a6ef82b25b42d3502de23dcae)
hansegucker commented 2020-08-21 10:03:39 +02:00 (Migrated from edugit.org)
Copy link

Todo: Allow only primary group owners to register absences

Todo: Allow only primary group owners to register absences
hansegucker commented 2020-08-21 16:21:19 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • e3d26b7d...1fac32b3 - 2 commits from branch master
  • a5429af4 - Merge branch 'master' into 73-add-rules-and-permissions
  • 0319cbcf - Fix register_absence rules (allow only primary group owners to register absences)

Compare with previous version

added 4 commits <ul><li>e3d26b7d...1fac32b3 - 2 commits from branch <code>master</code></li><li>a5429af4 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>0319cbcf - Fix register_absence rules (allow only primary group owners to register absences)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3177&start_sha=e3d26b7df130de915c104aa79ecca49219e9bf99)
hansegucker commented 2020-08-23 19:31:29 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 2c4e8922 - Fix permissions and permission checks for person overview
  • 256bf855 - Reformat

Compare with previous version

added 2 commits <ul><li>2c4e8922 - Fix permissions and permission checks for person overview</li><li>256bf855 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3186&start_sha=0319cbcfd780107838f3976114825189693f4cfd)
hansegucker commented 2020-08-30 15:36:36 +02:00 (Migrated from edugit.org)
Copy link

added 16 commits

  • 256bf855...c7a847a2 - 12 commits from branch master
  • d2caa75c - Merge branch 'master' into 73-add-rules-and-permissions
  • 8262a4aa - Add permissions check for DeletePersonalNoteView
  • e37a73ca - [Person overview] Show delete button also when personal note is excused
  • e4189166 - Reformat

Compare with previous version

added 16 commits <ul><li>256bf855...c7a847a2 - 12 commits from branch <code>master</code></li><li>d2caa75c - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li><li>8262a4aa - Add permissions check for DeletePersonalNoteView</li><li>e37a73ca - [Person overview] Show delete button also when personal note is excused</li><li>e4189166 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3223&start_sha=256bf8554589c10918d9482e95a47c112fd06d74)
hansegucker commented 2020-09-07 14:28:37 +02:00 (Migrated from edugit.org)
Copy link

mentioned in merge request !480

mentioned in merge request !480
hansegucker commented 2020-09-07 15:18:50 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • e4189166...a7727a68 - 2 commits from branch master
  • e9282bc9 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 3 commits <ul><li>e4189166...a7727a68 - 2 commits from branch <code>master</code></li><li>e9282bc9 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3248&start_sha=e418916620ddb3a0931a751d44f4ccd320b435ca)
hansegucker commented 2020-09-07 15:20:43 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 45330d48 - Simplify queryset in RegisterAbsenceForm

Compare with previous version

added 1 commit <ul><li>45330d48 - Simplify queryset in RegisterAbsenceForm</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3249&start_sha=e9282bc9a8622e6489fb8e6fe58c806654c4893c)
hansegucker commented 2020-09-11 11:19:48 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 45330d48...5833dfa2 - 3 commits from branch master
  • 120193ca - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 4 commits <ul><li>45330d48...5833dfa2 - 3 commits from branch <code>master</code></li><li>120193ca - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3298&start_sha=45330d4892e9bee15eccc179271ef6c485803bc8)
hansegucker commented 2020-09-11 11:21:56 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cff25c97 - Add permissions for "My groups"

Compare with previous version

added 1 commit <ul><li>cff25c97 - Add permissions for &quot;My groups&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3299&start_sha=120193ca56e7680bbfea56026c913f19493f9a14)
hansegucker commented 2020-09-11 11:24:10 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 34ef43d1 - Add menu validator for "My groups"

Compare with previous version

added 1 commit <ul><li>34ef43d1 - Add menu validator for &quot;My groups&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3301&start_sha=cff25c9713c51883e5d277f59f39f1e1a2bf0ecc)
hansegucker commented 2020-09-27 15:23:51 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 34ef43d1...dad563e6 - 4 commits from branch master
  • ed1fede6 - Merge branch 'master' into 73-add-rules-and-permissions

Compare with previous version

added 5 commits <ul><li>34ef43d1...dad563e6 - 4 commits from branch <code>master</code></li><li>ed1fede6 - Merge branch &#39;master&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3402&start_sha=34ef43d104d4d5900f7b6e311db516e931c9448e)
hansegucker commented 2020-10-15 17:52:15 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • ee72ebc2 - Fix problems with update_or_create and prefetching
  • 091caa94 - Merge branch 'fix/update-or-create' into 73-add-rules-and-permissions

Compare with previous version

added 2 commits <ul><li>ee72ebc2 - Fix problems with update_or_create and prefetching</li><li>091caa94 - Merge branch &#39;fix/update-or-create&#39; into 73-add-rules-and-permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3500&start_sha=ed1fede662cb4f9230fcf2a5593c69587f5952fe)
nik commented 2020-10-18 16:34:15 +02:00 (Migrated from edugit.org)
Copy link

This should descriptively be derived from view_lesson_predicate.

This should descriptively be derived from `view_lesson_predicate`.
nik commented 2020-10-18 16:34:16 +02:00 (Migrated from edugit.org)
Copy link

This should also be stacked onto view_lesson_personal_note.

This should also be stacked onto `view_lesson_personal_note`.
nik commented 2020-10-18 16:34:17 +02:00 (Migrated from edugit.org)
Copy link

The configuration check should be here, not inside is_own_personel_note.

The configuration check should be here, not inside `is_own_personel_note`.
nik commented 2020-10-18 16:34:17 +02:00 (Migrated from edugit.org)
Copy link

Should be based on the view counterpart.

Should be based on the view counterpart.
nik commented 2020-10-18 16:34:18 +02:00 (Migrated from edugit.org)
Copy link

Should probably be based on view_lesson (or even be an alias for it).

Should probably be based on `view_lesson` (or even be an alias for it).
nik commented 2020-10-18 16:34:19 +02:00 (Migrated from edugit.org)
Copy link

Should be based o nits view counterpart.

Should be based o nits view counterpart.
nik commented 2020-10-18 16:34:19 +02:00 (Migrated from edugit.org)
Copy link

Should be configurable, e.g. if a school mandates that only the headmastership.

Should be configurable, e.g. if a school mandates that only the headmastership.
nik commented 2020-10-18 16:34:20 +02:00 (Migrated from edugit.org)
Copy link

Should be configurable (not all schools want students to be ableto see their own records, unfortunately).

Should be configurable (not all schools want students to be ableto see their own records, unfortunately).
nik commented 2020-10-18 16:34:22 +02:00 (Migrated from edugit.org)
Copy link

Should be configurable, as above.

Should be configurable, as above.
nik commented 2020-10-18 16:34:26 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:27 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its more general counterpart.

Should be based on its more general counterpart.
nik commented 2020-10-18 16:34:31 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:32 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:33 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:36 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:39 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:40 +02:00 (Migrated from edugit.org)
Copy link

Should be based on its view counterpart.

Should be based on its view counterpart.
nik commented 2020-10-18 16:34:41 +02:00 (Migrated from edugit.org)
Copy link
    if not all((year, week, period_id)):
```suggestion:-0+0 if not all((year, week, period_id)): ```
nik commented 2020-10-18 16:34:45 +02:00 (Migrated from edugit.org)
Copy link

Why does this default to True?

Why does this default to `True`?
hansegucker commented 2020-10-21 17:01:30 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 77 of the diff

changed this line in [version 77 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3511&start_sha=091caa942bbcf88bb9993001ee81ae17136b19e0#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_64_64)
hansegucker commented 2020-10-21 17:01:32 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 77 of the diff

changed this line in [version 77 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3511&start_sha=091caa942bbcf88bb9993001ee81ae17136b19e0#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_151_154)
hansegucker commented 2020-10-21 17:01:33 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 77 of the diff

changed this line in [version 77 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3511&start_sha=091caa942bbcf88bb9993001ee81ae17136b19e0#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_164_168)
hansegucker commented 2020-10-21 17:01:36 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fe5e0576 - Respect setting "view_own_personal_notes" on all places

Compare with previous version

added 1 commit <ul><li>fe5e0576 - Respect setting &quot;view_own_personal_notes&quot; on all places</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3511&start_sha=091caa942bbcf88bb9993001ee81ae17136b19e0)
hansegucker commented 2020-10-21 17:07:17 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 78 of the diff

changed this line in [version 78 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3512&start_sha=fe5e057685a57a5f7e7418e9ab40d44b08335c12#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_132_132)
hansegucker commented 2020-10-21 17:07:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f57c83f3 - Make configurable if primary group owners can register absences for their groups

Compare with previous version

added 1 commit <ul><li>f57c83f3 - Make configurable if primary group owners can register absences for their groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3512&start_sha=fe5e057685a57a5f7e7418e9ab40d44b08335c12)
hansegucker commented 2020-10-21 17:10:19 +02:00 (Migrated from edugit.org)
Copy link

@yuha Can you please check this?

@yuha Can you please check this?
hansegucker commented 2020-10-21 17:28:05 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_43_43)
hansegucker commented 2020-10-21 17:28:06 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_52_51)
hansegucker commented 2020-10-21 17:28:07 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_73_72)
hansegucker commented 2020-10-21 17:28:07 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_82_80)
hansegucker commented 2020-10-21 17:28:08 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_92_84)
hansegucker commented 2020-10-21 17:28:08 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_179_171)
hansegucker commented 2020-10-21 17:28:09 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_190_185)
hansegucker commented 2020-10-21 17:28:09 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_206_198)
hansegucker commented 2020-10-21 17:28:10 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_210_204)
hansegucker commented 2020-10-21 17:28:10 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_214_210)
hansegucker commented 2020-10-21 17:28:11 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_222_220)
hansegucker commented 2020-10-21 17:28:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_226_226)
hansegucker commented 2020-10-21 17:28:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 79 of the diff

changed this line in [version 79 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128#f3a50d0e650e00a3599e6c03f601d019b8e2ecd5_230_232)
hansegucker commented 2020-10-21 17:28:14 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 57be44f2 - Include depending predicates in permission rules,

Compare with previous version

added 1 commit <ul><li>57be44f2 - Include depending predicates in permission rules,</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3513&start_sha=f57c83f3aa4e9f3db3c1246894dd193f70efc128)
hansegucker commented 2020-10-21 17:31:39 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 80 of the diff

changed this line in [version 80 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3514&start_sha=57be44f2375467bfe6ff0d158380e6991e456c57#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_58_58)
hansegucker commented 2020-10-21 17:31:41 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8af2cfc1 - Refactor "and" sequence using all()

Compare with previous version

added 1 commit <ul><li>8af2cfc1 - Refactor &quot;and&quot; sequence using all()</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3514&start_sha=57be44f2375467bfe6ff0d158380e6991e456c57)
hansegucker commented 2020-10-21 17:32:51 +02:00 (Migrated from edugit.org)
Copy link

@nik Except one question, all threads in this MR are resolved now. Please continue with code review fastly!

@nik Except one question, all threads in this MR are resolved now. Please continue with code review fastly!
nik commented 2020-10-23 14:48:12 +02:00 (Migrated from edugit.org)
Copy link

This code block needs some commenting.

This code block needs some commenting.
nik commented 2020-10-23 14:48:13 +02:00 (Migrated from edugit.org)
Copy link

Moving these lines is an unrelated change.

Moving these lines is an unrelated change.
nik commented 2020-10-23 14:48:13 +02:00 (Migrated from edugit.org)
Copy link

This code block needs some commenting.

This code block needs some commenting.
nik commented 2020-10-23 14:48:14 +02:00 (Migrated from edugit.org)
Copy link

Is this intentionally hiding the request kwarg from the parent __init__ and subsequent code?

Is this intentionally hiding the `request` kwarg from the parent `__init__` and subsequent code?
nik commented 2020-10-23 14:48:14 +02:00 (Migrated from edugit.org)
Copy link

In which regard is this related to the permissions?

In which regard is this related to the permissions?
nik commented 2020-10-23 14:48:14 +02:00 (Migrated from edugit.org)
Copy link

In which regard is this related to permissions?

In which regard is this related to permissions?
nik commented 2020-10-23 14:48:15 +02:00 (Migrated from edugit.org)
Copy link

Unrelated whitespace change

Unrelated whitespace change
nik commented 2020-10-23 14:48:15 +02:00 (Migrated from edugit.org)
Copy link

Unrelated whitespace change

Unrelated whitespace change
nik commented 2020-10-23 14:48:16 +02:00 (Migrated from edugit.org)
Copy link

Shouldn't this be a class method on LessonPeriod, or even a manager method?

Shouldn't this be a class method on LessonPeriod, or even a manager method?
nik commented 2020-10-23 14:48:16 +02:00 (Migrated from edugit.org)
Copy link

What is an "Instance object"?

What is an "Instance object"?
nik commented 2020-10-23 14:48:17 +02:00 (Migrated from edugit.org)
Copy link

Please turn this around.

Always extend privileges starting from the minimum, never start with accessing everything and then reducing to the actual permission level.

Please turn this around. *Always* extend privileges starting from the minimum, *never* start with accessing everything and then reducing to the actual permission level.
nik commented 2020-10-23 14:48:18 +02:00 (Migrated from edugit.org)
Copy link

Debug print!

Debug print!
nik commented 2020-10-23 14:48:18 +02:00 (Migrated from edugit.org)
Copy link

gain, always make privilege escalation additive rather than substractive.

gain, always make privilege escalation additive rather than substractive.
nik commented 2020-10-23 14:51:21 +02:00 (Migrated from edugit.org)
Copy link

What about these open tasks?

What about these open tasks?
nik commented 2020-10-23 14:53:05 +02:00 (Migrated from edugit.org)
Copy link

Please remove 451cdb33a7 from the history (and recreate it with a valid commiter ID).

Please remove 451cdb33a7987522913055d98256e71388b19946 from the history (and recreate it with a valid commiter ID).
hansegucker commented 2020-10-23 14:56:09 +02:00 (Migrated from edugit.org)
Copy link

Maybe you can do this for us, as we are not so experienced with Git at all.

Maybe you can do this for us, as we are not so experienced with Git at all.
hansegucker commented 2020-10-23 14:57:03 +02:00 (Migrated from edugit.org)
Copy link

They are all done.

They are all done.
hansegucker commented 2020-10-23 21:32:09 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9d6db523 - Refactor "and" sequence using all()

Compare with previous version

added 1 commit <ul><li>9d6db523 - Refactor &quot;and&quot; sequence using all()</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3519&start_sha=8af2cfc192bdeb41f0f5683abdd2c95ec811bc7e)
hansegucker commented 2020-10-23 21:47:52 +02:00 (Migrated from edugit.org)
Copy link

Yes, as the original class doesn't accept a request argument.

Yes, as the original class doesn't accept a request argument.
hansegucker commented 2020-10-23 21:54:20 +02:00 (Migrated from edugit.org)
Copy link

It won't work otherwise. If you merge https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/95, there won't be a diff more longer. I just merged it a little bit earlier to this branch than to the master.

It won't work otherwise. If you merge https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/95, there won't be a diff more longer. I just merged it a little bit earlier to this branch than to the master.
hansegucker commented 2020-10-24 11:36:02 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 82 of the diff

changed this line in [version 82 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3521&start_sha=9d6db523b1885e0b1ae077a593704e525296b8c9#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_574_574)
hansegucker commented 2020-10-24 11:36:04 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0985aa3c - Remove debug prints</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3521&start_sha=9d6db523b1885e0b1ae077a593704e525296b8c9)
hansegucker commented 2020-10-24 12:27:37 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 83 of the diff

changed this line in [version 83 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3522&start_sha=0985aa3c19859be8ce18f26ba5ebe4cc19dfb461#bd8664958a1ee12dd2af439715dcc93cbd19732d_136_144)
hansegucker commented 2020-10-24 12:27:41 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • d1f104f9 - Simplify request getter in forms
  • 5b288ced - Add some extra commenting in forms.py

Compare with previous version

added 2 commits <ul><li>d1f104f9 - Simplify request getter in forms</li><li>5b288ced - Add some extra commenting in forms.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3522&start_sha=0985aa3c19859be8ce18f26ba5ebe4cc19dfb461)
hansegucker commented 2020-10-24 12:28:11 +02:00 (Migrated from edugit.org)
Copy link

See earlier comment to the same topic.

See earlier comment to the same topic.
hansegucker commented 2020-10-24 12:32:48 +02:00 (Migrated from edugit.org)
Copy link

As this will have some very bad side effects (double commits etc.), we decided to keep this commit in the history and to make the creator responsible if this will have have side effects in the future.

As this will have some very bad side effects (double commits etc.), we decided to keep this commit in the history and to make the creator responsible if this will have have side effects in the future.
hansegucker commented 2020-10-24 12:38:01 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 84 of the diff

changed this line in [version 84 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3523&start_sha=5b288ced2e3fcc8667b9a032fcd41a4f2cc147a9#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_114_113)
hansegucker commented 2020-10-24 12:38:03 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3d5d957c - Make permission checks in views.py additive

Compare with previous version

added 1 commit <ul><li>3d5d957c - Make permission checks in views.py additive</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3523&start_sha=5b288ced2e3fcc8667b9a032fcd41a4f2cc147a9)
hansegucker commented 2020-10-24 12:40:02 +02:00 (Migrated from edugit.org)
Copy link

I don't think so because the function fits only a certain URL structure.

I don't think so because the function fits only a certain URL structure.
hansegucker commented 2020-10-24 12:41:05 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 85 of the diff

changed this line in [version 85 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3524&start_sha=3d5d957c0c09e8ecedc5c8bc77873055123380d9#61d7f3143d022dfa8c0d301a9ded744243043aba_41_41)
hansegucker commented 2020-10-24 12:41:08 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 85 of the diff

changed this line in [version 85 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3524&start_sha=3d5d957c0c09e8ecedc5c8bc77873055123380d9#61d7f3143d022dfa8c0d301a9ded744243043aba_48_48)
hansegucker commented 2020-10-24 12:41:10 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 31fed539 - Rename get_instance_by_pk and document it better

Compare with previous version

added 1 commit <ul><li>31fed539 - Rename get_instance_by_pk and document it better</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3524&start_sha=3d5d957c0c09e8ecedc5c8bc77873055123380d9)
hansegucker commented 2020-10-24 12:47:02 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 86 of the diff

changed this line in [version 86 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3525&start_sha=31fed539551f6705b967f4e72d8990be50af0296#c38d58efc16562681c17632a864e3430ffd12344_27_33)
hansegucker commented 2020-10-24 12:47:06 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 47ab315d - Fix defaults of some predicates (True to False) and catch side effect of this change

Compare with previous version

added 1 commit <ul><li>47ab315d - Fix defaults of some predicates (True to False) and catch side effect of this change</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/49/diffs?diff_id=3525&start_sha=31fed539551f6705b967f4e72d8990be50af0296)
hansegucker commented 2020-10-24 12:48:42 +02:00 (Migrated from edugit.org)
Copy link

Should now fit.

Should now fit.
hansegucker commented 2020-10-24 12:48:43 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-10-24 12:49:01 +02:00 (Migrated from edugit.org)
Copy link

All threads resolved @nik.

All threads resolved @nik.
nik commented 2020-10-24 23:38:50 +02:00 (Migrated from edugit.org)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nik (Migrated from edugit.org) merged commit 50db52549f into master 2020-10-24 23:39:01 +02:00
nik commented 2020-10-24 23:39:04 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 50db52549f

mentioned in commit 50db52549f9c74412bec72a154d90f0a1faa08d3
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!439
No description provided.