Fix week view code #436

Merged
hansegucker merged 8 commits from 60-make-alsijil-work-with-current-core-fixes into 60-make-alsijil-work-with-current-core 2020-06-01 21:57:14 +02:00
hansegucker commented 2020-05-31 12:33:36 +02:00 (Migrated from edugit.org)
  • Fix select form
  • Fix names
  • Fix URLs
- Fix select form - Fix names - Fix URLs
hansegucker commented 2020-05-31 12:33:38 +02:00 (Migrated from edugit.org)

changed milestone to %2

changed milestone to %2
hansegucker commented 2020-05-31 12:40:18 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>4da81bd8 - Fix week view code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/46/diffs?diff_id=2387&start_sha=f717a83a0488a77e911233de8fa30c6e01cd92b1)
debdolph commented 2020-05-31 19:15:08 +02:00 (Migrated from edugit.org)

Can you rebase to the latest master please?

Can you rebase to the latest master please?
debdolph commented 2020-05-31 19:35:52 +02:00 (Migrated from edugit.org)

Is this lint clean?

Is this lint clean?
hansegucker commented 2020-05-31 22:02:20 +02:00 (Migrated from edugit.org)

No, but it wasn't before, too, so I think, it should be made clean in the main MR.

No, but it wasn't before, too, so I think, it should be made clean in the main MR.
hansegucker commented 2020-05-31 22:02:22 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
hansegucker commented 2020-05-31 22:02:35 +02:00 (Migrated from edugit.org)

Done.

Done.
hansegucker commented 2020-05-31 22:02:35 +02:00 (Migrated from edugit.org)

added 6 commits

  • 4da81bd8...be383026 - 5 commits from branch 60-make-alsijil-work-with-current-core
  • 7eba57d9 - Merge remote-tracking branch 'origin/master' into 60-make-alsijil-work-with-current-core-fixes

Compare with previous version

added 6 commits <ul><li>4da81bd8...be383026 - 5 commits from branch <code>60-make-alsijil-work-with-current-core</code></li><li>7eba57d9 - Merge remote-tracking branch &#39;origin/master&#39; into 60-make-alsijil-work-with-current-core-fixes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/46/diffs?diff_id=2388&start_sha=4da81bd8e5bb98f5742e6678d72c62168a3538d3)
hansegucker commented 2020-05-31 22:02:42 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
debdolph commented 2020-06-01 17:00:41 +02:00 (Migrated from edugit.org)

ok for me. Maybe @nik wants to review this too.

ok for me. Maybe @nik wants to review this too.
debdolph commented 2020-06-01 17:00:48 +02:00 (Migrated from edugit.org)

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
hansegucker commented 2020-06-01 17:04:35 +02:00 (Migrated from edugit.org)

OK, thanks.

OK, thanks.
hansegucker commented 2020-06-01 17:04:37 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
nik commented 2020-06-01 21:57:14 +02:00 (Migrated from edugit.org)

mentioned in commit 5f16cb3c77

mentioned in commit 5f16cb3c77dd3180e5d5ee2c5064b1f8a14b1488
nik commented 2020-06-01 21:57:14 +02:00 (Migrated from edugit.org)

merged

merged
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!436
No description provided.