aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Resolve "Migrate to materialize.css" #427

Merged
debdolph merged 19 commits from 58-migrate-to-materialize-css into master 2020-01-28 21:23:17 +01:00
Conversation 81 Commits 19 Files changed 10 +114 -202
debdolph commented 2020-01-19 19:21:51 +01:00 (Migrated from edugit.org)
Copy link

Closes #58

Closes #58
debdolph commented 2020-01-19 19:21:51 +01:00 (Migrated from edugit.org)
Copy link

changed milestone to %"2.0a1"

changed milestone to %"2.0a1"
debdolph commented 2020-01-21 21:35:41 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>368915db - Migrate to materialize-css. Advances #58.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1192&start_sha=dfba5000317d5df96a24187523b0a321aff08135)
debdolph commented 2020-01-21 21:36:02 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
debdolph commented 2020-01-21 21:38:31 +01:00 (Migrated from edugit.org)
Copy link

Maybe @hansegucker can have a quick look at the materialize stuff to verify that everything that looks correct was done correctly ;)…

Maybe @hansegucker can have a quick look at the materialize stuff to verify that everything that looks correct was done correctly ;)…
debdolph commented 2020-01-21 21:52:36 +01:00 (Migrated from edugit.org)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
debdolph commented 2020-01-22 12:51:54 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 368915db...b2b39def - 2 commits from branch master
  • c94f960d - Merge branch 'master' into 58-migrate-to-materialize-css

Compare with previous version

added 3 commits <ul><li>368915db...b2b39def - 2 commits from branch <code>master</code></li><li>c94f960d - Merge branch &#39;master&#39; into 58-migrate-to-materialize-css</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1197&start_sha=368915db6046cb50bed513a016fb2d78892dbef6)
nik commented 2020-01-22 14:37:36 +01:00 (Migrated from edugit.org)
Copy link

Why did you remove the title?

Why did you remove the title?
debdolph commented 2020-01-22 14:45:11 +01:00 (Migrated from edugit.org)
Copy link

AlekSIS/AlekSIS#146

AlekSIS/AlekSIS#146
debdolph commented 2020-01-22 14:45:11 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-01-22 16:30:26 +01:00 (Migrated from edugit.org)
Copy link

After a first look, everything seems to be fine. I will test it later.

After a first look, everything seems to be fine. I will test it later.
hansegucker commented 2020-01-22 16:56:38 +01:00 (Migrated from edugit.org)
Copy link

That's not materialize.

That's not materialize.
hansegucker commented 2020-01-22 16:57:34 +01:00 (Migrated from edugit.org)
Copy link

Please add class green for optical feedback and add an text like Add filter.

Please add class `green` for optical feedback and add an text like `Add filter`.
hansegucker commented 2020-01-22 16:58:50 +01:00 (Migrated from edugit.org)
Copy link

I think instead of having one card Lessons we should have a card for every weekday and remove the heading Lessons.

I think instead of having one card `Lessons` we should have a card for every weekday and remove the heading `Lessons`.
hansegucker commented 2020-01-22 17:00:17 +01:00 (Migrated from edugit.org)
Copy link

It may look better with green-text.

It may look better with `green-text`.
debdolph commented 2020-01-22 17:21:59 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1199&start_sha=c94f960d725e2b6957e9a882d8982dd0460cb1cf#ae8fc1ab551d7f832bbd8458fb52822d78f6ed06_9_8)
debdolph commented 2020-01-22 17:22:00 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2d86c87b - Merge branch 'master' into 58-migrate-to-materialize-css

Compare with previous version

added 1 commit <ul><li>2d86c87b - Merge branch &#39;master&#39; into 58-migrate-to-materialize-css</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1199&start_sha=c94f960d725e2b6957e9a882d8982dd0460cb1cf)
debdolph commented 2020-01-22 17:23:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 08c7da5b - Merge branch 'master' into 58-migrate-to-materialize-css

Compare with previous version

added 1 commit <ul><li>08c7da5b - Merge branch &#39;master&#39; into 58-migrate-to-materialize-css</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1201&start_sha=2d86c87b0af97b6b33e9b4bfd14529241d5572de)
debdolph commented 2020-01-22 17:25:10 +01:00 (Migrated from edugit.org)
Copy link

We should use theme-based colours for the buttons because every school can choose their own colours.

We should use theme-based colours for the buttons because every school can choose their own colours.
hansegucker commented 2020-01-22 17:26:53 +01:00 (Migrated from edugit.org)
Copy link

It's the question: Is optical feedback on actions (green: add, red: delete, etc.) more important than theme colours? The way materialize buttons are used in AlekSIS until now is the first one.

It's the question: Is optical feedback on actions (green: add, red: delete, etc.) more important than theme colours? The way materialize buttons are used in AlekSIS until now is the first one.
debdolph commented 2020-01-22 17:27:55 +01:00 (Migrated from edugit.org)
Copy link

In bootstrap it looks much cleaner with only one card per week. Maybe you could post a screenshot from the week view later (I don't have working lessons, yet…).

In bootstrap it looks much cleaner with only one card per week. Maybe you could post a screenshot from the week view later (I don't have working lessons, yet…).
debdolph commented 2020-01-22 17:29:45 +01:00 (Migrated from edugit.org)
Copy link

Maybe you're right, yes. I will change that.

Maybe you're right, yes. I will change that.
debdolph commented 2020-01-22 22:18:09 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1204&start_sha=08c7da5bfcff2925169a0c07b96c3e063e78366e#f5c7fdee830f412ccae6bf7c3c8709353c408335_10_10)
debdolph commented 2020-01-22 22:18:10 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9d21f053 - Merge branch 'master' into 58-migrate-to-materialize-css

Compare with previous version

added 1 commit <ul><li>9d21f053 - Merge branch &#39;master&#39; into 58-migrate-to-materialize-css</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1204&start_sha=08c7da5bfcff2925169a0c07b96c3e063e78366e)
debdolph commented 2020-01-22 22:20:32 +01:00 (Migrated from edugit.org)
Copy link

It is much clearer to use the background colour for the whole row.

It is much clearer to use the background colour for the whole row.
debdolph commented 2020-01-24 16:47:26 +01:00 (Migrated from edugit.org)
Copy link

What do you think, @nik?

What do you think, @nik?
debdolph commented 2020-01-24 19:52:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fe70659b - Fix title in templates.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1215&start_sha=9d21f053d2a53c4438f978e8b102b6d56459969b)
nik commented 2020-01-24 20:51:01 +01:00 (Migrated from edugit.org)
Copy link

I have no clue. In case of doubt, @hansegucker makes better frontend decisions. But please post two screenshots.

I have no clue. In case of doubt, @hansegucker makes better frontend decisions. But please post two screenshots.
nik commented 2020-01-24 20:51:26 +01:00 (Migrated from edugit.org)
Copy link

Please post screenshots.

Please post screenshots.
debdolph commented 2020-01-24 21:59:35 +01:00 (Migrated from edugit.org)
Copy link

Screenshot_20200124_215655

![Screenshot_20200124_215655](/uploads/4d2f75fde3c015f1958b8c279218ade6/Screenshot_20200124_215655.png)
debdolph commented 2020-01-24 22:12:27 +01:00 (Migrated from edugit.org)
Copy link

Screenshot_20200124_220949Screenshot_20200124_221059

Hmm… maybe we should use one card for every weekday ;)…

![Screenshot_20200124_220949](/uploads/60cac1bd1cf0158944d80a2301af6486/Screenshot_20200124_220949.png)![Screenshot_20200124_221059](/uploads/3d991101b2dd393ee2702d01e1c18b7e/Screenshot_20200124_221059.png) Hmm… maybe we should use one card for every weekday ;)…
hansegucker commented 2020-01-24 22:17:53 +01:00 (Migrated from edugit.org)
Copy link

I have to confess that I like the variant showed on 1 and 3, but the blue link is a little bit irritating. Maybe we should use a customized link colour.

I have to confess that I like the variant showed on 1 and 3, but the blue link is a little bit irritating. Maybe we should use a customized link colour.
debdolph commented 2020-01-24 22:20:14 +01:00 (Migrated from edugit.org)
Copy link

So you think that we shouldn't use the lighten-2 class?

So you think that we shouldn't use the lighten-2 class?
debdolph commented 2020-01-24 22:56:19 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1218&start_sha=fe70659baad36b32eb3eda8710d2caea2f2f7f29#90d1e91de2dd8326bc6fb815753407a8df263023_39_32)
debdolph commented 2020-01-24 22:56:21 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • c94f960d - Merge branch 'master' into 58-migrate-to-materialize-css
  • 782bc9ad - Use one card per weekday.
  • 48e71279 - Merge branch '58-migrate-to-materialize-css' of...

Compare with previous version

added 3 commits <ul><li>c94f960d - Merge branch &#39;master&#39; into 58-migrate-to-materialize-css</li><li>782bc9ad - Use one card per weekday.</li><li>48e71279 - Merge branch &#39;58-migrate-to-materialize-css&#39; of...</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1218&start_sha=fe70659baad36b32eb3eda8710d2caea2f2f7f29)
nik commented 2020-01-25 10:14:55 +01:00 (Migrated from edugit.org)
Copy link

1 and 3 are too intense. If we use a background, then 2 and 4.

1 and 3 are too intense. If we use a background, then 2 and 4.
debdolph commented 2020-01-25 11:02:02 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fad76d47 - Remove superflous text class.

Compare with previous version

added 1 commit <ul><li>fad76d47 - Remove superflous text class.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1219&start_sha=48e712795f43c058c467b11382f4ed01eb282d1f)
debdolph commented 2020-01-25 11:08:54 +01:00 (Migrated from edugit.org)
Copy link

I agree with @nik.

@hansegucker: Feel free to mark this discussion as resolved if you agree too.

I agree with @nik. @hansegucker: Feel free to mark this discussion as resolved if you agree too.
hansegucker commented 2020-01-25 11:48:55 +01:00 (Migrated from edugit.org)
Copy link

I have no problem with 2 and 4, but the link colour have to be changed definitely.

I have no problem with 2 and 4, but the link colour have to be changed definitely.
hansegucker commented 2020-01-25 11:50:01 +01:00 (Migrated from edugit.org)
Copy link

btn-dark?

btn-dark?
hansegucker commented 2020-01-25 11:50:31 +01:00 (Migrated from edugit.org)
Copy link

btn-dark? Maybe add waves? Icon?

btn-dark? Maybe add waves? Icon?
hansegucker commented 2020-01-25 11:51:35 +01:00 (Migrated from edugit.org)
Copy link

Red is correct here?

Red is correct here?
hansegucker commented 2020-01-25 11:52:37 +01:00 (Migrated from edugit.org)
Copy link

Looks like bootstrap.

Looks like bootstrap.
debdolph commented 2020-01-25 14:33:54 +01:00 (Migrated from edugit.org)
Copy link

Yup. With this button you can delete a filter.

Yup. With this button you can delete a filter.
hansegucker commented 2020-01-25 17:55:53 +01:00 (Migrated from edugit.org)
Copy link

Then the button shouldn't have the label "Add filter", should it? And the icon should be "delete".

Then the button shouldn't have the label "Add filter", should it? And the icon should be "delete".
debdolph commented 2020-01-25 22:13:43 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • dc9b0668 - fix tag.
  • d1d5f989 - Merge branch '58-migrate-to-materialize-css' of...

Compare with previous version

added 2 commits <ul><li>dc9b0668 - fix tag.</li><li>d1d5f989 - Merge branch &#39;58-migrate-to-materialize-css&#39; of...</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1222&start_sha=fad76d471caa3e1c2737dc7c6d8bd73a1a5fa729)
debdolph commented 2020-01-25 22:18:20 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>82d7539e - Fix link and text.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1223&start_sha=d1d5f98924a8bfbd6b66201091dfd701d1fd3699)
debdolph commented 2020-01-26 14:25:34 +01:00 (Migrated from edugit.org)
Copy link

btn-dark is the secondary colour so this button can be customized. I think we don't need an icon for the select button.

`btn-dark` is the secondary colour so this button can be customized. I think we don't need an icon for the select button.
debdolph commented 2020-01-26 14:25:55 +01:00 (Migrated from edugit.org)
Copy link

btn-dark is the secondary colour so this button can be customized.

`btn-dark` is the secondary colour so this button can be customized.
debdolph commented 2020-01-26 14:27:03 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1227&start_sha=82d7539ec6fe9376261cfd7620824928cffaf56c#90d1e91de2dd8326bc6fb815753407a8df263023_15_15)
debdolph commented 2020-01-26 14:27:03 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1227&start_sha=82d7539ec6fe9376261cfd7620824928cffaf56c#d87fc08482f6efa5af42bce3a6b41e1fba5c4985_56_56)
debdolph commented 2020-01-26 14:27:04 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 17f7a5f7 - Fix templates.
  • 8fbd0847 - Merge branch '58-migrate-to-materialize-css' of...

Compare with previous version

added 2 commits <ul><li>17f7a5f7 - Fix templates.</li><li>8fbd0847 - Merge branch &#39;58-migrate-to-materialize-css&#39; of...</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1227&start_sha=82d7539ec6fe9376261cfd7620824928cffaf56c)
hansegucker commented 2020-01-26 15:08:52 +01:00 (Migrated from edugit.org)
Copy link

Where is this class defined? In Materialize?

Where is this class defined? In Materialize?
hansegucker commented 2020-01-26 15:09:26 +01:00 (Migrated from edugit.org)
Copy link

And the secondary colour is the default colour for buttons. It's unnecessary to add an extra CSS class for that.

And the secondary colour is the default colour for buttons. It's unnecessary to add an extra CSS class for that.
hansegucker commented 2020-01-26 15:10:35 +01:00 (Migrated from edugit.org)
Copy link

Yes, you are right, the icon isn't necessary here.

For btn-dark see above.

Yes, you are right, the icon isn't necessary here. For `btn-dark` see above.
debdolph commented 2020-01-26 15:11:02 +01:00 (Migrated from edugit.org)
Copy link

Maybe you want to look at the code again ;)...

Maybe you want to look at the code again ;)...
debdolph commented 2020-01-26 15:11:45 +01:00 (Migrated from edugit.org)
Copy link

Aaaah okay i will remove it.

Aaaah okay i will remove it.
debdolph commented 2020-01-26 15:14:59 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1232&start_sha=8fbd0847eaee9a2446d7f8da06d0eb0badde325a#90d1e91de2dd8326bc6fb815753407a8df263023_22_22)
debdolph commented 2020-01-26 15:15:00 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 36911718 - Remove unnecessary class btn-dark.

Compare with previous version

added 1 commit <ul><li>36911718 - Remove unnecessary class btn-dark.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1232&start_sha=8fbd0847eaee9a2446d7f8da06d0eb0badde325a)
debdolph commented 2020-01-26 15:15:33 +01:00 (Migrated from edugit.org)
Copy link

Which colour should we use for links?

Which colour should we use for links?
nik commented 2020-01-26 15:24:34 +01:00 (Migrated from edugit.org)
Copy link

In data tables, I think the links should not have a colour. The whole table row should be clickable (but the texts inside still need to be <a>s to make it work without JavaScript, but they should not look like links.

Opinion, @hansegucker

In data tables, I think the links should not have a colour. The whole table row should be clickable (but the texts inside still need to be `<a>`s to make it work without JavaScript, but they should not look like links. Opinion, @hansegucker
nik commented 2020-01-26 15:28:56 +01:00 (Migrated from edugit.org)
Copy link
table.datatable a {
  color: inherit !important;
}
``` table.datatable a { color: inherit !important; } ```
debdolph commented 2020-01-26 15:36:15 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1234&start_sha=36911718b04e528dec9eaf16205b0f24746d3c47#90d1e91de2dd8326bc6fb815753407a8df263023_51_51)
debdolph commented 2020-01-26 15:36:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 978ecbb6 - Use colour classes from core.

Compare with previous version

added 1 commit <ul><li>978ecbb6 - Use colour classes from core.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1234&start_sha=36911718b04e528dec9eaf16205b0f24746d3c47)
hansegucker commented 2020-01-26 15:37:45 +01:00 (Migrated from edugit.org)
Copy link

In timetable.css in Chronos is a similar case.

In timetable.css in Chronos is a similar case.
hansegucker commented 2020-01-26 15:39:32 +01:00 (Migrated from edugit.org)
Copy link
      <button type="submit" class="btn waves-effect waves-light">
```suggestion:-0+0 <button type="submit" class="btn waves-effect waves-light"> ```
hansegucker commented 2020-01-26 15:39:44 +01:00 (Migrated from edugit.org)
Copy link
      <a class="btn waves-effect waves-light" href="{% url 'full_register_group' group.id %}">
```suggestion:-0+0 <a class="btn waves-effect waves-light" href="{% url 'full_register_group' group.id %}"> ```
debdolph commented 2020-01-26 15:42:32 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1235&start_sha=978ecbb6d9968f64e519dba3e3164f3dd082b44c#90d1e91de2dd8326bc6fb815753407a8df263023_15_15)
debdolph commented 2020-01-26 15:42:32 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8d1f276b - Apply suggestion to aleksis/apps/alsijil/templates/alsijil/week_view.html

Compare with previous version

added 1 commit <ul><li>8d1f276b - Apply suggestion to aleksis/apps/alsijil/templates/alsijil/week_view.html</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1235&start_sha=978ecbb6d9968f64e519dba3e3164f3dd082b44c)
debdolph commented 2020-01-26 15:47:54 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
debdolph commented 2020-01-26 15:47:56 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1236&start_sha=8d1f276bcb5589b897826239505dddd80b6be68b#90d1e91de2dd8326bc6fb815753407a8df263023_22_22)
debdolph commented 2020-01-26 15:47:57 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e20f0de8 - Apply suggestion to aleksis/apps/alsijil/templates/alsijil/week_view.html

Compare with previous version

added 1 commit <ul><li>e20f0de8 - Apply suggestion to aleksis/apps/alsijil/templates/alsijil/week_view.html</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1236&start_sha=8d1f276bcb5589b897826239505dddd80b6be68b)
debdolph commented 2020-01-26 15:52:46 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 127fdef9 - Add stylesheet for links in datatables.
  • 94145366 - Merge branch '58-migrate-to-materialize-css' of...

Compare with previous version

added 2 commits <ul><li>127fdef9 - Add stylesheet for links in datatables.</li><li>94145366 - Merge branch &#39;58-migrate-to-materialize-css&#39; of...</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1237&start_sha=e20f0de810e9215713530b2d5d50f932f91f717f)
hansegucker commented 2020-01-27 19:16:35 +01:00 (Migrated from edugit.org)
Copy link

bootstrap_form ?

`bootstrap_form` ?
hansegucker commented 2020-01-27 19:17:18 +01:00 (Migrated from edugit.org)
Copy link

I am not sure but if it's a form it should use material_form.

I am not sure but if it's a form it should use material_form.
nik commented 2020-01-27 19:19:44 +01:00 (Migrated from edugit.org)
Copy link

I am certain that a form with only hidden input fields does not need a Material theme.

I am certain that a form with only hidden input fields does not need a Material theme.
hansegucker commented 2020-01-27 19:20:27 +01:00 (Migrated from edugit.org)
Copy link

That's correct.

That's correct.
debdolph commented 2020-01-27 21:13:54 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
debdolph commented 2020-01-27 21:13:59 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1243&start_sha=94145366f23f74c9b16aa9cf5a3993126090858d#d87fc08482f6efa5af42bce3a6b41e1fba5c4985_37_37)
debdolph commented 2020-01-27 21:13:59 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d44ce23a - Use material_form.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS-App-Alsijil/merge_requests/37/diffs?diff_id=1243&start_sha=94145366f23f74c9b16aa9cf5a3993126090858d)
hansegucker commented 2020-01-28 21:23:16 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 02cd44ea72

mentioned in commit 02cd44ea72e5989358c4d8031e2eeeec5db76eb5
hansegucker commented 2020-01-28 21:23:17 +01:00 (Migrated from edugit.org)
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
2.0a1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!427
No description provided.