teckids/AlekSIS-App-Paweljong
9
0
Fork 0
Code Issues 24 Pull requests 17 Projects Releases Packages Wiki Activity Actions

Resolve "Remove additional fields support and re-implement additional fields in paweljong" #175

Merged
yuha merged 37 commits from 58-remove-additional-fields-support into master 2024-08-06 22:29:43 +02:00
Conversation 42 Commits 37 Files changed 18 +564 -118
yuha commented 2024-03-03 17:59:07 +01:00 (Migrated from edugit.org)
Copy link

Closes #58

Closes #58
yuha commented 2024-03-03 17:59:07 +01:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2024-03-03 18:18:34 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2024-03-03 18:18:39 +01:00 (Migrated from edugit.org)
Copy link

assigned to @debdolph and unassigned @yuha

assigned to @debdolph and unassigned @yuha
yuha commented 2024-03-03 19:22:29 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 375692f2 - Remove references to additional fields on groups

Compare with previous version

added 1 commit <ul><li>375692f2 - Remove references to additional fields on groups</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=40209&start_sha=d76aa63030f5a2c0ed9b407218c02c3b7dfb34b7)
yuha commented 2024-03-05 15:56:52 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
yuha commented 2024-03-05 15:57:34 +01:00 (Migrated from edugit.org)
Copy link

changed title from Draft: Resolve "Remove additional fields support" to Draft: Resolve "Remove additional fields support{+ and re-implement additional fields in paweljong+}"

changed title from **Draft: Resolve "Remove additional fields support"** to **Draft: Resolve "Remove additional fields support{+ and re-implement additional fields in paweljong+}"**
yuha commented 2024-03-05 15:57:40 +01:00 (Migrated from edugit.org)
Copy link

assigned to @yuha and unassigned @debdolph

assigned to @yuha and unassigned @debdolph
yuha commented 2024-03-06 14:50:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 70d080f2 - WIP: move additional field

Compare with previous version

added 1 commit <ul><li>70d080f2 - WIP: move additional field</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=40355&start_sha=375692f2c2b8263162513ef6976f1826fdf1a510)
yuha commented 2024-04-25 14:49:26 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>44ebd398 - WIP: move additional field</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42368&start_sha=70d080f2e0eafbc4ec3c6e013111fdce0e849bb7)
ZugBahnHof commented 2024-04-26 01:22:40 +02:00 (Migrated from edugit.org)
Copy link

Zwischenstand: couldn't get it running. The server will now start and everything (see #62 ), but when trying to start within this branch I get a bunch of errors due to a broken schema.py This really seems to be a WIP file that is not supposed to run. I did some changes, but I believe there is a lot more to be done, especially in preparation for the new crud lists.

Zwischenstand: couldn't get it running. The server will now start and everything (see #62 ), but when trying to start within this branch I get a bunch of errors due to a broken `schema.py` This really seems to be a WIP file that is not supposed to run. I did some changes, but I believe there is a lot more to be done, especially in preparation for the new crud lists.
ZugBahnHof commented 2024-04-26 01:24:58 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>be646ab0 - Fix import errors</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42379&start_sha=44ebd398910f8baebd4db5538530e4bb90d5eb86)
yuha commented 2024-04-26 01:39:16 +02:00 (Migrated from edugit.org)
Copy link

alright, then i guess i should do some further fixing, thanks for testing & the initial fixes :)

alright, then i guess i should do some further fixing, thanks for testing & the initial fixes :)
ZugBahnHof commented 2024-05-02 18:39:18 +02:00 (Migrated from edugit.org)
Copy link

added 9 commits

  • 2bb3d8d7 - Use correct objecttypes and mutations for the new inlinecrudlist
  • 2180a1be - Rework form field appearance
  • 88d0692f - Translate paweljong
  • 0c6ff0e5 - Rework fieldTypeItems
  • 2dd72c92 - Run repository-wide reformat
  • d54d3a98 - Fix typo
  • 7bfe0e55 - Add menu and title translations for additional fields
  • 6caab8cf - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable
  • 7e5d948f - Incude additional fields in Event detail view

Compare with previous version

added 9 commits <ul><li>2bb3d8d7 - Use correct objecttypes and mutations for the new inlinecrudlist</li><li>2180a1be - Rework form field appearance</li><li>88d0692f - Translate paweljong</li><li>0c6ff0e5 - Rework fieldTypeItems</li><li>2dd72c92 - Run repository-wide reformat</li><li>d54d3a98 - Fix typo</li><li>7bfe0e55 - Add menu and title translations for additional fields</li><li>6caab8cf - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable</li><li>7e5d948f - Incude additional fields in Event detail view</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42543&start_sha=be646ab02498c899f46f5a3343d5b210e434ea4f)
yuha commented 2024-05-03 12:21:00 +02:00 (Migrated from edugit.org)
Copy link

TODO: permissions

TODO: permissions
yuha commented 2024-05-03 12:34:44 +02:00 (Migrated from edugit.org)
Copy link

added 22 commits

  • 7e5d948f...25689950 - 10 commits from branch master
  • 25689950...466957ce - 2 earlier commits
  • 943c18bc - Fix import errors
  • 14212431 - Use correct objecttypes and mutations for the new inlinecrudlist
  • 7693c0c0 - Rework form field appearance
  • a1899e00 - Translate paweljong
  • af337674 - Rework fieldTypeItems
  • 41804ad4 - Run repository-wide reformat
  • 47518456 - Fix typo
  • d4d3d26e - Add menu and title translations for additional fields
  • 1f8dddb6 - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable
  • 8ce3f4e3 - Incude additional fields in Event detail view

Compare with previous version

added 22 commits <ul><li>7e5d948f...25689950 - 10 commits from branch <code>master</code></li><li>25689950...466957ce - 2 earlier commits</li><li>943c18bc - Fix import errors</li><li>14212431 - Use correct objecttypes and mutations for the new inlinecrudlist</li><li>7693c0c0 - Rework form field appearance</li><li>a1899e00 - Translate paweljong</li><li>af337674 - Rework fieldTypeItems</li><li>41804ad4 - Run repository-wide reformat</li><li>47518456 - Fix typo</li><li>d4d3d26e - Add menu and title translations for additional fields</li><li>1f8dddb6 - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable</li><li>8ce3f4e3 - Incude additional fields in Event detail view</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42566&start_sha=7e5d948f0b981be34e95b5a35b3fce90fce6b76e)
yuha commented 2024-05-03 12:36:11 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8d96ac4d - Fix permissions</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42568&start_sha=8ce3f4e33d8578462543a18ba34ce88123bc1d93)
yuha commented 2024-05-03 13:10:35 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>8d0bd2e6 - Add permissions</li><li>e58ab661 - Add create i18n key</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42570&start_sha=8d96ac4d1c2d35cd59bad51d3be49eb8a537da0e)
yuha commented 2024-05-03 13:10:48 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-05-03 13:12:29 +02:00 (Migrated from edugit.org)
Copy link

TODO @ZugBahnHof : The CRUD list does not autoupdate after creation/deletion. Could you have a look? Otherwise, this works now @nik , and if I'm not mistaken, TIC-Desk should be Core 4.0 compatible now. One thing: We have to make sure that django-formtools is at exactly version 2.3, otherwise – for some reason – the form steps get messed up.

TODO @ZugBahnHof : The CRUD list does not autoupdate after creation/deletion. Could you have a look? Otherwise, this works now @nik , and if I'm not mistaken, TIC-Desk should be Core 4.0 compatible now. One thing: We have to make sure that django-formtools is at exactly version 2.3, otherwise – for some reason – the form steps get messed up.
yuha commented 2024-05-03 13:18:59 +02:00 (Migrated from edugit.org)
Copy link

seems like that this is a general issue: https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1007

seems like that this is a general issue: https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1007
yuha commented 2024-05-03 13:19:00 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-05-03 13:19:10 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @yuha

assigned to @nik and unassigned @yuha
yuha commented 2024-05-03 13:19:13 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2024-05-03 13:23:41 +02:00 (Migrated from edugit.org)
Copy link

assigned to @ZugBahnHof and unassigned @nik

assigned to @ZugBahnHof and unassigned @nik
yuha commented 2024-05-03 13:23:43 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
yuha commented 2024-05-03 13:24:19 +02:00 (Migrated from edugit.org)
Copy link

TODO @ZugBahnHof : The CRUD table could be improved: use better names for field types & checkmarks for required status

TODO @ZugBahnHof : The CRUD table could be improved: use better names for field types & checkmarks for required status
yuha commented 2024-05-03 13:25:54 +02:00 (Migrated from edugit.org)
Copy link

TODO @ZugBahnHof Improve how additional field values are displayed in legacy registration status frondend (this looks like this atm):

image.png

TODO @ZugBahnHof Improve how additional field values are displayed in legacy registration status frondend (this looks like this atm): ![image.png](/uploads/08847d1803c6802d61ae718d9835aef0/image.png)
ZugBahnHof commented 2024-05-07 15:36:52 +02:00 (Migrated from edugit.org)
Copy link

added 15 commits

  • e58ab661...2180a1be - 5 earlier commits
  • 88d0692f - Translate paweljong
  • 0c6ff0e5 - Rework fieldTypeItems
  • 2dd72c92 - Run repository-wide reformat
  • d54d3a98 - Fix typo
  • 7bfe0e55 - Add menu and title translations for additional fields
  • 6caab8cf - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable
  • 7e5d948f - Incude additional fields in Event detail view
  • e0525d02 - Fix paweljong translations
  • 954ea7b3 - Display required state and field_type more beautifully
  • 763d9c5a - Merge remote-tracking branch 'origin/58-remove-additional-fields-support' into...

Compare with previous version

added 15 commits <ul><li>e58ab661...2180a1be - 5 earlier commits</li><li>88d0692f - Translate paweljong</li><li>0c6ff0e5 - Rework fieldTypeItems</li><li>2dd72c92 - Run repository-wide reformat</li><li>d54d3a98 - Fix typo</li><li>7bfe0e55 - Add menu and title translations for additional fields</li><li>6caab8cf - Replace missed occurrence of AdditionalFieldsTable with correct EventAdditionalFieldsTable</li><li>7e5d948f - Incude additional fields in Event detail view</li><li>e0525d02 - Fix paweljong translations</li><li>954ea7b3 - Display required state and field_type more beautifully</li><li>763d9c5a - Merge remote-tracking branch &#39;origin/58-remove-additional-fields-support&#39; into...</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42672&start_sha=e58ab661bf3befda2392df19ff2b8f911e60cf59)
yuha commented 2024-05-07 17:25:04 +02:00 (Migrated from edugit.org)
Copy link

TODO: Migration path from legacy group additional fields to new implementation

TODO: Migration path from legacy group additional fields to new implementation
yuha commented 2024-05-08 17:19:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8e5d00f3 - Add migration for migrating additional fields from core

Compare with previous version

added 1 commit <ul><li>8e5d00f3 - Add migration for migrating additional fields from core</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42700&start_sha=763d9c5a7ed20239c9bb5161130ad4bd7e0db3f9)
yuha commented 2024-05-08 17:20:54 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cd565583 - Add migration for migrating additional fields from core

Compare with previous version

added 1 commit <ul><li>cd565583 - Add migration for migrating additional fields from core</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42701&start_sha=8e5d00f3a2c0321f7c7eecd040e1708d51630207)
yuha commented 2024-05-08 23:55:46 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • add7bb82 - Set unique directly on field
  • f4bee6e6 - Remove broken multi-line text field from choices
  • 964f20b9 - Adapt SQL code for additional fields without relevance for events

Compare with previous version

added 3 commits <ul><li>add7bb82 - Set unique directly on field</li><li>f4bee6e6 - Remove broken multi-line text field from choices</li><li>964f20b9 - Adapt SQL code for additional fields without relevance for events</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42708&start_sha=cd565583eac003badd1235e888e9f448b1e13d97)
yuha commented 2024-05-09 00:00:33 +02:00 (Migrated from edugit.org)
Copy link

important note: Since there is no (and has never been) a TextField form field, this was dropped (and thus, migrating AdditionalFields from Core with such a field set would cause issues). I don't assume that this ever worked and thus also that no such fields were created, so that we shouldn't run into problems here.

important note: Since there is no (and has never been) a `TextField` form field, this was dropped (and thus, migrating `AdditionalFields` from Core with such a field set would cause issues). I don't assume that this ever worked and thus also that no such fields were created, so that we shouldn't run into problems here.
yuha commented 2024-05-15 01:24:43 +02:00 (Migrated from edugit.org)
Copy link

This should work fine now. @nik please have a look.

This should work fine now. @nik please have a look.
yuha commented 2024-05-15 01:24:46 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2024-05-15 01:25:10 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>338ef0d9 - Bump core dependency version</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=42953&start_sha=964f20b9ac35b5a980253479a759fb7c21853657)
yuha commented 2024-05-15 01:26:20 +02:00 (Migrated from edugit.org)
Copy link

@ZugBahnHof in case you have got some free time, please fix this in this new issue: https://edugit.org/Teckids/hacknfun/AlekSIS-App-Paweljong/-/issues/64

@ZugBahnHof in case you have got some free time, please fix this in this new issue: https://edugit.org/Teckids/hacknfun/AlekSIS-App-Paweljong/-/issues/64
yuha commented 2024-05-15 01:26:21 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-05-15 01:26:26 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @ZugBahnHof

assigned to @nik and unassigned @ZugBahnHof
yuha commented 2024-08-04 14:12:00 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>561a676c - Fix migrations</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=46320&start_sha=338ef0d94dadaa714e12f6b5b43c741d482d3262)
yuha commented 2024-08-06 17:21:43 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a8b5e361 - Bump core dependency version</li></ul> [Compare with previous version](/Teckids/hacknfun/AlekSIS-App-Paweljong/-/merge_requests/54/diffs?diff_id=46346&start_sha=561a676c43e7913aff339a1d145fba42657c6ef5)
debdolph commented 2024-08-06 22:29:43 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 70ebbd892d

mentioned in commit 70ebbd892dadc66ac4d79f6da28f6ad744f64d9b
debdolph (Migrated from edugit.org) merged commit 70ebbd892d into master 2024-08-06 22:29:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Doing

   
To Do
No labels
Doing
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
teckids/AlekSIS-App-Paweljong!175
No description provided.