aleksis/aleksis-website
9
0
Fork 0
Code Issues 11 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Licence review of newgimp theme #3

New issue
Closed
opened 2020-01-26 15:59:44 +01:00 by nik · 9 comments
nik commented 2020-01-26 15:59:44 +01:00
Owner
Copy link

@mirabilos Can you please do a quick audit on the newgimp theme licence and copyright holders, and add attributions as needed? The GIMP website itself claims it is CC-BY-SA 4.0, but they do not carry a copyright note themselves and no information on how and whom to attribute.

@mirabilos Can you please do a quick audit on the newgimp theme licence and copyright holders, and add attributions as needed? The GIMP website itself claims it is CC-BY-SA 4.0, but they do not carry a copyright note themselves and no information on how and whom to attribute.
mirabilos commented 2020-01-27 17:38:02 +01:00 (Migrated from edugit.org)
Copy link

Where did you get it from? I just see a commit hash in the log, but no source.

  • embedded code copy: font-awesome (Font: SIL OFL 1.1, CSS: MIT License)
  • embedded code copy: Tipue Search (MIT)
  • reference to Creative Commons icon font (likely trademark-restricted)
  • ⚠ cursory review found undeclared embedded code copy (Animate.css by Daniel Eden) in themes/newgimp/static/css/grid.css, so don’t trust anything about that subrepo

engaging in-depth review…

Where did you get it from? I just see a commit hash in the log, but no source. - embedded code copy: font-awesome (Font: SIL OFL 1.1, CSS: MIT License) - embedded code copy: Tipue Search (MIT) - reference to Creative Commons icon font (likely trademark-restricted) - ⚠ cursory review found __undeclared__ embedded code copy ([Animate.css by Daniel Eden](https://github.com/daneden/animate.css)) in `themes/newgimp/static/css/grid.css`, so don’t trust __anything__ about that subrepo engaging in-depth review…
mirabilos commented 2020-01-27 18:38:47 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit f63ac07457

mentioned in commit f63ac07457cb532b1dff5e2269ce5d5a8fbfdae0
mirabilos commented 2020-01-27 18:39:00 +01:00 (Migrated from edugit.org)
Copy link

I’ve begun. This is tricky and will take longer.

I’ve begun. This is tricky and will take longer.
mirabilos commented 2020-01-27 20:54:11 +01:00 (Migrated from edugit.org)
Copy link

@nik I strongly recommend dropping tipuesearch, it needs jQuery, normalise.css, more (partially minified) javascript you didn’t import anyway, and a JSON file generated from page contents (whose generator also was not imported). This will simplify things.

@nik I strongly recommend dropping tipuesearch, it needs jQuery, normalise.css, more (partially minified) javascript you didn’t import anyway, and a JSON file generated from page contents (whose generator also was not imported). This will simplify things.
mirabilos commented 2020-01-27 21:02:15 +01:00 (Migrated from edugit.org)
Copy link

I’d also recommend looking at reducing the amount and set of fonts used, and to limit to SIL OFL-licenced fonts or those with an explicit embedding permit.

I’d also recommend looking at reducing the amount and set of fonts used, and to limit to SIL OFL-licenced fonts or those with an explicit embedding permit.
mirabilos commented 2020-01-27 23:55:32 +01:00 (Migrated from edugit.org)
Copy link

Advanced but still some things to fix before it can go live.

Advanced but still some things to fix before it can go live.
mirabilos commented 2020-01-28 00:26:25 +01:00 (Migrated from edugit.org)
Copy link

Remaining issues AFAICT:

  • figure out who nmat is
  • retrieve explicit clearfix licence (not a showstopper)
Remaining issues AFAICT: * [x] figure out who `nmat` is * [ ] retrieve explicit `clearfix` licence (not a showstopper)
mirabilos commented 2020-01-28 00:54:29 +01:00 (Migrated from edugit.org)
Copy link

All issues I consider a veto on going live are resolved, the others pending external information.

All issues I consider a veto on going live are resolved, the others pending external information.
mirabilos commented 2020-01-28 00:54:30 +01:00 (Migrated from edugit.org)
Copy link

closed

closed
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
prepare-k8s-migration
36-wrong-tool-tip
gridsome
trademark
No results found.
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/aleksis-website#3
No description provided.