Refactor: Use class-based views #73

New issue

Closed

opened 2019-09-03 10:23:30 +02:00 by nik · 12 comments

nik commented

2019-09-03 10:23:30 +02:00

Owner

Turn all views in all apps into class-based views: https://docs.djangoproject.com/en/3.0/topics/class-based-views/

Identify different views and which views are similar enough to turn into a base view class, with overrides either through as_view or through inheritance or mixins
If it makes sense across apps, create base view classes in AlekSIS core
Move reusable code out of the views into util in each app, or even in AlekSIS core
Turn all views in all apps into class-based views finally

Turn all views in all apps into class-based views: https://docs.djangoproject.com/en/3.0/topics/class-based-views/ * [ ] Identify different views and which views are similar enough to turn into a base view class, with overrides either through `as_view` or through inheritance or mixins * [ ] If it makes sense across apps, create base view classes in AlekSIS core * [ ] Move reusable code out of the views into `util` in each app, or even in AlekSIS core * [ ] Turn all views in all apps into class-based views finally

nik commented

2019-09-07 19:56:47 +02:00

Author

Owner

assigned to @sstoffels and unassigned @nik

nik commented

2019-09-10 22:28:17 +02:00

Author

Owner

changed the description

nik commented

2019-09-30 23:47:21 +02:00

Author

Owner

@sstoffels Please give an update about the issues you took responsibility for.

sstoffels commented

2019-10-04 03:39:56 +02:00

(Migrated from edugit.org)

Invested 5 hours until now (2 for my initial test-installation, see merge-request concerning installation-hints)
First, I moved the most obvious views: "persons" and "groups" to classbased, first had to learn, that the usual ListViews cannot be used with render_table (when queryset is customized). Therefore, this documentation is helpful: https://django-tables2.readthedocs.io/en/latest/pages/tutorial.html

Some testdata to import into my test-instance would be appreciated now.

Invested 5 hours until now (2 for my initial test-installation, see merge-request concerning installation-hints) First, I moved the most obvious views: "persons" and "groups" to classbased, first had to learn, that the usual ListViews cannot be used with render_table (when queryset is customized). Therefore, this documentation is helpful: https://django-tables2.readthedocs.io/en/latest/pages/tutorial.html Some testdata to import into my test-instance would be appreciated now.

nik commented

2019-10-18 13:51:52 +02:00

Author

Owner

unassigned @sstoffels