OAuth2 broken in 2.4

tteichler commented

2021-12-27 16:54:02 +01:00

Owner

ERROR 2021-12-27 15:31:36,087 log: Internal Server Error: /oauth/.well-known/openid-configuration/
Traceback (most recent call last):
File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/exception.py", line 47, in inner
response = get_response(request)
File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 181, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 70, in view
return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/mixins.py", line 328, in dispatch
return super().dispatch(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 98, in dispatch
return handler(request, *args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/oidc.py", line 52, in get
for el, _ in validator.get_claim_list():
File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 738, in get_claim_list
add = self.get_additional_claims()
TypeError: get_additional_claims() missing 1 required positional argument: 'request'

``` ERROR 2021-12-27 15:31:36,087 log: Internal Server Error: /oauth/.well-known/openid-configuration/ Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/exception.py", line 47, in inner response = get_response(request) File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 181, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 70, in view return self.dispatch(request, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/mixins.py", line 328, in dispatch return super().dispatch(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 98, in dispatch return handler(request, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/oidc.py", line 52, in get for el, _ in validator.get_claim_list(): File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 738, in get_claim_list add = self.get_additional_claims() TypeError: get_additional_claims() missing 1 required positional argument: 'request' ```

tteichler commented

2021-12-27 17:13:43 +01:00

Author

Owner

mentioned in merge request !2499

tteichler commented

2021-12-28 11:09:54 +01:00

Author

Owner

assigned to @debdolph

nik commented

2021-12-28 12:05:06 +01:00

Owner

mentioned in commit 7940d501abd0632da895f70aa4f10e7c9d6754aa

nik commented

2021-12-28 12:06:42 +01:00

Owner

mentioned in commit 320bcf3f45fde2925ccdf5e070be54a9e0b4b58b

nik commented

2021-12-28 12:08:42 +01:00

Owner

mentioned in commit 8feb6843e9e64905fa6838fe119fa696a20531ed

nik commented

2021-12-28 12:09:35 +01:00

Owner

mentioned in commit fbdf1196c14e4a37a310b271c5b3857ae0620121

nik commented

2021-12-28 12:11:55 +01:00

Owner

mentioned in commit b9b2513153

mentioned in commit b9b2513153a93d4dea386d229a817b4478ae4a25

nik closed this issue

2021-12-28 13:08:36 +01:00

nik commented

2021-12-28 13:08:37 +01:00

Owner

mentioned in commit ef2a198cba

mentioned in commit ef2a198cba4d71bde2bb3d2cd65b5123e847ae68

tteichler commented

2022-01-03 09:42:28 +01:00

Author

Owner

unassigned @debdolph

tteichler commented

2022-01-03 09:42:29 +01:00

Author

Owner

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/utils/decorators.py", line 43, in _wrapper
    return bound_method(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/utils/decorators.py", line 43, in _wrapper
    return bound_method(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/views/decorators/debug.py", line 89, in sensitive_post_parameters_wrapper
    return view(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/base.py", line 260, in post
    url, headers, body, status = self.create_token_response(request)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/mixins.py", line 124, in create_token_response
    return core.create_token_response(request)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_backends.py", line 155, in create_token_response
    headers, body, status = self.server.create_token_response(
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/endpoints/base.py", line 112, in wrapper
    return f(endpoint, uri, *args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/endpoints/token.py", line 114, in create_token_response
    return grant_type_handler.create_token_response(
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/dispatchers.py", line 101, in create_token_response
    return handler.create_token_response(request, token_handler)
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py", line 308, in create_token_response
    token = modifier(token, token_handler, request)
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/authorization_code.py", line 43, in add_id_token
    return super().add_id_token(token, token_handler, request, nonce=nonce)
  File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/base.py", line 143, in add_id_token
    token['id_token'] = self.request_validator.finalize_id_token(id_token, token, token_handler, request)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 780, in finalize_id_token
    claims, expiration_time = self.get_id_token_dictionary(token, token_handler, request)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 761, in get_id_token_dictionary
    claims = self.get_oidc_claims(token, token_handler, request)
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 744, in get_oidc_claims
    data = self.get_claim_list()
  File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 738, in get_claim_list
    add = self.get_additional_claims()
TypeError: get_additional_claims() missing 1 required positional argument: 'request'

``` Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/exception.py", line 47, in inner response = get_response(request) File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 181, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 70, in view return self.dispatch(request, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/utils/decorators.py", line 43, in _wrapper return bound_method(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/decorators/csrf.py", line 54, in wrapped_view return view_func(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/generic/base.py", line 98, in dispatch return handler(request, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/utils/decorators.py", line 43, in _wrapper return bound_method(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/views/decorators/debug.py", line 89, in sensitive_post_parameters_wrapper return view(request, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/base.py", line 260, in post url, headers, body, status = self.create_token_response(request) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/views/mixins.py", line 124, in create_token_response return core.create_token_response(request) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_backends.py", line 155, in create_token_response headers, body, status = self.server.create_token_response( File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/endpoints/base.py", line 112, in wrapper return f(endpoint, uri, *args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/endpoints/token.py", line 114, in create_token_response return grant_type_handler.create_token_response( File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/dispatchers.py", line 101, in create_token_response return handler.create_token_response(request, token_handler) File "/usr/local/lib/python3.9/dist-packages/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py", line 308, in create_token_response token = modifier(token, token_handler, request) File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/authorization_code.py", line 43, in add_id_token return super().add_id_token(token, token_handler, request, nonce=nonce) File "/usr/local/lib/python3.9/dist-packages/oauthlib/openid/connect/core/grant_types/base.py", line 143, in add_id_token token['id_token'] = self.request_validator.finalize_id_token(id_token, token, token_handler, request) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 780, in finalize_id_token claims, expiration_time = self.get_id_token_dictionary(token, token_handler, request) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 761, in get_id_token_dictionary claims = self.get_oidc_claims(token, token_handler, request) File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 744, in get_oidc_claims data = self.get_claim_list() File "/usr/local/lib/python3.9/dist-packages/oauth2_provider/oauth2_validators.py", line 738, in get_claim_list add = self.get_additional_claims() TypeError: get_additional_claims() missing 1 required positional argument: 'request' ```

tteichler reopened this issue

2022-01-03 09:42:32 +01:00

nik commented

2022-01-03 21:56:30 +01:00

Owner

created merge request !2508 to address this issue