CRUD filter break certain cache updates #1617

New issue

Closed

opened 2026-05-10 15:46:56 +02:00 by leuckeju · 3 comments

leuckeju commented

2026-05-10 15:46:56 +02:00

Member

CRDUProvider:

  function updateFilters() {
    // queryVariables should be deeply reactive and this should work in all cases
    crud.queryVariables.value.filters = JSON.stringify({
      ...activeFilters.value,
      ...(objectSchema.value.enableServerSearch && searchString.value
        ? { search: searchString.value }
        : {}),
    });
    crud.queryRefetch(crud.queryVariables.value);
  }

should be

are not, however, if one would override them like this:

  <c-r-u-d-provider
    :object-schema="{
      type: 'GroupMembershipType',
    :query-variables="{ id: props.group.id }"
  />

This results in the cache read in the updateAfterMutate to fail with

    // Sometimes queryData is null, e.g. if using other query variables
    if (queryData === null) {
      console.warn("[useCrud] cached query data in updateCache is null.");
      console.debug("fullQuery", fullQuery);
      console.log(cache.extract());
      return;
    }

The problem seems to be, that while the filters are present while querying (and thus in the cache-set-key), they are not reactively included in the variables, when building the cache-get-key.

I am not quite sure how to fix this (esp. non-breakingly), but a quick (while dirty) fix would be to insert empty filters in the queryVariables prop like this:

  <c-r-u-d-provider
    :object-schema="{
      type: 'GroupMembershipType',
    :query-variables="{ id: props.group.id, filters: '{}' }"
  />

CRDUProvider: ```js function updateFilters() { // queryVariables should be deeply reactive and this should work in all cases crud.queryVariables.value.filters = JSON.stringify({ ...activeFilters.value, ...(objectSchema.value.enableServerSearch && searchString.value ? { search: searchString.value } : {}), }); crud.queryRefetch(crud.queryVariables.value); } ``` > should be are not, however, if one would override them like this: ```html <c-r-u-d-provider :object-schema="{ type: 'GroupMembershipType', :query-variables="{ id: props.group.id }" /> ``` This results in the cache read in the updateAfterMutate to fail with ```js // Sometimes queryData is null, e.g. if using other query variables if (queryData === null) { console.warn("[useCrud] cached query data in updateCache is null."); console.debug("fullQuery", fullQuery); console.log(cache.extract()); return; } ``` The problem seems to be, that while the filters are present while querying (and thus in the cache-set-key), they are not reactively included in the variables, when building the cache-get-key. I am not quite sure how to fix this (esp. non-breakingly), but a quick (while dirty) fix would be to insert empty `filters` in the `queryVariables` prop like this: ```html <c-r-u-d-provider :object-schema="{ type: 'GroupMembershipType', :query-variables="{ id: props.group.id, filters: '{}' }" /> ```