Option to hide incomplete substitutions from the plan #39

New issue

Closed

opened 2022-01-26 12:28:30 +01:00 by nik · 5 comments

nik commented 2022-01-26 12:28:30 +01:00

Owner

Copy link

At HHG, the Untis team wants to ensure that incomplete substitutions are hidden from the plan. If, e.g., a teacher or room has to be changed, and the room or teacher substitution exists but has no substitute teacher or room assigned yet, it should not be displayed in the plan. Currently, it is marked like a substitution (red border), displaying unchanged data.

At HHG, the Untis team wants to ensure that incomplete substitutions are hidden from the plan. If, e.g., a teacher or room has to be changed, and the room or teacher substitution exists but has no substitute teacher or room assigned yet, it should not be displayed in the plan. Currently, it is marked like a substitution (red border), displaying unchanged data.

nik commented 2022-01-26 12:30:45 +01:00

Author

Owner

Copy link

@hansegucker I mainly see two options here:

1. Detect the condition on import, and not import the substitution
2. Detect the condition when rendering plans, and not add visual indication of the change

Which one do you prefer?

@hansegucker I mainly see two options here: 1. Detect the condition on import, and not import the substitution 2. Detect the condition when rendering plans, and not add visual indication of the change Which one do you prefer?

nik commented 2022-01-26 16:30:17 +01:00

Author

Owner

Copy link

@hansegucker says no do import

@hansegucker says no do import

hansegucker commented 2022-02-02 20:16:12 +01:00

Owner

Copy link

created merge request !196 to address this issue

created merge request !196 to address this issue

hansegucker commented 2022-02-02 20:16:12 +01:00

Owner

Copy link

mentioned in merge request !196

mentioned in merge request !196

nik closed this issue 2022-02-05 17:02:22 +01:00

nik commented 2022-02-05 17:02:24 +01:00

Author

Owner

Copy link

mentioned in commit 7519ac31dc

mentioned in commit 7519ac31dc9a48f95ff5b3a4f4e4f75a904a6881

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

aleksolotl-checks

check/update-pyproject-toml

check/update-merge-request-template

check/update-builddeps-package-json

check/update-eslint-rc-js

check/update-tox-ini

74-update-for-current-changes-in-lesrooster

77-adapt-to-places

70-fix-until-date-of-previous-term-if-importing-new-term

stable-3.0

release-3.0

release-2.3.2

63-class-absences-lessons-with-multiple-classes-are-marked-as-cancelled-even-if-only-one-of-the

weblate

58-support-student-group-field-of-lesson

59-support-overlapping-periods

test-hhg

feature/vuejs

allow-30

54-importing-lessons-fails-due-to-wrong-reg-ex

i10n-ru-ua

49-import-should-respect-school_id

do-release-2.2

41-create-match-failures-as-data-checks

default-current

release-2.1.3

release-2.1.2

release-2.1.1

2.1.1

40-allow-selecting-plan-version-and-default-to-newest-version

fix-intersphinx

docs-refs

add-docs

fix/readme-syntax

35-disambiguate-long-group-names

update/tox-makemessages

release/2.0

25-fields-must-be-unique-per-site

update/changelog-2.0b0

trigger-dist-pipeline

fix-ci-config

19-update-supervisions-on-import

update-lockfile-core

update-tox2

update-tox

9-fix-update_or_create-calls

feature/use-entrypoints

update-lock-file

fix-docker-build

update-poetry-lockfile

core-158-documentation-needed-for-first-release

6-import-school-terms-and-validity-ranges

add-constance-settings-for-untis-db

3.0.1

3.0

3.0b0

2.3.2

2.3.1

2.3

2.2.1.dev0

2.2

2.2a0

2.1.4.dev0

2.1.3

2.1.2

2.1

2.1.dev2

2.1.dev1

2.1.dev0

2.0

2.0rc3

2.0rc2

2.0rc1

2.0b0

2.0a2

1.0a3

1.0a2

1.0a1

1.0a0

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

mysql

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

part

xml

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

  

source::aleksolotl

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

mysql

part

non-technical

part

packaging

part

xml

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

source::aleksolotl

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

aleksis/AlekSIS-App-Untis#39

No description provided.