aleksis/AlekSIS-App-Untis

Fork 0

Assign rooms correctly #27

New issue

Closed

opened 2021-08-28 12:25:00 +02:00 by fph · 10 comments

fph commented

2021-08-28 12:25:00 +02:00

(Migrated from edugit.org)

In a coupled lesson, if a room is not assigned to a learning group (in the example FrK), Chronos fills the gap from below so that the rooms are no longer assigned to the correct lesson. The expected representation can be seen in Figure 2. ![Bildschirmfoto_2021-08-28_12-08-40](/uploads/31faceab08c02a256f4a33ada658c33b/Bildschirmfoto_2021-08-28_12-08-40.png) ![room-issue](/uploads/c2aac257aca0a04d80429388a6af2773/room-issue.png)

hansegucker commented

2021-08-28 12:25:00 +02:00

(Migrated from edugit.org)

assigned to @hansegucker

hansegucker commented

2021-08-28 12:25:00 +02:00

(Migrated from edugit.org)

moved from AlekSIS-App-Chronos#148

fph commented

2021-08-29 06:44:49 +02:00

(Migrated from edugit.org)

The problem could also be that in this case two courses are taught by one teacher in the same room. I have now solved this for the time being by swapping the order of the courses in Untis.

hansegucker commented

2021-08-29 12:41:35 +02:00

(Migrated from edugit.org)

assigned to @hansegucker

hansegucker commented

2021-09-05 15:58:17 +02:00

(Migrated from edugit.org)

Here are some sample data from Untis:

25~0~26~47;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~137~0~0~,
25~0~123~47;~0;~0~0~13000~~~~~~~~n~~;17;18;19;20;~~~0~0~512~0~0~,
32~0~58~33;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~416~0~0~,
94~0~45~27;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~138~0~0~ 

~2~5~;47;33;27;~~,
~2~6~;47;33;27;~~,
~4~1~;47;33;27;~~

The only difference I can see is the 13000 at the line which shouldn't have a room. But I am unsure whether this is a safe mark.

Here are some sample data from Untis: ``` 25~0~26~47;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~137~0~0~, 25~0~123~47;~0;~0~0~13000~~~~~~~~n~~;17;18;19;20;~~~0~0~512~0~0~, 32~0~58~33;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~416~0~0~, 94~0~45~27;~0;~0~0~0~~~~~~~~n~~;17;18;19;20;~~~0~0~138~0~0~ ~2~5~;47;33;27;~~, ~2~6~;47;33;27;~~, ~4~1~;47;33;27;~~ ``` The only difference I can see is the `13000` at the line which shouldn't have a room. But I am unsure whether this is a safe mark.

hansegucker commented

2021-09-06 15:14:38 +02:00

(Migrated from edugit.org)

Okay, in general there seem to be these rules:

The number in the fourth field (47/47/33/27) is a room id, but not of the real room, but of the base room.
If the id is repeated, the id will appear only one time in the time data (47) – so both lesson periods are in the same room.
If there is no room in the fourth field, there will be also no room in the time data.

(Untis' data structure is the best one I have ever seen.)

Okay, in general there seem to be these rules: 1. The number in the fourth field (47/47/33/27) is a room id, but not of the real room, but of the base room. 2. If the id is repeated, the id will appear only one time in the time data (47) – so both lesson periods are in the same room. 3. If there is no room in the fourth field, there will be also no room in the time data. (Untis' data structure is the best one I have ever seen.)

hansegucker commented

2021-09-06 20:10:59 +02:00

(Migrated from edugit.org)

created merge request !161 to address this issue

hansegucker commented

2021-09-06 20:10:59 +02:00

(Migrated from edugit.org)

mentioned in merge request !161

hansegucker commented

2021-09-25 17:52:19 +02:00

(Migrated from edugit.org)

Correction: If there are two lesson parts with the same teacher, they will use the same room, but the room will appear just one time in the room list.

nik commented

2021-09-28 00:01:25 +02:00

(Migrated from edugit.org)

mentioned in commit 29b6c4ca14

mentioned in commit 29b6c4ca142efdd5beb42772416db2403003962e

nik (Migrated from edugit.org) closed this issue

2021-09-28 00:01:25 +02:00