Review tasks #8

Closed
opened 2022-01-26 17:27:16 +01:00 by hansegucker · 35 comments
Owner
  • synapse in aleksis/apps/matrix/tests
  • SETUP.rst in Docs
  • synapse test fixture
  • author Jonathan Weth and update email addresses
  • default_app_config muss weg
  • Copyright updaten
  • Slash in URL
  • in fixtures/
  • matrix.py in util/
  • raise from MatrixException from JSONDecodeError
  • toggle if in do_matrix_request
  • Do parsing before
  • dict small everywhere
  • raise ValueError if no ID
  • Docstrings
  • non_polymorphic instead of get_queryset
  • matrix imports on top
  • debug print
  • simply raise
  • power_levels with state key
  • joined_members testen?
  • property/getter system
  • Power levels in preferences
  • Should the code reduce power levels? → if not, keep current power levels
  • provision statt use
  • 26. child_spaces zu children
  • 27. sync_children → values_list
  • 28. User, Device ID, Device Name preference is superflouous
  • 29. Help texts for preferences
- [x] synapse in aleksis/apps/matrix/tests - [x] SETUP.rst in Docs - [x] synapse test fixture - [x] author Jonathan Weth and update email addresses - [x] default_app_config muss weg - [x] Copyright updaten - [x] Slash in URL - [x] in fixtures/ - [x] matrix.py in util/ - [x] raise from MatrixException from JSONDecodeError - [x] toggle if in do_matrix_request - [x] Do parsing before - [x] dict small everywhere - [x] raise ValueError if no ID - [x] Docstrings - [x] non_polymorphic instead of get_queryset - [x] matrix imports on top - [x] debug print - [x] simply raise - [x] power_levels with state key - [x] joined_members testen? - [x] property/getter system - [x] Power levels in preferences - [x] Should the code reduce power levels? → if not, keep current power levels - [x] provision statt use - [x] 26. child_spaces zu children - [x] 27. sync_children → values_list - [x] 28. User, Device ID, Device Name preference is superflouous - [x] 29. Help texts for preferences - [ ]
Author
Owner

assigned to @hansegucker

assigned to @hansegucker
Author
Owner

created merge request !53 to address this issue

created merge request !53 to address this issue
Author
Owner

mentioned in merge request !53

mentioned in merge request !53
Author
Owner

marked the checklist item synapse in aleksis/apps/matrix/tests as completed

marked the checklist item **synapse in aleksis/apps/matrix/tests** as completed
Author
Owner

marked the checklist item default_app_config muss weg as completed

marked the checklist item **default_app_config muss weg** as completed
Author
Owner

marked the checklist item author Jonathan Weth and update email addresses as completed

marked the checklist item **author Jonathan Weth and update email addresses** as completed
Author
Owner

marked the checklist item Copyright updaten as completed

marked the checklist item **Copyright updaten** as completed
Author
Owner

marked the checklist item in fixtures/ as completed

marked the checklist item **in fixtures/** as completed
Author
Owner

marked the checklist item matrix.py in util/ as completed

marked the checklist item **matrix.py in util/** as completed
Author
Owner

marked the checklist item toggle if in do_matrix_request as completed

marked the checklist item **toggle if in do_matrix_request** as completed
Author
Owner

marked the checklist item Do parsing before as completed

marked the checklist item **Do parsing before** as completed
Author
Owner

marked the checklist item raise from MatrixException from JSONDecodeError as completed

marked the checklist item **raise from MatrixException from JSONDecodeError** as completed
Author
Owner

marked the checklist item dict small everywhere as completed

marked the checklist item **dict small everywhere** as completed
Author
Owner

marked the checklist item simply raise as completed

marked the checklist item **simply raise** as completed
Author
Owner

marked the checklist item debug print as completed

marked the checklist item **debug print** as completed
Author
Owner

marked the checklist item matrix imports on top as completed

marked the checklist item **matrix imports on top** as completed
Author
Owner

marked the checklist item non_polymorphic instead of get_queryset as completed

marked the checklist item **non_polymorphic instead of get_queryset** as completed
Author
Owner

marked the checklist item 28. User, Device ID, Device Name preference is superflouous as completed

marked the checklist item **28. User, Device ID, Device Name preference is superflouous** as completed
Author
Owner

marked the checklist item Should the code reduce power levels? → if not, keep current power levels as completed

marked the checklist item **Should the code reduce power levels? → if not, keep current power levels** as completed
Author
Owner

marked the checklist item Power levels in preferences as completed

marked the checklist item **Power levels in preferences** as completed
Author
Owner

marked the checklist item property/getter system as completed

marked the checklist item **property/getter system** as completed
Author
Owner

marked the checklist item 26. child_spaces zu children as completed

marked the checklist item **26. child_spaces zu children** as completed
Author
Owner

marked the checklist item 27. sync_children → values_list as completed

marked the checklist item **27. sync_children → values_list** as completed
Author
Owner

marked the checklist item Docstrings as completed

marked the checklist item **Docstrings** as completed
Author
Owner

marked the checklist item raise ValueError if no ID as completed

marked the checklist item **raise ValueError if no ID** as completed
Author
Owner

marked the checklist item in fixtures/ as incomplete

marked the checklist item **in fixtures/** as incomplete
Author
Owner

marked the checklist item Slash in URL as completed

marked the checklist item **Slash in URL** as completed
Author
Owner

marked the checklist item in fixtures/ as completed

marked the checklist item **in fixtures/** as completed
Author
Owner

marked the checklist item synapse test fixture as completed

marked the checklist item **synapse test fixture** as completed
Author
Owner

marked the checklist item SETUP.rst in Docs as completed

marked the checklist item **SETUP.rst in Docs** as completed
Author
Owner

marked the checklist item joined_members testen? as completed

marked the checklist item **joined_members testen?** as completed
Author
Owner

marked the checklist item power_levels with state key as completed

marked the checklist item **power_levels with state key** as completed
Author
Owner

marked the checklist item provision statt use as completed

marked the checklist item **provision statt use** as completed
Author
Owner

marked the checklist item 29. Help texts for preferences as completed

marked the checklist item **29. Help texts for preferences** as completed
nik closed this issue 2022-03-04 11:37:07 +01:00
Owner

mentioned in commit 73abf1000e

mentioned in commit 73abf1000efdc2514a6e976a3a5e360a348de2c5
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Matrix#8
No description provided.