Existing rooms can get messed up if "Use spaces" preference changes #12

Open
opened 2022-02-23 23:33:26 +01:00 by nik · 9 comments
Owner

The frontend button to sync rooms with Matrix blindly relies on the "Use spaces" preferences, but groups might have gotten linked to a Space or a Room when the setting had another value.

In that case, it tries to create a new room/space after changing the setting.

The frontend button to sync rooms with Matrix blindly relies on the "Use spaces" preferences, but groups might have gotten linked to a Space or a Room when the setting had another value. In that case, it tries to create a new room/space after changing the setting.
Owner

In that case, it tries to create a new room/space after changing the setting.

This needs some further explanation for me. When exactly does this happen?

> In that case, it tries to create a new room/space after changing the setting. This needs some further explanation for me. When exactly does this happen?
Author
Owner

assigned to @nik

assigned to @nik
Author
Owner

To reproduce:

  1. Create a group and a subgroup of that
  2. Disable the "Use spaces" setting
  3. Deploy both rooms to Matrix
  4. Enable the "Use spaces" setting
  5. Re-sync
  6. Watch the world burn
To reproduce: 1. Create a group and a subgroup of that 2. Disable the "Use spaces" setting 3. Deploy both rooms to Matrix 4. Enable the "Use spaces" setting 5. Re-sync 6. Watch the world burn
Author
Owner

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
Author
Owner

mentioned in commit 61a9af17ea

mentioned in commit 61a9af17ea3d44fea9fa969cc78afcf2ec5d76eb
Author
Owner

mentioned in merge request !66

mentioned in merge request !66
Owner

mentioned in commit c2a8776214

mentioned in commit c2a87762144958a340ef18134cfa83c629b55b50
Member

@nik the result I get by following those steps (using „Parent group” and „Child group”) is a space called „Parent group” containing the previously created rooms „Parent group” and „Child group”.

To me, this is a reasonable result. Maybe one had a a chat for each course and one for the class and now decides to use spaces for a better overview. In that case, AlekSIS does exactly, what I'd expect: It creates a space containing all child group room and the parent group room, because it existed before and also belongs there.

What result would you expect? How does „the world burn”?

@nik the result I get by following those steps (using „Parent group” and „Child group”) is a space called „Parent group” containing the previously created rooms „Parent group” and „Child group”. To me, this is a reasonable result. Maybe one had a a chat for each course and one for the class and now decides to use spaces for a better overview. In that case, AlekSIS does exactly, what I'd expect: It creates a space containing all child group room and the parent group room, because it existed before and also belongs there. What result would you expect? How does „the world burn”?
Owner

unassigned @hansegucker

unassigned @hansegucker
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Matrix#12
No description provided.