Fix employment contract feature #200
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aleksis/AlekSIS-App-Kolego!200
Loading…
Reference in a new issue
No description provided.
Delete branch "62-fix-employment-contract"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Information and screenshots
No further information have been provided.
Checklist
tox -e reformat,lintusedapps.pyandREADME.rstup-to-dateBackend checklist
Frontend checklist (mandatory with ~"part::frontend")
Fix employment contract featureto WIP: Fix employment contract featureCloses #53
Closes #59
Closes #60
8e9e0d118f70944dd0667dbdc0fd748c1c9dff59WIP: Fix employment contract featureto Fix employment contract feature@ -3,9 +3,12 @@ import { defineAsyncComponent } from "vue";export const collectionItems = {corePersonWidgets: [{key: "core-person-widgets",Why is this widget no longer there?
oh good that you noticed that. that was an accident.
@ -55,4 +64,3 @@quota_base_duration = models.GeneratedField(expression=ExpressionWrapper(Case(When(quota_base_unit="minutes", then=F("quota_base") * Value(60)),Why is this removed?
Because I can't really think of cases where using hours or even minutes as the quota base feels reasonable & because allowing this would complicate the statistical evaluation mechanism (now, statistics are calculated and shown for the length of their quota base, starting on a given day which is the current date per default; adapting this to hours/minutes felt contraintuitive for me)
6d1f14aaf5280908645a