Adjust max_length attributes to better fitting values

hansegucker commented

2021-04-01 11:14:16 +02:00

Owner

FAQSection.name: 200 → 255
IssueCategory.name: 40 → 255
IssueCategory.placeholder: 100 → 255

- [ ] `FAQSection.name`: 200 → 255 - [ ] `IssueCategory.name`: 40 → 255 - [ ] `IssueCategory.placeholder`: 100 → 255

yuha commented

2021-04-02 14:27:54 +02:00

Member

created merge request !122 to address this issue

yuha commented

2021-04-02 14:27:55 +02:00

Member

mentioned in merge request !122

nik commented

2021-04-03 09:13:23 +02:00

Owner

Please provide a rationale on why this should be changed, i.e. why the current lengths are problematic.

hansegucker commented

2021-04-03 11:57:47 +02:00

Author

Owner

The UI components used to show these attributes don't have a limit for a specific character amount. Thus there is no reason to force users to be within 100 or even 40 characters.

hansegucker commented

2021-04-03 11:58:30 +02:00

Author

Owner

Issue categories or placeholders are very often longer than 40 characters and sometimes even longer than 100 characters.

nik commented

2021-04-03 17:33:30 +02:00

Owner

The texts ae used in headlines which should be one line al lthe way up to 200% zoom on an average screen.

hansegucker commented

2021-04-03 21:53:45 +02:00

Author

Owner

I can only see one text that is used in a headline (FAQ section name) which already has a limit of 200. From 200 to 255 isn't a big step then. In general, we don't control the circumstance mentioned by you using character limits – just take a look at the max_length attributes of all Core models.

I can only see one text that is used in a headline (FAQ section name) which already has a limit of 200. From 200 to 255 isn't a big step then. In general, we don't control the circumstance mentioned by you using character limits – just take a look at the `max_length` attributes of all Core models.

nik commented

2021-04-03 22:04:21 +02:00

Owner

So, if you advocate for not having a limit, why do you implement a limit of 255?

nik closed this issue

2021-04-17 00:03:38 +02:00

nik commented

2021-04-17 00:04:18 +02:00

Owner

mentioned in commit 94c059fa7d

mentioned in commit 94c059fa7d355cf61df27dd4e4934bfc40902134