Min and max functions out of scope #59

New issue

Closed

opened 2020-01-22 18:06:27 +01:00 by tteichler · 16 comments

tteichler commented 2020-01-22 18:06:27 +01:00

Owner

Copy link

Traceback (most recent call last):
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.UndefinedTable: relation "chronos_timeperiod" does not exist
LINE 1: ...s_timeperiod"."time_end") AS "time_end__max" FROM "chronos_t...
                                                             ^


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "./manage.py", line 15, in <module>
    execute_from_command_line(sys.argv)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 328, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 366, in execute
    self.check()
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 395, in check
    include_deployment_checks=include_deployment_checks,
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/commands/migrate.py", line 64, in _run_checks
    issues.extend(super()._run_checks(**kwargs))
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 382, in _run_checks
    return checks.run_checks(**kwargs)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/registry.py", line 72, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/urls.py", line 13, in check_url_config
    return check_resolver(resolver)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/urls.py", line 23, in check_resolver
    return check_method()
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 407, in check
    for pattern in self.url_patterns:
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 588, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 581, in urlconf_module
    return import_module(self.urlconf_name)
  File "/srv/aleksis/venv/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/src/AlekSIS/aleksis/core/urls.py", line 67, in <module>
    urlpatterns.append(path("app/%s/" % app_config.label, include("%s.urls" % app_config.name)))
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/conf.py", line 34, in include
    urlconf_module = import_module(urlconf_module)
  File "/srv/aleksis/venv/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/urls.py", line 3, in <module>
    from . import views
  File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/views.py", line 20, in <module>
    from .util.min_max import (
  File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/util/min_max.py", line 7, in <module>
    Min("period"), Max("period"), Min("weekday"), Max("weekday"), Min("time_start"), Max("time_end")
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/manager.py", line 82, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/query.py", line 384, in aggregate
    return query.get_aggregation(self.db, kwargs)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 502, in get_aggregation
    result = compiler.execute_sql(SINGLE)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/sql/compiler.py", line 1144, in execute_sql
    cursor.execute(sql, params)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 100, in execute
    return super().execute(sql, params)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 68, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 77, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute
    return self.cursor.execute(sql, params)
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: relation "chronos_timeperiod" does not exist
LINE 1: ...s_timeperiod"."time_end") AS "time_end__max" FROM "chronos_t...
                                                             ^

This happens a after fresh install on debian sid with postgresql 12.1-2

``` Traceback (most recent call last): File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute return self.cursor.execute(sql, params) psycopg2.errors.UndefinedTable: relation "chronos_timeperiod" does not exist LINE 1: ...s_timeperiod"."time_end") AS "time_end__max" FROM "chronos_t... ^ The above exception was the direct cause of the following exception: Traceback (most recent call last): File "./manage.py", line 15, in <module> execute_from_command_line(sys.argv) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line utility.execute() File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 328, in run_from_argv self.execute(*args, **cmd_options) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 366, in execute self.check() File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 395, in check include_deployment_checks=include_deployment_checks, File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/commands/migrate.py", line 64, in _run_checks issues.extend(super()._run_checks(**kwargs)) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/management/base.py", line 382, in _run_checks return checks.run_checks(**kwargs) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/registry.py", line 72, in run_checks new_errors = check(app_configs=app_configs) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/urls.py", line 13, in check_url_config return check_resolver(resolver) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/core/checks/urls.py", line 23, in check_resolver return check_method() File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 407, in check for pattern in self.url_patterns: File "/srv/aleksis/venv/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__ res = instance.__dict__[self.name] = self.func(instance) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 588, in url_patterns patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__ res = instance.__dict__[self.name] = self.func(instance) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/resolvers.py", line 581, in urlconf_module return import_module(self.urlconf_name) File "/srv/aleksis/venv/lib/python3.7/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1006, in _gcd_import File "<frozen importlib._bootstrap>", line 983, in _find_and_load File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 677, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 728, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/usr/src/AlekSIS/aleksis/core/urls.py", line 67, in <module> urlpatterns.append(path("app/%s/" % app_config.label, include("%s.urls" % app_config.name))) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/urls/conf.py", line 34, in include urlconf_module = import_module(urlconf_module) File "/srv/aleksis/venv/lib/python3.7/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1006, in _gcd_import File "<frozen importlib._bootstrap>", line 983, in _find_and_load File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 677, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 728, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/urls.py", line 3, in <module> from . import views File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/views.py", line 20, in <module> from .util.min_max import ( File "/usr/src/AlekSIS/apps/official/AlekSIS-App-Chronos/aleksis/apps/chronos/util/min_max.py", line 7, in <module> Min("period"), Max("period"), Min("weekday"), Max("weekday"), Min("time_start"), Max("time_end") File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/manager.py", line 82, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/query.py", line 384, in aggregate return query.get_aggregation(self.db, kwargs) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 502, in get_aggregation result = compiler.execute_sql(SINGLE) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/models/sql/compiler.py", line 1144, in execute_sql cursor.execute(sql, params) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 100, in execute return super().execute(sql, params) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 68, in execute return self._execute_with_wrappers(sql, params, many=False, executor=self._execute) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 77, in _execute_with_wrappers return executor(sql, params, many, context) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute return self.cursor.execute(sql, params) File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/utils.py", line 90, in __exit__ raise dj_exc_value.with_traceback(traceback) from exc_value File "/srv/aleksis/venv/lib/python3.7/site-packages/django/db/backends/utils.py", line 86, in _execute return self.cursor.execute(sql, params) django.db.utils.ProgrammingError: relation "chronos_timeperiod" does not exist LINE 1: ...s_timeperiod"."time_end") AS "time_end__max" FROM "chronos_t... ^ ``` This happens a after fresh install on `debian sid` with `postgresql 12.1-2`

hansegucker commented 2020-01-22 18:56:41 +01:00

Owner

Copy link

Oh, ok, we need a lazy wrapper for the min max functions. You haven't done migrations yet, have you?

Oh, ok, we need a lazy wrapper for the min max functions. You haven't done migrations yet, have you?

tteichler commented 2020-01-22 19:47:12 +01:00

Author

Owner

Copy link

No, I haven't

No, I haven't

tteichler commented 2020-01-24 19:02:44 +01:00

Author

Owner

Copy link

Has to be fixed as soon as possible due the presentation at FOSDEM.

Has to be fixed as soon as possible due the presentation at FOSDEM.

nik commented 2020-01-25 10:10:52 +01:00

Owner

Copy link

assigned to @nik

assigned to @nik

nik commented 2020-01-25 10:10:59 +01:00

Owner

Copy link

changed milestone to %"2.0a1"

changed milestone to %"2.0a1"

nik commented 2020-01-25 10:11:41 +01:00

Owner

Copy link

changed due date to January 26, 2020

changed due date to January 26, 2020

nik commented 2020-01-25 13:41:47 +01:00

Owner

Copy link

As I said, the min and max functions have to reside inside a manager. Defining them on model scope somewhere will cause this and other issues.

As I said, the min and max functions have to reside inside a manager. Defining them on model scope somewhere will cause this and other issues.

nik commented 2020-01-25 13:42:36 +01:00

Owner

Copy link

changed title from {-Error after fresh install-} to {+MIn and max functions out of scope+}

changed title from **{-Error after fresh install-}** to **{+MIn and max functions out of scope+}**

hansegucker commented 2020-01-25 17:52:32 +01:00

Owner

Copy link

I was (and I am still) unsure how to resolve it. Maybe you can do that, @nik?

I was (and I am still) unsure how to resolve it. Maybe you can do that, @nik?

nik commented 2020-01-26 17:17:28 +01:00

Owner

Copy link

mentioned in commit bb049cf9a2fdf48bc07c211882976ed23cbc0e09

mentioned in commit bb049cf9a2fdf48bc07c211882976ed23cbc0e09

nik commented 2020-01-26 17:17:39 +01:00

Owner

Copy link

changed title from M{-I-}n and max functions out of scope to M{+i+}n and max functions out of scope

changed title from **M{-I-}n and max functions out of scope** to **M{+i+}n and max functions out of scope**

nik commented 2020-01-26 17:18:26 +01:00

Owner

Copy link

mentioned in merge request !337

mentioned in merge request !337

nik commented 2020-01-26 21:21:16 +01:00

Owner

Copy link

mentioned in commit d924fb55b1

mentioned in commit d924fb55b19d7c673deeec308e58b4e8f6515f6d

hansegucker commented 2020-01-27 19:21:00 +01:00

Owner

Copy link

closed via merge request !337

closed via merge request !337

hansegucker commented 2020-01-27 19:21:00 +01:00

Owner

Copy link

mentioned in commit 35d64da9a6

mentioned in commit 35d64da9a6c6ed5077f8651a36a316306e49acb0

nik commented 2020-01-27 19:21:01 +01:00

Owner

Copy link

closed via commit d924fb55b1

closed via commit d924fb55b19d7c673deeec308e58b4e8f6515f6d

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

797-add-getobjectsforperson

weblate-frontend

weblate

304-adapt-to-core-changes-of-calendaralarm-inheritance-structure

299-automated-substitution-list-doesn-t-correctly-consider-kolego-absences-with-start-end-dates

check/update-builddeps-package-json

check/update-eslint-rc-js

check/update-tox-ini

247-use-lessonevent-feed-for-aggregated-availability-feed

292-adapt-to-places

stable/4.0.0

281-add-argument-to-lesson-events-get_objects-method-that-bypasses-the-filtering-done-if-own-false

release/4.0.0.dev9

release/4.0.0.dev7

fss-test-substitutions

221-show-course-name-of-lessons-in-the-timetable

241-substitution-planning-cancelled-checkbox-does-not-have-false-as-value-when-unchecked-actively

242-add-query-for-groups-of-which-the-current-user-can-see-the-respective-timetable

234-add-links-to-different-timetables-in-timetable-details-cards

migration-for-legacy

228-drop-legacy-model-and-form-extensions

engs-4.0

211-implement-vue-substitution-frontend-2

204-graphql-schema-for-subject

engs

197-adaptations-for-spa-operation

175-graphql-schemas

rename-ugettext

feature/vuetify

i10n-ru-ua

161-manage-basic-data-in-frontend

40-personal-timetable-as-ics

add-docs

core-284-unify-permission-names

162-extend-the-reference-to-the-next-lesson

160-ignore-subject-color-in-timetable-if-fg-bg

trademark-hint

update/tox-makemessages

create-timeperiods

backup-signals

140-show-abbreviations-in-the-substitution-plan-only-once

144-preference-section-is-called-chronos

update/poetry-4

130-show-print-timetable-button-on-mobile-devices

update-poetry-lock

117-use-django-guardian-s-prefetch-mechanism-for-object-permissions

trigger-dist-pipeline

2.0a4

update-lockfile-core

gettext-lazy

update-tox2

update-tox

feature/use-entrypoints

core-317-separate-core-and-default-distribution

update-lock-file

fix-docker-build

fix/fix-import

update-poetry-lockfile

core-158-documentation-needed-for-first-release

87-make-chronos-work-with-current-core

group-subject

bugfix/affected-teachers-in-header-box-shown-multiple-times

licence-information

day-names

merge

file-refs

school-apps

core-116-migrate-to-material-design-icons

36-room-management

issue34

94-use-btn-dark-everywhere

sqloptimise

issue12

lessons_day

issue19

6.1.0

6.0.0

5.0.1

5.0.0

5.0.0b0

4.0.1

4.0.0

4.0.0.dev10

4.0.0.dev9

4.0.0.dev8

4.0.0.dev7

4.0.0.dev6

4.0.0.dev5

4.0.0.dev4

4.0.0.dev3

4.0.0.dev2

4.0.0.dev0

3.0.2

3.0.1

3.0

3.0b0

3.0.dev1

2.5

2.4.2

2.4.1

3.0.dev0

2.4

2.3

2.2.1

2.2

2.1

2.1dev3

2.1.dev2

2.1.dev1

2.1.dev0

2.0

2.0rc3

2.0rc2

2.0rc1

2.0b2

2.0b1

2.0b0

2.0a3

2.0a2

delete-tag

2.0a1

1.0a3

1.0a2

1.0a1

1.0a0

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

  

source::aleksolotl

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

source::aleksolotl

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

nik

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

aleksis/AlekSIS-App-Chronos#59

No description provided.