Not storing groups for documentations is kind of a problem #351

Closed
opened 2025-01-05 20:01:52 +01:00 by hansegucker · 6 comments
Owner

Today, I stumbled over a new edge case:

  1. There was a lesson event without a course, but with a group (groups field) which has been documented in the coursebook (leads to documentation without any course or group information).
  2. There is a student who has been marked as absent in this documentation.
  3. Now, in the statistics overview of the group, the absent participation status of the student isn't counted because the documentation has no course.
  4. In the personal overview of the student, the absence is counted.

Conclusion: It's a problem to only store the course with the documentation.

Today, I stumbled over a new edge case: 1. There was a lesson event without a course, but with a group (groups field) which has been documented in the coursebook (leads to documentation without any course or group information). 2. There is a student who has been marked as absent in this documentation. 3. Now, in the statistics overview of the group, the absent participation status of the student isn't counted because the documentation has no course. 4. In the personal overview of the student, the absence is counted. Conclusion: It's a problem to only store the course with the documentation.
Author
Owner

Dev meeting decided: We store groups with the documentation as source of truth. Needs a migration to set groups for existings documentations (set from course, if course isn't set from amended lesson event).

Dev meeting decided: We store `groups` with the documentation as source of truth. Needs a migration to set groups for existings documentations (set from course, if course isn't set from amended lesson event).
Author
Owner

assigned to @permcu

assigned to @permcu
Author
Owner

assigned to @hansegucker and unassigned @permcu

assigned to @hansegucker and unassigned @permcu
Author
Owner
created branch [`351-not-storing-groups-for-documentations-is-kind-of-a-problem`](/AlekSIS/official/AlekSIS-App-Alsijil/-/compare/master...351-not-storing-groups-for-documentations-is-kind-of-a-problem) to address this issue
Author
Owner

mentioned in merge request !866

mentioned in merge request !866
Author
Owner

mentioned in commit 9e24f1eecd

mentioned in commit 9e24f1eecdfeceeca07495d9fab637698e4b90d0
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil#351
No description provided.