Only show "My overview" if personal notes exist #138
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-App-Alsijil#138
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As most teachers don't have any personal notes, this view is useless for them.
changed the description
created merge request !532 to address this issue
mentioned in merge request !532
I object.
At least, this needs a second thought (or the wording is ambiguous): A person can be a participant in one group (and have personal notes there), but be an owner in others.
The roles "student" and "teacher" are deliberately non-exclusive in AlekSIS.
Yes, you are right. My thought was to let it depend on whether a person has any personal notes.
changed title from {-Do not-} show "My overview" {-for teachers-} to {+Only+} show "My overview" {+if personal notes exist+}
changed the description
Rwworded accordingly.
But, I wonder if combining this with #137 (i.e. adding the functionality in #137 to "My overview") might be a better solution than removing the view for non-participants?
I think it would be a better solution to split up the functionality into two views because, as you already said, there can be a situation in which a person is a teacher and a student = has personal notes and made entries to the class register.
That does not justify two views, but rather two tabs in the same view (what exactly is not "my overview" about a view that shows all lessons I give as a teacher/group owner?)
Convinced. Close this in favor of #137
You should, however, split the templates accordingly so we can reconsider any time in case it turns out to be a bad idea.