Only show "My overview" if personal notes exist #138

Closed
opened 2021-02-23 19:24:06 +01:00 by hansegucker · 13 comments
hansegucker commented 2021-02-23 19:24:06 +01:00 (Migrated from edugit.org)

As most teachers don't have any personal notes, this view is useless for them.

As most teachers don't have any personal notes, this view is useless for them.
hansegucker commented 2021-02-24 11:25:19 +01:00 (Migrated from edugit.org)

changed the description

changed the description
hansegucker commented 2021-02-24 11:25:59 +01:00 (Migrated from edugit.org)

created merge request !532 to address this issue

created merge request !532 to address this issue
hansegucker commented 2021-02-24 11:26:00 +01:00 (Migrated from edugit.org)

mentioned in merge request !532

mentioned in merge request !532
nik commented 2021-02-24 11:28:04 +01:00 (Migrated from edugit.org)

I object.

At least, this needs a second thought (or the wording is ambiguous): A person can be a participant in one group (and have personal notes there), but be an owner in others.

The roles "student" and "teacher" are deliberately non-exclusive in AlekSIS.

I object. At least, this needs a second thought (or the wording is ambiguous): A person can be a participant in one group (and have personal notes there), but be an owner in others. The roles "student" and "teacher" are deliberately non-exclusive in AlekSIS.
hansegucker commented 2021-02-24 11:29:26 +01:00 (Migrated from edugit.org)

Yes, you are right. My thought was to let it depend on whether a person has any personal notes.

Yes, you are right. My thought was to let it depend on whether a person has any personal notes.
nik commented 2021-02-24 11:30:13 +01:00 (Migrated from edugit.org)

changed title from {-Do not-} show "My overview" {-for teachers-} to {+Only+} show "My overview" {+if personal notes exist+}

changed title from **{-Do not-} show "My overview" {-for teachers-}** to **{+Only+} show "My overview" {+if personal notes exist+}**
nik commented 2021-02-24 11:30:13 +01:00 (Migrated from edugit.org)

changed the description

changed the description
nik commented 2021-02-24 11:30:22 +01:00 (Migrated from edugit.org)

Rwworded accordingly.

Rwworded accordingly.
nik commented 2021-02-24 11:31:59 +01:00 (Migrated from edugit.org)

But, I wonder if combining this with #137 (i.e. adding the functionality in #137 to "My overview") might be a better solution than removing the view for non-participants?

But, I wonder if combining this with #137 (i.e. adding the functionality in #137 to "My overview") might be a better solution than removing the view for non-participants?
hansegucker commented 2021-02-24 11:34:35 +01:00 (Migrated from edugit.org)

I think it would be a better solution to split up the functionality into two views because, as you already said, there can be a situation in which a person is a teacher and a student = has personal notes and made entries to the class register.

I think it would be a better solution to split up the functionality into two views because, as you already said, there can be a situation in which a person is a teacher and a student = has personal notes and made entries to the class register.
nik commented 2021-02-24 11:36:35 +01:00 (Migrated from edugit.org)

That does not justify two views, but rather two tabs in the same view (what exactly is not "my overview" about a view that shows all lessons I give as a teacher/group owner?)

That does not justify two views, but rather two tabs in the same view (what exactly is not "my overview" about a view that shows all lessons I give as a teacher/group owner?)
hansegucker commented 2021-02-24 11:40:55 +01:00 (Migrated from edugit.org)

Convinced. Close this in favor of #137

Convinced. Close this in favor of #137
hansegucker (Migrated from edugit.org) closed this issue 2021-02-24 11:40:57 +01:00
nik commented 2021-02-24 11:42:40 +01:00 (Migrated from edugit.org)

You should, however, split the templates accordingly so we can reconsider any time in case it turns out to be a bad idea.

You should, however, split the templates accordingly so we can reconsider any time in case it turns out to be a bad idea.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil#138
No description provided.