nik/veripeditus-server
1
0
Fork 0
Code Issues 38 Pull requests Projects Releases Packages Wiki Activity Actions

on_* should get relevant, but optional attributes (like on_pass does) #95

New issue
Closed
opened 2017-02-18 18:51:18 +01:00 by nik · 0 comments
nik commented 2017-02-18 18:51:18 +01:00 (Migrated from edugit.org)
Copy link

The new on_pass method for Locations gets the passing player as an argument. The other on_* methods do not get any extra information.

We should either always pass the relevant information, or never. Please decide and fix accordingly ☺.

Please make on_pass and the others take optional arguments if you decide to pass extra information. Personally, I would use **kwargs for that and pass the relevant objects as keyword arguments.

The new on_pass method for Locations gets the passing player as an argument. The other on_* methods do not get any extra information. We should either always pass the relevant information, or never. Please decide and fix accordingly ☺. Please make on_pass and the others take *optional* arguments if you decide to pass extra information. Personally, I would use **kwargs for that and pass the relevant objects as keyword arguments.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
63-hybrid_properties-might-be-broken-at-some-points
master
issue-frjson
tg
tg2
branch-issue125
debian
branch-issue155
bugfoo
gh-note
117-new-attributes-api
feature/gdk
feature/editor
bug/association_proxy
feature-locations
licence-change
bug/source-access
global-testgame
camera-view
refactor-jsonapi
1.0.0a3
1.0.0a3.dev0
1.0.0a2
1.0.0a1
milestone-first-birthday
1.0.0a0.dev0
milestone-eiscafe
Labels
Clear labels   
Doing

   
To Do

   
bug

   
clarification needed

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
Doing
To Do
bug
clarification needed
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
1.0.0a2
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nik/veripeditus-server#95
No description provided.