New attributes API #117

New issue

Closed

opened 2017-04-02 23:18:04 +02:00 by nik · 9 comments

nik commented

2017-04-02 23:18:04 +02:00

(Migrated from edugit.org)

We want to move a more abstract API for setting attributes on game objects.

For setting an attribute: my_object.foo = bar
For getting an ttribute: my_obecjt.foo

Doing that, we also want to support storing arbitrary data types. It might be advisable to use the Pickle data type from SQLAlchemy as the attribute's value column instead of string.

The __setattr__ method must make sure to not handle attributes that are real databse columns - it must only handle attributes that are not used by the model itself! All others must be passed on to the superclass' __setattr__ method.

Same goes for __getattr__, which must return existing, real attributes verbatim.

Mind that there are a lot of corner cases for all of that!

We want to move a more abstract API for setting attributes on game objects. For setting an attribute: `my_object.foo = bar` For getting an ttribute: `my_obecjt.foo` Doing that, we also want to support storing arbitrary data types. It might be advisable to use the Pickle data type from SQLAlchemy as the attribute's value column instead of string. The `__setattr__` method must make sure to not handle attributes that are real databse columns - it must only handle attributes that are not used by the model itself! All others must be passed on to the superclass' `__setattr__` method. Same goes for `__getattr__`, which must return existing, real attributes verbatim. Mind that there are *a lot* of corner cases for all of that!

nik commented

2017-04-12 17:24:59 +02:00

(Migrated from edugit.org)

@Creeparoo please work in a new branch, branched from current master.

@Creeparoo please work in a new branch, branched from current `master`.

nik commented

2017-04-14 15:07:25 +02:00

(Migrated from edugit.org)

Started branch 117-new-attributes-api

Started branch [`117-new-attributes-api`](https://edugit.org/Veripeditus/veripeditus-server/compare/master...117-new-attributes-api)

nik commented

2017-04-14 15:47:44 +02:00